From patchwork Tue Nov 22 12:07:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yang Yang X-Patchwork-Id: 24331 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2163810wrr; Tue, 22 Nov 2022 04:15:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7AgmJTrPr2DK6YAqYljm4ck4CmOqEtI6greVp2oXMwAGZ4AyBpThvj9wJuhIChjLeIjX8+ X-Received: by 2002:a17:902:a503:b0:188:6baf:2011 with SMTP id s3-20020a170902a50300b001886baf2011mr3530661plq.165.1669119305424; Tue, 22 Nov 2022 04:15:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669119305; cv=none; d=google.com; s=arc-20160816; b=k432sauWOrArdkAZG6KGSEgcxYo3Z6PU1zpNthw6Vel+ppyToXFveggAAYBUdjUagL +L9k5QtON/kTqAVsuCuKPPJcycCwOVwWSQYfAdiOOGwWP2eEwwFXkMI/ONyJFfpFxdsO dCY55LIwsSPWnNJi8h6jMqfKlNN+piJLvvo9O1ZHnAS9RLL8gfK9rUCzoNWKZQ35VwA7 pURrEm1ZYjibAkIabp1p6QXGetTLlZY0nCyt8tIWlWbK5xjY/Z14x+l5Ti8mQy8RhFgg fdIB8T4MLzfN54GG2aU5g4QoEl8byQUDyv90EtoTwElkE+0Ai2nLEhC8GzzVQizzK6KB wtxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:cc:to:from:mime-version:message-id:date; bh=z7RAhU8Jt1KZ2Qk3njeoKUXiyThqgBsUJK8Wvg2GcMs=; b=p2bJ7zyvpoN7BkFUzOuNChP7Bh8XkzjDRYXuJU94t54f1jw+ORL/BQT+uLp2AGY4Ll qDE6BxN9T6gCP5jQ4RgUQFRgNL5jXnqu+Ays4/odnC6SBcBDPFuLb/b1W1jrLUeQbzpl m5k69JSQsLPExl+CrdrfJs8LmjiLFJ/ciK23vB1GgoFa4iLDnvJNcxkWra63TPbfWmE0 KnkplQJFrdiCpIosy1ndJT2eZIW57g/Vs7qDi+sE5+cqLkx/gUQh7NPOstj6LBEntDw6 YOeJY4J556jg3pDFjNLMw0UTEmVnjWn5OZjB83DiRWWObBz9trP8qZVMgqeoDAoRVy2G 9SwQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a6553c2000000b0047787372364si3915969pgr.363.2022.11.22.04.14.51; Tue, 22 Nov 2022 04:15:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=zte.com.cn Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232685AbiKVMII (ORCPT + 99 others); Tue, 22 Nov 2022 07:08:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232343AbiKVMIG (ORCPT ); Tue, 22 Nov 2022 07:08:06 -0500 Received: from mxhk.zte.com.cn (mxhk.zte.com.cn [63.216.63.35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 387DE2790D for ; Tue, 22 Nov 2022 04:08:03 -0800 (PST) Received: from mse-fl2.zte.com.cn (unknown [10.5.228.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxhk.zte.com.cn (FangMail) with ESMTPS id 4NGjh12Qybz5PkGj; Tue, 22 Nov 2022 20:08:01 +0800 (CST) Received: from szxlzmapp04.zte.com.cn ([10.5.231.166]) by mse-fl2.zte.com.cn with SMTP id 2AMC7uCC005801; Tue, 22 Nov 2022 20:07:56 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp02[null]) by mapi (Zmail) with MAPI id mid14; Tue, 22 Nov 2022 20:07:59 +0800 (CST) Date: Tue, 22 Nov 2022 20:07:59 +0800 (CST) X-Zmail-TransId: 2b04637cbb9ffffffffffa0dfedf X-Mailer: Zmail v1.0 Message-ID: <202211222007593082125@zte.com.cn> Mime-Version: 1.0 From: To: Cc: , , , , , , , , , , , , Subject: =?utf-8?q?=5BPATCH_linux-next=5D_drm/i915/gvt=3A_use_sysfs=5Fstreq?= =?utf-8?q?=28=29_instead_of_strncmp=28=29?= X-MAIL: mse-fl2.zte.com.cn 2AMC7uCC005801 X-Fangmail-Gw-Spam-Type: 0 X-FangMail-Miltered: at cgslv5.04-192.168.250.138.novalocal with ID 637CBBA1.000 by FangMail milter! X-FangMail-Envelope: 1669118881/4NGjh12Qybz5PkGj/637CBBA1.000/10.5.228.133/[10.5.228.133]/mse-fl2.zte.com.cn/ X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 637CBBA1.000/4NGjh12Qybz5PkGj X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750198444623065419?= X-GMAIL-MSGID: =?utf-8?q?1750198444623065419?= From: Xu Panda Replace the open-code with sysfs_streq(). Signed-off-by: Xu Panda Signed-off-by: Yang Yang --- drivers/gpu/drm/i915/gvt/cmd_parser.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/gvt/cmd_parser.c b/drivers/gpu/drm/i915/gvt/cmd_parser.c index 0ebf5fbf0e39..7b9a5f7f5363 100644 --- a/drivers/gpu/drm/i915/gvt/cmd_parser.c +++ b/drivers/gpu/drm/i915/gvt/cmd_parser.c @@ -917,8 +917,8 @@ static int cmd_reg_handler(struct parser_exec_state *s, return -EBADRQC; } - if (!strncmp(cmd, "srm", 3) || - !strncmp(cmd, "lrm", 3)) { + if (sysfs_streq(cmd, "srm") || + sysfs_streq(cmd, "lrm")) { if (offset == i915_mmio_reg_offset(GEN8_L3SQCREG4) || offset == 0x21f0 || (IS_BROADWELL(gvt->gt->i915) && @@ -931,8 +931,8 @@ static int cmd_reg_handler(struct parser_exec_state *s, } } - if (!strncmp(cmd, "lrr-src", 7) || - !strncmp(cmd, "lrr-dst", 7)) { + if (sysfs_streq(cmd, "lrr-src") || + sysfs_streq(cmd, "lrr-dst")) { if (IS_BROADWELL(gvt->gt->i915) && offset == 0x215c) return 0; else { @@ -941,12 +941,12 @@ static int cmd_reg_handler(struct parser_exec_state *s, } } - if (!strncmp(cmd, "pipe_ctrl", 9)) { + if (sysfs_streq(cmd, "pipe_ctrl")) { /* TODO: add LRI POST logic here */ return 0; } - if (strncmp(cmd, "lri", 3)) + if (!sysfs_streq(cmd, "lri")) return -EPERM; /* below are all lri handlers */ @@ -1011,7 +1011,7 @@ static int cmd_reg_handler(struct parser_exec_state *s, */ if (GRAPHICS_VER(s->engine->i915) == 9 && intel_gvt_mmio_is_sr_in_ctx(gvt, offset) && - !strncmp(cmd, "lri", 3)) { + sysfs_streq(cmd, "lri")) { intel_gvt_read_gpa(s->vgpu, s->workload->ring_context_gpa + 12, &ctx_sr_ctl, 4); /* check inhibit context */