From patchwork Tue Nov 22 15:35:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 24436 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2283127wrr; Tue, 22 Nov 2022 07:38:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf7BkQ4g0gQ3Ulc5volrX7QbXyUvr87JsW9Wo2CJMDXtrbBcmIGPpOc4GrAue7F/WGgdIw5G X-Received: by 2002:a17:906:19d7:b0:7b2:b782:e1df with SMTP id h23-20020a17090619d700b007b2b782e1dfmr16126814ejd.308.1669131520410; Tue, 22 Nov 2022 07:38:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669131520; cv=none; d=google.com; s=arc-20160816; b=H/7/r8GU1QpQ5GRpAFy2WkXsXik0OEroMOXb91vUGPExe6X4+K6NNZScM4fvXhTzXu qbCQ1nBwGUibgHWmCWZhyzLQiTcbDfBbtuQCeYEYnL72zOdD2DIiKm0yiVa7rEu4vJWd 6vaIptyNw7VyWIX4uwot9/sit7vsQCa0YD3Gw8xEFBsImcq+A6KU9y3ZxyQZ2/YXQHRt Ij+u2AvTCbe2NOtX3XG3zeAV0bGqtaiSfh/Gb4LnqFIeyiL0RS22qEL/4jd6VaMBAGaE n9O7/2aS8WGQNW3BDhGmIodVXXFvzsvTNN+YsbJ0ctf4VDR4BSe8i3Afrxwx6Xzdw+fY RtPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=1Qtx7ZlRqQzibs+Sjim2+WzP1E23CpTGh86NOik24JI=; b=N2AeY5bmdVgl+f8hAvcbvOH1dqlAeVmRM0kjUBO9OgG5z9PuYCKJ115Ad9PBX9AQ8t vdn0878DCrVsDdly42eEzP5xSxCwkghUEcL9a/MkR7/+x74935dVCmZ/ABF1AMVy8qWZ BjxiFKKaDwMXiTBubTKtuvmiSk8kGOA7+1FoyA1bIaPPV6Aw9CirkSs7pM7Wa7tGPphH BWdm6f+M1mZGVuttIzbe61dNEw7u4+NvaYNf5wEDRBytv4GBBBQQ3TMXkSs1NV+sgpjY VzQbktF56/pg/r8rCXguR9g7RSTAmmCiAQpDh5ubjbUS2Z0f125LJ0XdvOGKUhMNllg8 9yMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mC07Z9IL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ds6-20020a0564021cc600b0045c26f0050esi11974208edb.238.2022.11.22.07.38.16; Tue, 22 Nov 2022 07:38:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=mC07Z9IL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232763AbiKVPfZ (ORCPT + 99 others); Tue, 22 Nov 2022 10:35:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232723AbiKVPfP (ORCPT ); Tue, 22 Nov 2022 10:35:15 -0500 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27620682B7; Tue, 22 Nov 2022 07:35:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669131315; x=1700667315; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Lk7Aa8ZXFKY55rSbLTJ7BLbpsyJEXtHLhmH5NxdPyRU=; b=mC07Z9ILSsILE0OlTdG+lBfblmmeYu5gBo/4SHNITVYWO/TrUvIxOQAc h9x95sEG+FIb7k/EThUmyQ+KAlLPcmHUeQoOgGDbGfMZF8l4npn8ecCpV 4I/hVw8Yp63v6XN2niZ3Zp56OsjuaqnL1KoUm/pQimqdxbKGrQT2me0yS /GeQA152JcCrSG0/f0hwVPTFIaabgMacbTQKTK2I9bXCtJzzVp4SsOjTd wlvK8O8mBuo87PI0ZWX1hsAo+2UvUT5NaebahCvTmSusGZrKfhFOJPu/k +YrMv1mLQ/Z8pacPBCkxoPjXOLrjgmIoqtjaerf6wvYTYWcKLkYAdfzLT A==; X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="315662399" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="315662399" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 07:35:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10539"; a="730435563" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="730435563" Received: from black.fi.intel.com ([10.237.72.28]) by FMSMGA003.fm.intel.com with ESMTP; 22 Nov 2022 07:35:00 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4560E128; Tue, 22 Nov 2022 17:35:26 +0200 (EET) From: Andy Shevchenko To: Jakob Koschel , Andy Shevchenko , Greg Kroah-Hartman , Mathias Nyman , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Kevin Cernekee , Mathias Nyman , Hans de Goede , Jani Nikula Subject: [PATCH v3 1/4] i915: Move list_count() to list.h for broader use Date: Tue, 22 Nov 2022 17:35:13 +0200 Message-Id: <20221122153516.52577-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750211253140519629?= X-GMAIL-MSGID: =?utf-8?q?1750211253140519629?= Some of the existing users, and definitely will be new ones, want to count existing nodes in the list. Provide a generic API for that by moving code from i915 to list.h. Signed-off-by: Andy Shevchenko Acked-by: Jani Nikula --- v3: added tag (Jani), changed to be static inline (Mike) v2: dropped the duplicate code in i915 (LKP) drivers/gpu/drm/i915/gt/intel_engine_cs.c | 13 +------------ include/linux/list.h | 15 +++++++++++++++ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c index 6ae8b07cfaa1..b5d474be564d 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c @@ -2085,17 +2085,6 @@ static void print_request_ring(struct drm_printer *m, struct i915_request *rq) } } -static unsigned long list_count(struct list_head *list) -{ - struct list_head *pos; - unsigned long count = 0; - - list_for_each(pos, list) - count++; - - return count; -} - static unsigned long read_ul(void *p, size_t x) { return *(unsigned long *)(p + x); @@ -2270,7 +2259,7 @@ void intel_engine_dump(struct intel_engine_cs *engine, spin_lock_irqsave(&engine->sched_engine->lock, flags); engine_dump_active_requests(engine, m); - drm_printf(m, "\tOn hold?: %lu\n", + drm_printf(m, "\tOn hold?: %zu\n", list_count(&engine->sched_engine->hold)); spin_unlock_irqrestore(&engine->sched_engine->lock, flags); diff --git a/include/linux/list.h b/include/linux/list.h index 61762054b4be..65aab596ae33 100644 --- a/include/linux/list.h +++ b/include/linux/list.h @@ -655,6 +655,21 @@ static inline void list_splice_tail_init(struct list_head *list, !list_is_head(pos, (head)); \ pos = n, n = pos->prev) +/** + * list_count - count nodes in the list + * @head: the head for your list. + */ +size_t list_count(struct list_head *head) +{ + struct list_head *pos; + size_t count = 0; + + list_for_each(pos, head) + count++; + + return count; +} + /** * list_entry_is_head - test if the entry points to the head of the list * @pos: the type * to cursor