From patchwork Tue Nov 22 14:52:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sascha Hauer X-Patchwork-Id: 24419 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2252309wrr; Tue, 22 Nov 2022 06:55:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf7M1cG6hBFk/6rFzSwh9n+tnIcY01fQsanTLjZHE9I0QK07+o4OiZG6RsXzFVrfPprlU/CD X-Received: by 2002:a17:906:3fd0:b0:7af:9bff:8de6 with SMTP id k16-20020a1709063fd000b007af9bff8de6mr3732741ejj.91.1669128941769; Tue, 22 Nov 2022 06:55:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669128941; cv=none; d=google.com; s=arc-20160816; b=gAp84nDH7WGtg62qfeIrjkYnQQc+1mgWSNh3AeCIx1IoPINa16awHldQ6rqO8ESdvN 51TS8Owqcec3IVR+/AiKzzF60TCkpHQ+SKG88LTOelPpQd4znUifG+ab9GGsW65OzuR1 cZ00ikQAD9yY7agbf9AzBK7kTsU06fPIblWq9HB8rXCg57MsX2DnrGRf6rgBjD8XEguF mvM6aiP87HrjaOJXZElftxk85Qm9fBZk2YuJsdH3TkUX7VXZ7RtTpgCT40FPYq5mFG79 JSP3OllUdNO5HWKvelb4sDCCQ0PpdS+VJwqVPjywtEXBf/cdQLXTi1FEmG1awZWUmTUV y7Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=/dybKfChi/+d7OPKnE2rmef0Lq7KuoLknfLczEzSLlg=; b=SrJSkvcoZE0LfYCXIBA7SMaK3dTjb0IZh4ootjtX+8vUMt4kiF+NM+iVtb44VmaXJ/ F9dG0OJpLq4aDVcxiQLdmTq6LCQbG7fXqgX6hNzaXzFditHKAJlWh7GvtgFnVtRZ+Ge/ A6zS8xpYjaKBI00MVNx/XlMCFlEDRLD3w2z0DfbuZPRjT2q7YWBiRxh461niVZEDxNek 6RO1lrCE+CbW3KRblLbAabhxtJAZWDRyspe/TaMyizMKITwrvkUfeYHYx2udI3hDvf9s zuMcHFkt+BJ+p2mjZFjFjj9eGiJoa+uj1FefNtNkSujeX+Hh3P9mWSSIvsL5izZz6s/y fPRw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cw15-20020a170906478f00b0078e11a20640si14104714ejc.2.2022.11.22.06.55.17; Tue, 22 Nov 2022 06:55:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234104AbiKVOyN (ORCPT + 99 others); Tue, 22 Nov 2022 09:54:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233788AbiKVOxb (ORCPT ); Tue, 22 Nov 2022 09:53:31 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A388FD28 for ; Tue, 22 Nov 2022 06:53:02 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxUdc-0006Lo-4p; Tue, 22 Nov 2022 15:52:40 +0100 Received: from [2a0a:edc0:0:1101:1d::28] (helo=dude02.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oxUdY-005s7q-Ts; Tue, 22 Nov 2022 15:52:37 +0100 Received: from sha by dude02.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oxUdX-00H3kZ-Jd; Tue, 22 Nov 2022 15:52:35 +0100 From: Sascha Hauer To: linux-wireless@vger.kernel.org Cc: Neo Jou , Hans Ulli Kroll , Ping-Ke Shih , Yan-Hsuan Chuang , Kalle Valo , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , kernel@pengutronix.de, Johannes Berg , Alexander Hochbaum , Da Xue , Po-Hao Huang , Viktor Petrenko , Sascha Hauer Subject: [PATCH v3 02/11] rtw88: Call rtw_fw_beacon_filter_config() with rtwdev->mutex held Date: Tue, 22 Nov 2022 15:52:17 +0100 Message-Id: <20221122145226.4065843-3-s.hauer@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221122145226.4065843-1-s.hauer@pengutronix.de> References: <20221122145226.4065843-1-s.hauer@pengutronix.de> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750208549374896854?= X-GMAIL-MSGID: =?utf-8?q?1750208549374896854?= rtw_fw_beacon_filter_config() is called once with rtwdev->mutex held and once without the mutex held. Call it consistently with rtwdev->mutex held. Signed-off-by: Sascha Hauer Reviewed-by: Ping-Ke Shih --- drivers/net/wireless/realtek/rtw88/mac80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtw88/mac80211.c b/drivers/net/wireless/realtek/rtw88/mac80211.c index 07578ccc4bab3..776a9a9884b5d 100644 --- a/drivers/net/wireless/realtek/rtw88/mac80211.c +++ b/drivers/net/wireless/realtek/rtw88/mac80211.c @@ -487,8 +487,8 @@ static int rtw_ops_sta_remove(struct ieee80211_hw *hw, { struct rtw_dev *rtwdev = hw->priv; - rtw_fw_beacon_filter_config(rtwdev, false, vif); mutex_lock(&rtwdev->mutex); + rtw_fw_beacon_filter_config(rtwdev, false, vif); rtw_sta_remove(rtwdev, sta, true); mutex_unlock(&rtwdev->mutex);