From patchwork Tue Nov 22 13:07:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 24354 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2190290wrr; Tue, 22 Nov 2022 05:11:08 -0800 (PST) X-Google-Smtp-Source: AA0mqf48I+CH3qrXE4iNAGlPwbDmboH8KZY7zuj0SPMwhMvuvEdyAC1pD9sMDShAzj4W9uRmzyfa X-Received: by 2002:a17:90a:fb84:b0:218:7e9d:9617 with SMTP id cp4-20020a17090afb8400b002187e9d9617mr4118177pjb.133.1669122667823; Tue, 22 Nov 2022 05:11:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669122667; cv=none; d=google.com; s=arc-20160816; b=OCt6DEht5HZzfKIuVCxEMJLEXgniGDR+zv0FTp1V6hMZ2ZfYT2HGRrZkps1N2gw5bP uVOPeA3z5MQrWzDr90UlDA2Fxo1QgMWRTgaVxdlB/6wpyacx97v3NwGblilkwE9Ac3uS ZzODLq5+rMY8Eswv/VTOf3n0wRKeCYJAkcyhNRJBNRMxOJKiCYa8uLo/Ums1MKVQvF/G uVbQB8kHbiAUwNLnTvDTiTHWAn/HoVH8sfBIsuiSmWClIbSyw+eOv9U5YqoDr54BWgT5 5Kd5Ajm9TA7zn41o396NCnecxRwAzkzx3ZqdGSrYwGBTO/xe1TZ/CeHjhtZVQOrg9Vww eVwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WWdA9MBMp3BF8b5TXg1/9bKbR773F1pzzlpCtDxJ7LM=; b=CoMl2WlO2cuWKfg+YIvpoKsIq4cykjZp3XKP+EtC9FQ3FsMcbNrogW8uJTyqKIqZF7 U2NE9+EB5/l9tY0Wsek5dC48ZjoDVZcn8sTIEEQv5qsNYV9lyD4x0w/AbxhqxOxZXY+F 3Q6xue7MSzDOaVYTQPyuMGelnNnQUrXsVDM5ZE6geIzr++UpTM+qeEJSHFLbxIUHC9Vz Ij7BuELQWSrF4FUyLNwPfKv176iOdeXPTYuP9yEDbnYOcUjfUsAoN76HYgIGdh9hC7CE Ht+CUprLDCGi1h/naQUctiLMPPcRuN/6mBUQOCAymDsqob7gcU4ktZ+IE3oE0OOAtd6o vCEA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OMwSFDaN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d17-20020a056a00199100b0056c01ece001si14966476pfl.252.2022.11.22.05.10.54; Tue, 22 Nov 2022 05:11:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=OMwSFDaN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233435AbiKVNHR (ORCPT + 99 others); Tue, 22 Nov 2022 08:07:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232849AbiKVNHM (ORCPT ); Tue, 22 Nov 2022 08:07:12 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3D3826238B; Tue, 22 Nov 2022 05:07:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1669122431; x=1700658431; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=JvcE92gKvOcwLrDEGyRbhKXu2OVvTqGr3iFpwDsrMbM=; b=OMwSFDaN6gHOiW3OUAE00JJo8Netpm20PKeHLmIl7HrbW6RJ7sZZ+aQD I9T9gvxxYlHcORdZMir9nbGirXjB19UwRjJIcR/R7WCyqoL7iM6SPC01w mEqDu769XoYNMwmVyUu8+CqK/s8E9qphZCpP9gbDKFYkf0z1g0Jxc6Qfx EEfgGfBca+8MAJyEBBfezzXbXV11waaWmBdrBBI1bh3oEivVlxZRuXCik RVxUXYIbZ1wPtsYY6jrSXwlKyF6oXrH4kNI/BJP/wQKFcJP7ajrOdOzK/ 0nlfsDbz7K/jxyITJfhZvmGMJCdfQ+rAve68R5MjYSSMFQYYcEF2TD01N A==; X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="301358045" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="301358045" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2022 05:07:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10538"; a="619206110" X-IronPort-AV: E=Sophos;i="5.96,184,1665471600"; d="scan'208";a="619206110" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 22 Nov 2022 05:07:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id E0B95F7; Tue, 22 Nov 2022 15:07:33 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michael Turquette , Stephen Boyd Subject: [PATCH v2 2/3] clk: fractional-divider: Show numerator and denominator in debugfs Date: Tue, 22 Nov 2022 15:07:31 +0200 Message-Id: <20221122130732.48537-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221122130732.48537-1-andriy.shevchenko@linux.intel.com> References: <20221122130732.48537-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750201970676707333?= X-GMAIL-MSGID: =?utf-8?q?1750201970676707333?= It's very useful to see what are the values of the fractional divider. For that, add respective debugfs files. Signed-off-by: Andy Shevchenko --- v2: no changes drivers/clk/clk-fractional-divider.c | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c index 5c6f1d0f8fb4..b6b52b79d671 100644 --- a/drivers/clk/clk-fractional-divider.c +++ b/drivers/clk/clk-fractional-divider.c @@ -39,6 +39,7 @@ */ #include +#include #include #include #include @@ -193,10 +194,45 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate, return 0; } +#ifdef CONFIG_DEBUG_FS +static int clk_fd_numerator_get(void *hw, u64 *val) +{ + struct u32_fract fract; + + clk_fd_get_div(hw, &fract); + + *val = fract.numerator; + + return 0; +} +DEFINE_DEBUGFS_ATTRIBUTE(clk_fd_numerator_fops, clk_fd_numerator_get, NULL, "%llu\n"); + +static int clk_fd_denominator_get(void *hw, u64 *val) +{ + struct u32_fract fract; + + clk_fd_get_div(hw, &fract); + + *val = fract.denominator; + + return 0; +} +DEFINE_DEBUGFS_ATTRIBUTE(clk_fd_denominator_fops, clk_fd_denominator_get, NULL, "%llu\n"); + +static void clk_fd_debug_init(struct clk_hw *hw, struct dentry *dentry) +{ + debugfs_create_file("numerator", 0444, dentry, hw, &clk_fd_numerator_fops); + debugfs_create_file("denominator", 0444, dentry, hw, &clk_fd_denominator_fops); +} +#endif + const struct clk_ops clk_fractional_divider_ops = { .recalc_rate = clk_fd_recalc_rate, .round_rate = clk_fd_round_rate, .set_rate = clk_fd_set_rate, +#ifdef CONFIG_DEBUG_FS + .debug_init = clk_fd_debug_init, +#endif }; EXPORT_SYMBOL_GPL(clk_fractional_divider_ops);