From patchwork Tue Nov 22 10:21:21 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 24253 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp2118816wrr; Tue, 22 Nov 2022 02:24:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf5agE3Vizr14MEHZsE2qyN0gbP0Z4Lw6S7pZziQ6qGiE/JzJRokAnobnWlXEc75feKb5M1t X-Received: by 2002:a17:906:c042:b0:781:541:8f1d with SMTP id bm2-20020a170906c04200b0078105418f1dmr19706340ejb.117.1669112673641; Tue, 22 Nov 2022 02:24:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669112673; cv=none; d=google.com; s=arc-20160816; b=zNP8pCmt7BXDVQTLkRsTUIoe6xAPDU3LhHs+awucIYqOBfJZDh3e/sk981h4UatgWW ThufE5WTnjOL1KZyiMscN6z4emWX2RSMz6zY34N3WtnlC4VszGBnbEtmIFcx6Q0wOFhS s2WAUsr+hdbuHl+MCVeQ2B57pHHGz43yYVVs9SD8pvClENdS7KkfdcSyuKDfeb3EyjN0 uR48Uh6JBtIdjU7y+B+qRcPUwo5FB/Il9cD4WvH+O12E3wuolGpk9wIbU/GPsluAxtHG g1TEanuJnmXfc/DthuyR1zhDflX+DCNMpWtecQK2mK/Ig1Az6Pq552UAMREsY0D6tK8H 4RWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yBSJ9X9pr9Z0i2+NFcnle+eN9VzlxNW46WoYTtGtQAo=; b=qRUozAssQj2/6sAk1vnlivSISJLViw9EVGGhpX1tUYvbvlTyFImtdjNJyOfZL3BwAi wii7KWCF41pnsY8JDBGzDKYwVklKzR2Q6/TP7bLAyEfxAxZ3+hv6/IsGpZPLeiTmfmiE +fVc7iXJhaeOWbCawZYS8q0Oir3Q0DMhKfeeZWUEc4Ri0420G1KryMFOqzx8b+y9pUC+ viiMNqjJ6+ByHySnSTH4YNYNu9iZgatajeD+iovKDBj/DfpSvsWbK2huIMMogh3+QrDI zQZjfH/VY07zLCS+i64GMx9Ps9/1IcQGRwmj+Z+zKb3V8VHsdXPJNHoT4Y9g4DnG8Giy sxLw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=cNOOrBVD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o11-20020aa7c50b000000b004630539ab29si1175015edq.101.2022.11.22.02.24.09; Tue, 22 Nov 2022 02:24:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=cNOOrBVD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233626AbiKVKXg (ORCPT + 99 others); Tue, 22 Nov 2022 05:23:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbiKVKWJ (ORCPT ); Tue, 22 Nov 2022 05:22:09 -0500 Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3B68943867 for ; Tue, 22 Nov 2022 02:21:52 -0800 (PST) Received: by mail-wm1-x335.google.com with SMTP id ja4-20020a05600c556400b003cf6e77f89cso925936wmb.0 for ; Tue, 22 Nov 2022 02:21:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=yBSJ9X9pr9Z0i2+NFcnle+eN9VzlxNW46WoYTtGtQAo=; b=cNOOrBVDDBxp8Mc+etJ2bnstzSg1Lzp5SAUFfR5Ck/B28wVrN1R9+kJTGe4UPeXN20 Zu1NxMwctssO70t4AhcPojH9Lpd/OtIVYxCP/o9t4g/osQ4RmxjOUk8kIaLIBQF2LTGI DzyLxy/b76Ry0jdaUUPWKo3Nfe1MipiYEfkSOr7cffF2StDF4vuszG4StaL+rdKN7ywA ltZaddUhWCDNpCdOEbMKnGmEWn6OQRtY2/yxSTsppKMnfHg3nLC+8DDm6ndI2qqMhwwL xEmt7dQflPtTlvn2Rhwr3DlFu+HeFd9HeWUU16GLiORzmPYaUnclQePBH3oRJ6LrsvBj OVPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yBSJ9X9pr9Z0i2+NFcnle+eN9VzlxNW46WoYTtGtQAo=; b=jaW4ph6Ng3V1kRpkUbnIdnInVxvlwea/hAU0B1nfAbisHxMPvfAvXZbeZmJZYhAOid 6ECmmFBFqcs8f8mA400CCBGejtcPNBA1Pidr0ZA16qsSnCMILeH0u4RStFxf8jNQ1rMl igORs5gavNUnlUhX1UIrly0Zs0nC/TLdy7e8FVLKbQCXfjBe2oU6AjshUtTENbmWr28C eaBnHziUvL9x3l3JzfBw8FWlzYBpFMtYpV9k4IJ2E6BJzYQO4FXP87LazqI6gcp+A8H6 oKLAStg+vTV9/99A49KlLZSha7Z+PGtQ/qI7pVSRAMGG5P6PSIMbRKOpMluzPboTRrDS Ng3w== X-Gm-Message-State: ANoB5plON4Tr8f4/SwpTGGUTujTAaQ34qtZdoWNJHlgR1ayBYNLDiXYM vernXCuxelKh6JZN6Ocq13WnRLmEdvdScA== X-Received: by 2002:a05:600c:384f:b0:3cf:9377:c76f with SMTP id s15-20020a05600c384f00b003cf9377c76fmr3817135wmr.189.1669112511702; Tue, 22 Nov 2022 02:21:51 -0800 (PST) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:e011:9e81:66f1:3415]) by smtp.gmail.com with ESMTPSA id o3-20020a5d4083000000b002366e8eee11sm13432873wrp.101.2022.11.22.02.21.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 02:21:51 -0800 (PST) From: Bartosz Golaszewski To: Andy Gross , Bjorn Andersson , Konrad Dybcio , Greg Kroah-Hartman , Jiri Slaby , Srinivas Kandagatla , Vinod Koul , Alex Elder , =?utf-8?q?Ilp?= =?utf-8?q?o_J=C3=A4rvinen?= Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, Bartosz Golaszewski , Konrad Dybcio Subject: [PATCH v2 11/15] tty: serial: qcom-geni-serial: stop operations in progress at shutdown Date: Tue, 22 Nov 2022 11:21:21 +0100 Message-Id: <20221122102125.142075-12-brgl@bgdev.pl> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20221122102125.142075-1-brgl@bgdev.pl> References: <20221122102125.142075-1-brgl@bgdev.pl> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750191491013180110?= X-GMAIL-MSGID: =?utf-8?q?1750191491013180110?= From: Bartosz Golaszewski We don't stop transmissions in progress at shutdown. This is fine with FIFO SE mode but with DMA it causes trouble so fix it now. Signed-off-by: Bartosz Golaszewski Reviewed-by: Konrad Dybcio --- drivers/tty/serial/qcom_geni_serial.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 036231106321..82242a40a95a 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -865,6 +865,9 @@ static void get_tx_fifo_size(struct qcom_geni_serial_port *port) static void qcom_geni_serial_shutdown(struct uart_port *uport) { + qcom_geni_serial_stop_tx(uport); + qcom_geni_serial_stop_rx(uport); + disable_irq(uport->irq); }