From patchwork Mon Nov 21 11:21:32 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Potapenko X-Patchwork-Id: 23680 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1525771wrr; Mon, 21 Nov 2022 03:29:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf7vrcnnz1pcUBVPOVLpVpCvUbqRx3OUHPqWJlHcJT3YODGqRcJJsFk7TGVoFP5NBxMFxQc+ X-Received: by 2002:a65:4607:0:b0:477:31bc:348f with SMTP id v7-20020a654607000000b0047731bc348fmr851477pgq.72.1669030183158; Mon, 21 Nov 2022 03:29:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669030183; cv=none; d=google.com; s=arc-20160816; b=s/c4jHvHLYVtjoCm3Y4xIEG+nsEjgpL9d3iRlL0uaZIp9UZTFU5874sTc4V+EYvolz p5q1GahKSbue1zJKVU10dc/xVW0dj5FdJg4T+hphGjyUIXzYPtQdwKshGeDdsCJsjS3h qLN3IUBz8O+md5Yu7s+JoZ2kZMDs5TUPb+oYtHun2+J/7Neehq1sBG6K/sJgM9OS/Qe3 n98nOu+PP/AwNEE6kvnr5P0bEDGRK5TLnUIidyMdMGlKN1rXsrE4XHMnaveViBrsldDZ iWfHgQr68WyIYihLoXSpMWSBYxCQYstXNpoQE0GoJx0IIApd27EMYEm5sOLk8mzG0Bo/ HliQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=V3ROk7430AgCjRwu8JCLeHALA6B0dvLhERaon//wlR0=; b=c71L9+qbBN2uou0MqE5YxgKIPNhf+X88rXeLfPazjZw5RHBnWdQ/apR19A0KNgm91Q XCmImqHTPvhyzDqqw3MJU0dacxtzg8UwDT52n6MTD4RBnU/kYZLf1Ar25EHwsyaETX3o GTPDHKyuqzlZ1p7KZ1TwY4EiNzqOb9q/oAaodVV+dkcc4u+9Xgm3hGk6+/q3YmyTEfWD Szz53JNUnlUkKs+wcnkJuA7SW1XqVytx3A8mb6w81iqRj0sL+P86TvvalOlenfViQE0R hrizMQ1/0if/fnxrJnh0iR0CJOJpBPFNoLnAVGLmwGkRYk1Dmx9L8nnyA1CvUNeiQz9e Kadg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=VyCfbuWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l5-20020a056a00140500b005644806915csi11429922pfu.42.2022.11.21.03.29.29; Mon, 21 Nov 2022 03:29:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=VyCfbuWO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbiKUL0r (ORCPT + 99 others); Mon, 21 Nov 2022 06:26:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbiKUL0O (ORCPT ); Mon, 21 Nov 2022 06:26:14 -0500 Received: from mail-wm1-x349.google.com (mail-wm1-x349.google.com [IPv6:2a00:1450:4864:20::349]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB31B6B29 for ; Mon, 21 Nov 2022 03:21:45 -0800 (PST) Received: by mail-wm1-x349.google.com with SMTP id e8-20020a05600c218800b003cf634f5280so2974577wme.8 for ; Mon, 21 Nov 2022 03:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=V3ROk7430AgCjRwu8JCLeHALA6B0dvLhERaon//wlR0=; b=VyCfbuWOem8BwV+1kbZt92/iURKerhApO5tHJL82Q3g8gJjhEf8Gf81lkNXinPV0WG 33XKENJFJcX8AOPHW1fpifSRoqxXlHBwqxVqieU0qAQ3CQLak9yv9kSmC8Cd+mpuXWqA dMw4MYS/tqwBn9HATfin7JwAng24nM99T15wf8oiaR3VGtSchxTXvOchJ46VW/seRWPz sXs38pJvJqRP0PnnJsEFB9KY5UE+hWn5HdPDuNxMBW9IoYXeVIqpE2I6F0yMLJyOGUuI BmntwbMnaWN9YoJTyImpLCf9dUeBmBP1Zw2C7sgj5r2JExdS6DMuSGOCl6Jd1Ab+9sfj 6cPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V3ROk7430AgCjRwu8JCLeHALA6B0dvLhERaon//wlR0=; b=rz1WRjAJmlmpje5fSj1vcoH+t+EXkJrfRceD6XXXsPcT//tIFCFkXxh2ib2h+oWfcS ctf916bbNgUvA9okzvNcGWeDNsFgcXcFDcflZtPWjs2KTxu+607ZSjXnOUA75k/Re2K7 Ejz+Y2HZ2pJhyRJHPINjAtIYyyycXSGifu7ci4rwiy0os85FYnGakFZiQBPDqvxqBYrg n95s9UFR9fLdKcCg/1obeYs/G5L0VEh8tca0Wn4JUWoetCQ3nCfsBLsFkycRjfyWfZBp IIoB7bW8Ed7PIMe2sTXeAphPjx6dRMBEoYfA3UEcu1flKwuO2tf7HurcNfiAWvcNHs7x AF2w== X-Gm-Message-State: ANoB5pn7+Dd0rroirE2MH8vtnngzueZG7dqVFZ8uux+wj/BSo7cZ0FZc iMp3GWjEfnWCL8ThVpIhy9o2FASYTrg= X-Received: from glider.muc.corp.google.com ([2a00:79e0:9c:201:db68:962:2bf6:6c7]) (user=glider job=sendgmr) by 2002:a5d:6706:0:b0:241:cf90:ab1e with SMTP id o6-20020a5d6706000000b00241cf90ab1emr1020206wru.685.1669029703858; Mon, 21 Nov 2022 03:21:43 -0800 (PST) Date: Mon, 21 Nov 2022 12:21:32 +0100 In-Reply-To: <20221121112134.407362-1-glider@google.com> Mime-Version: 1.0 References: <20221121112134.407362-1-glider@google.com> X-Mailer: git-send-email 2.38.1.584.g0f3c55d4c2-goog Message-ID: <20221121112134.407362-3-glider@google.com> Subject: [PATCH 3/5] fs: f2fs: initialize fsdata in pagecache_write() From: Alexander Potapenko To: glider@google.com Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750104993195490170?= X-GMAIL-MSGID: =?utf-8?q?1750104993195490170?= When aops->write_begin() does not initialize fsdata, KMSAN may report an error passing the latter to aops->write_end(). Fix this by unconditionally initializing fsdata. Suggested-by: Eric Biggers Fixes: 95ae251fe828 ("f2fs: add fs-verity support") Signed-off-by: Alexander Potapenko Reviewed-by: Eric Biggers --- fs/f2fs/verity.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c index c352fff88a5e6..3f4f3295f1c66 100644 --- a/fs/f2fs/verity.c +++ b/fs/f2fs/verity.c @@ -81,7 +81,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, size_t n = min_t(size_t, count, PAGE_SIZE - offset_in_page(pos)); struct page *page; - void *fsdata; + void *fsdata = NULL; int res; res = aops->write_begin(NULL, mapping, pos, n, &page, &fsdata);