From patchwork Mon Nov 21 11:21:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Potapenko X-Patchwork-Id: 23678 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp1525693wrr; Mon, 21 Nov 2022 03:29:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf5bG4jf3DiMZHA2ULzlnPevEPmhPKfBTava7bwMZ22sD02Q73P2LtDu1qbiCVBULnO9yc4f X-Received: by 2002:a65:5546:0:b0:470:8f8b:c9e0 with SMTP id t6-20020a655546000000b004708f8bc9e0mr333908pgr.390.1669030176183; Mon, 21 Nov 2022 03:29:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1669030176; cv=none; d=google.com; s=arc-20160816; b=F+yGiG+GbEIrJMElgWU5VwcWL1paTFnVjotniTQitd2ZeuYjDQt94MWXRAeSfQvKOt 62B28weXbrvoI42WddtqfU1ZqPZjHuabe0gXPjQJhiqqpSdkYafgIM25Y9/9RcSoumF5 F5vUS5VaYHB/MUX6aaQKGrD2+U2w4i5o1KAakrsxR47Y7uHSUPDQT9j3i7RBognz8Rl7 ChtP2rLN7MnFxeIZwRe7OipUt2E9L6Pb5yFzo/+4oDva3OdQFrklP7LmlmGd8GCTbHQk mGqzzNbsdn43uKblKK7F28krfGkyaLQCmBymyXVtSY7jSIKL/DM/bFhXom6yxQqWP4fP jZBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=V66iN5ZNYfCs2IKwl/XWPfYUEeh8Am+8/6YCzEI2D8c=; b=Mh0yx5kWjBDDXv28WqnOn8HYGUUKZiXUYDSYSvyJi6keaI/b8GnQ7YVxEZjlE2DLbn 3ClsH5rz8FolNgpdw/nSNJ5eujwel2NsgO3cEENyLEdrv2RbZTXz0z2SzNkcKO9Ln232 Z5vmwZ9bgspi6rLIugUG470kFVjxtlRQWP0bpi8rurXuMX43OUoIRdnaLWswWm8S1v3e AwsqCQlEOHgkc/HgfQHFfHgOLjUcyRxMYGBiSvlVquw6AiDGUF+JYWluPojVJpmENuPx wc38+AZtXPTEOB6w8y0Djso8qhkGm/t46qYLgUgWdWJJMn3k4Fq7zmhzPRXbSryVOcXt bFFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=DrqkFhwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t18-20020a63b252000000b0045d1aa2a586si10572842pgo.197.2022.11.21.03.29.21; Mon, 21 Nov 2022 03:29:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=DrqkFhwq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230104AbiKUL1M (ORCPT + 99 others); Mon, 21 Nov 2022 06:27:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230309AbiKUL0M (ORCPT ); Mon, 21 Nov 2022 06:26:12 -0500 Received: from mail-wr1-x44a.google.com (mail-wr1-x44a.google.com [IPv6:2a00:1450:4864:20::44a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8327DBFF63 for ; Mon, 21 Nov 2022 03:21:42 -0800 (PST) Received: by mail-wr1-x44a.google.com with SMTP id u24-20020adfa198000000b00241da98e057so616739wru.22 for ; Mon, 21 Nov 2022 03:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=V66iN5ZNYfCs2IKwl/XWPfYUEeh8Am+8/6YCzEI2D8c=; b=DrqkFhwq+x32T++mKGiLwBwBQlLcPegquOjKmY4DA36Bdlu1UHyvmrWX1hBJRhVkQ6 CuCW3GY8rqEftTjZZrLMe7/mkVQz7UfhK+xIE67b7ScIXkJpIv8j5OGL6cLYo9+mckRB K7uXn7jnhwdTz8CKtd1PZLB/aUu4HHTidPyJYgxXX5idXFCZCOZVGyv8hmv6enXEqnwn sySci2PTifGmbTVUqgKzOGBN+JGcWBPg2j+F9wLZjNT18VaSguq8lzh50Et/vzVO1B6Q 2Y+EGhsTlaR3AYtHfVR7KGPKNpJOX8E3kDw+u1VmZZUxfQ8uANGRO5Nfw1xQZ/dSm2xH GfuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=V66iN5ZNYfCs2IKwl/XWPfYUEeh8Am+8/6YCzEI2D8c=; b=Qdiv6Ox7gfXn6bAjKPIQqbHiv9Sxt9wW/pJ6rd2M4LR7OJCNY9Hplaq7Fw0YEVw+EO 2ItmXLQD5y6tzkLhmH2r6p/2HENllYXaUxcr+Qd3w+enarf0R/tmuhMjxcLI33jePu5Z 0w1BzUInc7R9GidZ7eiczKpC1RAclQkHj97JYPdUBXDTjoAXmxiloYRSCqtFtGRHanx8 hygufpX2646JL0GEElMHcvZQdrB64BKsBJog9E2wWPu+k39vCtciQ77dhT0EB0Dol+Pn hzrLEQLtjMGBszOdW7j95tmrbIxsUMnh0V3x7c4f0E6KGwE+26mBgLbgWYrdN7KrLHOI BEAA== X-Gm-Message-State: ANoB5pmwAa7rGnBtROD6CgtF5lS/CdgON4Xb+mTF4gcGsilH3mog/Cs/ Qljwv3bvh/PdoY7fLVwoYjmSxkA9flQ= X-Received: from glider.muc.corp.google.com ([2a00:79e0:9c:201:db68:962:2bf6:6c7]) (user=glider job=sendgmr) by 2002:adf:e50f:0:b0:22c:cc75:5aab with SMTP id j15-20020adfe50f000000b0022ccc755aabmr10402338wrm.143.1669029701044; Mon, 21 Nov 2022 03:21:41 -0800 (PST) Date: Mon, 21 Nov 2022 12:21:31 +0100 In-Reply-To: <20221121112134.407362-1-glider@google.com> Mime-Version: 1.0 References: <20221121112134.407362-1-glider@google.com> X-Mailer: git-send-email 2.38.1.584.g0f3c55d4c2-goog Message-ID: <20221121112134.407362-2-glider@google.com> Subject: [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate() From: Alexander Potapenko To: glider@google.com Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1750104986087320637?= X-GMAIL-MSGID: =?utf-8?q?1750104986087320637?= When aops->write_begin() does not initialize fsdata, KMSAN may report an error passing the latter to aops->write_end(). Fix this by unconditionally initializing fsdata. Suggested-by: Eric Biggers Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Alexander Potapenko Acked-by: David Sterba --- fs/affs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/affs/file.c b/fs/affs/file.c index cefa222f7881c..8daeed31e1af9 100644 --- a/fs/affs/file.c +++ b/fs/affs/file.c @@ -880,7 +880,7 @@ affs_truncate(struct inode *inode) if (inode->i_size > AFFS_I(inode)->mmu_private) { struct address_space *mapping = inode->i_mapping; struct page *page; - void *fsdata; + void *fsdata = NULL; loff_t isize = inode->i_size; int res;