From patchwork Sat Nov 19 02:22:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dongliang Mu X-Patchwork-Id: 23186 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp526587wrr; Fri, 18 Nov 2022 18:46:06 -0800 (PST) X-Google-Smtp-Source: AA0mqf4AMiX878qNmzW07Wq+J9H5F7+NLw9fbNG+9lGPs1ogBkBqfWJQTYKj1E9trLNFnEkdBgQ7 X-Received: by 2002:a17:90a:6906:b0:20d:5587:805b with SMTP id r6-20020a17090a690600b0020d5587805bmr10653778pjj.190.1668825965998; Fri, 18 Nov 2022 18:46:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668825965; cv=none; d=google.com; s=arc-20160816; b=znc5F9BQ3DNJledkyNiN1Gtfcnj/Qpf0DD7US5dUlPEIe5v6Jqt1hqayd6e3AQa3Yx 6SaaRlVMwmzBLQ5/g5AuOoEp0Txu6meJgBEd/hHgJLjsdiwUOSssQO6UVhOFQjh5h8ky CJlx3FqGJ/FTQO5d5KRwIrJSJ3Ag5db05BlzJMVXBeWF4/zB6p5OHhlyhjvBy0Q8ZbYR J6Gxi0awZuGeI7DwwipIHWGDBsTFw2JXFsKSYJimEY+TR1woAc44NyrYrcUHC0a3EcyB Fa4VWbQe6z4DTvSaxmhfbEBd4qWAIDUv8ySFGeK1oLDULzzYIuAg5HIXjDKOc+lceHEu c8Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=ieezrmicpkJP70CyKHaxUGiqYrn4RaKBrrL30424q0I=; b=gFz+/s99mVWCogRBhrJTGHDdB4x3drSzxpXdgvI6eqfKrwNmmZ4KthYT64cOceWJzu ynlA2swCfyw/vfqjIZT06Te2l3o+Yj6ac9ajtRtQLZ6eSqfM1naAmxeWsN9hc2u8yBAs S4JpPWJn9/F3WtmuJ8XjzVoTbZrv1n74Jtk+7aZHUBkVJpKFrVvT/miwnihUnBhlZdbK 9nXQGRuUbFOEhUdWkuEzKvXp5UfeBpLTZhSxU4Di1Nehmez8M69fGpJEgKFEOVNa7GVl sMjlh7dZGd5JRF6xKwjhISyUrieC8U2fBWDky95meVVGXLbhudNf1q2wYt0o2gSptERp Rtaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u63-20020a638542000000b004774bf80b05si443178pgd.506.2022.11.18.18.45.51; Fri, 18 Nov 2022 18:46:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232003AbiKSCgY (ORCPT + 99 others); Fri, 18 Nov 2022 21:36:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235241AbiKSCgC (ORCPT ); Fri, 18 Nov 2022 21:36:02 -0500 Received: from hust.edu.cn (mail.hust.edu.cn [202.114.0.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 397C77C027; Fri, 18 Nov 2022 18:22:43 -0800 (PST) Received: from pride-PowerEdge-R740.. ([172.16.0.254]) (user=dzm91@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 2AJ2MJj5008882-2AJ2MJj8008882 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sat, 19 Nov 2022 10:22:24 +0800 From: Dongliang Mu To: Pavel Machek Cc: Dongliang Mu , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] leds: leds-lp5521/3: fix uninitialized variable ret Date: Sat, 19 Nov 2022 10:22:16 +0800 Message-Id: <20221119022217.2474222-1-dzm91@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-FEAS-AUTH-USER: dzm91@hust.edu.cn X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749890856202219987?= X-GMAIL-MSGID: =?utf-8?q?1749890856202219987?= Smatch reports the following uninitialized symbols: drivers/leds/leds-lp5521.c:368 lp5521_multicolor_brightness() error: uninitialized symbol 'ret'. drivers/leds/leds-lp5523.c:811 lp5523_multicolor_brightness() error: uninitialized symbol 'ret'. Fix these issues by initializing ret with zero value. Signed-off-by: Dongliang Mu --- drivers/leds/leds-lp5521.c | 2 +- drivers/leds/leds-lp5523.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c index 7ff20c260504..cef46a8b4cab 100644 --- a/drivers/leds/leds-lp5521.c +++ b/drivers/leds/leds-lp5521.c @@ -352,7 +352,7 @@ static int lp5521_run_selftest(struct lp55xx_chip *chip, char *buf) static int lp5521_multicolor_brightness(struct lp55xx_led *led) { struct lp55xx_chip *chip = led->chip; - int ret; + int ret = 0; int i; mutex_lock(&chip->lock); diff --git a/drivers/leds/leds-lp5523.c b/drivers/leds/leds-lp5523.c index 369d40b0b65b..e0387639946e 100644 --- a/drivers/leds/leds-lp5523.c +++ b/drivers/leds/leds-lp5523.c @@ -795,7 +795,7 @@ static ssize_t store_master_fader_leds(struct device *dev, static int lp5523_multicolor_brightness(struct lp55xx_led *led) { struct lp55xx_chip *chip = led->chip; - int ret; + int ret = 0; int i; mutex_lock(&chip->lock);