drm/amdgpu/dm/mst: Fix uninitialized var in pre_compute_mst_dsc_configs_for_state()
| Message ID | 20221118195406.95779-1-lyude@redhat.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp381389wrr;
Fri, 18 Nov 2022 11:58:06 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf5SQzbxte/tVSiCKF11y2+L9YiUMfiOomTxjY7mCEz6QmKO3P4McjCVJZ41bwmfRO+O6Xqs
X-Received: by 2002:aa7:cb58:0:b0:469:3902:9b78 with SMTP id
w24-20020aa7cb58000000b0046939029b78mr999884edt.403.1668801486528;
Fri, 18 Nov 2022 11:58:06 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668801486; cv=none;
d=google.com; s=arc-20160816;
b=PKA4ykGWx7uilGKb7jpMdYPM8DeHhvBSnpaPdaLpYZTgtr2SNSzb+1EmEjGuWX6Tlm
X2rh74pEApfRAQ+HknBuvRcyD2zPZ8X6gGe8veAG/DetgnDlNzxM7i2C/5S45k3170+8
mxqNt785T4vnKuRLdJ7AnR/QyTBdL4CIEEAFiUXVX8I3oWiYnCrJCSkpyAY2yu8TjOTr
e0kJKscjR0R1Qa8NRojA+LOO81D6Pd0EFF0natkCy34LTTJjZAs1dy2F1CzpScgT/CBr
jEXoFqmBkSdXzvV+be7rU9xZz4C4hbAFIC3KmsQFBi926jSYBXasev0cbqqtOBGJRnD6
n5QA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=jlrfWHALNZayyuQsapcPvj1aBXBZON95PX2RLpyw9YU=;
b=q+o5Dmabr6TCavsFNJuN7zJ0K31I2kFBdCUqfKY4yTRqKeExeK86TK2V2336FoQd61
SAHkFmAV31CO6AfnzGAyier2Gxskt0nFH0LtT7UgDpsMneMAWL7YNH1SeeBXJye9JBhA
z87YwkP6ZM7cbCOw3vqpxiXsQTtJqDVlD5pfSnVZg5dELAEQou+jKmFdh4y8MMH8Arg2
5nFySuayKDwEbtsnjYDF75vkfGP5YFQsscZv0iMYTNgNs1b4ieDvMkw7AD37mEMkZMBO
GIrOWkx9lrTv23kzxy+h+6//E4NiuCgEf5yvlaCnU/ArIKfyhsU0Dw7q/L4GHUDkpIih
s5vw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=B2lriWi4;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
xi7-20020a170906dac700b0077f92be81adsi4276385ejb.212.2022.11.18.11.57.42;
Fri, 18 Nov 2022 11:58:06 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@redhat.com header.s=mimecast20190719
header.b=B2lriWi4;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230029AbiKRT4J (ORCPT <rfc822;kkmonlee@gmail.com> + 99 others);
Fri, 18 Nov 2022 14:56:09 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36258 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234504AbiKRTzq (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 18 Nov 2022 14:55:46 -0500
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 904DBBE868
for <linux-kernel@vger.kernel.org>;
Fri, 18 Nov 2022 11:54:19 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1668801258;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=jlrfWHALNZayyuQsapcPvj1aBXBZON95PX2RLpyw9YU=;
b=B2lriWi4Gi6AMQ37RcASjt4PFK4KUCMunzuQLU727EQIaDyo9HQxo4cb5rqt6ITj3GkKlp
flfZPBAOZE+1onc6bq5RSPZhokdFm1At3hXlLcdoR0P7fSt7UKHpPych+/TqRgbKRc0SZg
eU+0qIwhf0W8/k366e8lypzXR/ZMiJQ=
Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com
[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
us-mta-636-rYP0D2LwNMeNe-IR7iCSKA-1; Fri, 18 Nov 2022 14:54:14 -0500
X-MC-Unique: rYP0D2LwNMeNe-IR7iCSKA-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com
[10.11.54.3])
(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4137101A528;
Fri, 18 Nov 2022 19:54:13 +0000 (UTC)
Received: from emerald.redhat.com (unknown [10.22.18.187])
by smtp.corp.redhat.com (Postfix) with ESMTP id 3F9691121325;
Fri, 18 Nov 2022 19:54:13 +0000 (UTC)
From: Lyude Paul <lyude@redhat.com>
To: amd-gfx@lists.freedesktop.org
Cc: Harry Wentland <harry.wentland@amd.com>, Leo Li <sunpeng.li@amd.com>,
Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>,
Alex Deucher <alexander.deucher@amd.com>,
=?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, "Pan,
Xinhui" <Xinhui.Pan@amd.com>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>, hersen wu <hersenxs.wu@amd.com>,
Fangzhi Zuo <Jerry.Zuo@amd.com>, Wayne Lin <Wayne.Lin@amd.com>,
Thomas Zimmermann <tzimmermann@suse.de>, Roman Li <Roman.Li@amd.com>,
Hamza Mahfooz <hamza.mahfooz@amd.com>,
dri-devel@lists.freedesktop.org (open list:DRM DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] drm/amdgpu/dm/mst: Fix uninitialized var in
pre_compute_mst_dsc_configs_for_state()
Date: Fri, 18 Nov 2022 14:54:05 -0500
Message-Id: <20221118195406.95779-1-lyude@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749865187536429762?=
X-GMAIL-MSGID: =?utf-8?q?1749865187536429762?=
|
| Series |
drm/amdgpu/dm/mst: Fix uninitialized var in pre_compute_mst_dsc_configs_for_state()
|
|
Commit Message
Lyude Paul
Nov. 18, 2022, 7:54 p.m. UTC
Coverity noticed this one, so let's fix it.
Signed-off-by: Lyude Paul <lyude@redhat.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 11/18/22 14:54, Lyude Paul wrote: > Coverity noticed this one, so let's fix it. > > Signed-off-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Harry Wentland <harry.wentland@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > index 59648f5ffb59..6483ba266893 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > @@ -1180,7 +1180,7 @@ static int pre_compute_mst_dsc_configs_for_state(struct drm_atomic_state *state, > struct amdgpu_dm_connector *aconnector; > struct drm_dp_mst_topology_mgr *mst_mgr; > int link_vars_start_index = 0; > - int ret; > + int ret = 0; > > for (i = 0; i < dc_state->stream_count; i++) > computed_streams[i] = false;
Applied. Thanks! Alex On Fri, Nov 18, 2022 at 3:03 PM Harry Wentland <harry.wentland@amd.com> wrote: > > On 11/18/22 14:54, Lyude Paul wrote: > > Coverity noticed this one, so let's fix it. > > > > Signed-off-by: Lyude Paul <lyude@redhat.com> > > Reviewed-by: Harry Wentland <harry.wentland@amd.com> > > Harry > > > --- > > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > > index 59648f5ffb59..6483ba266893 100644 > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c > > @@ -1180,7 +1180,7 @@ static int pre_compute_mst_dsc_configs_for_state(struct drm_atomic_state *state, > > struct amdgpu_dm_connector *aconnector; > > struct drm_dp_mst_topology_mgr *mst_mgr; > > int link_vars_start_index = 0; > > - int ret; > > + int ret = 0; > > > > for (i = 0; i < dc_state->stream_count; i++) > > computed_streams[i] = false; >
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c index 59648f5ffb59..6483ba266893 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c @@ -1180,7 +1180,7 @@ static int pre_compute_mst_dsc_configs_for_state(struct drm_atomic_state *state, struct amdgpu_dm_connector *aconnector; struct drm_dp_mst_topology_mgr *mst_mgr; int link_vars_start_index = 0; - int ret; + int ret = 0; for (i = 0; i < dc_state->stream_count; i++) computed_streams[i] = false;