diff mbox series

[for-6.2/hid-bpf] HID: force HID depending on INPUT

Message ID 20221118105448.1888750-1-benjamin.tissoires@redhat.com
State New
Headers
Series [for-6.2/hid-bpf] HID: force HID depending on INPUT |

Commit Message

Benjamin Tissoires Nov. 18, 2022, 10:54 a.m. UTC 
  In most configurations, INPUT is actually a boolean: either y or disabled,
but when it's disabled, you can't do much on your average laptop.

But it turns out that there is a possibility to have INPUT as a module:
you have to disable VT and TTY (of course), but also enable EXPERT.
I'll leave how to disable VT and TTY as an exercise for the bravest.

Anyway, if INPUT is m, we can still configure HID as y, which is not
correct because hid-input.c depends on the input API, meaning that
vmlinuz can not link.

So: add depends on INPUT too at the HID level, to ensure that if INPUT=m,
HID can only be m or disabled.

Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/202211181742.QYJY6Gug-lkp@intel.com
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
 drivers/hid/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Jiri Kosina Nov. 21, 2022, 5:37 p.m. UTC | #1 
On Fri, 18 Nov 2022, Benjamin Tissoires wrote:

> In most configurations, INPUT is actually a boolean: either y or disabled,
> but when it's disabled, you can't do much on your average laptop.
> 
> But it turns out that there is a possibility to have INPUT as a module:
> you have to disable VT and TTY (of course), but also enable EXPERT.
> I'll leave how to disable VT and TTY as an exercise for the bravest.
> 
> Anyway, if INPUT is m, we can still configure HID as y, which is not
> correct because hid-input.c depends on the input API, meaning that
> vmlinuz can not link.
> 
> So: add depends on INPUT too at the HID level, to ensure that if INPUT=m,
> HID can only be m or disabled.
> 
> Fixes: 25621bcc8976 ("HID: Kconfig: split HID support and hid-core compilation")
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/r/202211181742.QYJY6Gug-lkp@intel.com
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Applied as well to for-6.2/hid-bpf. Thanks,
diff mbox series

Patch

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index ff40c18f4a2b..b345bbfb57bf 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -15,6 +15,7 @@  if HID_SUPPORT
 config HID
 	tristate "HID bus core support"
 	default y
+	depends on INPUT
 	help
 	  A human interface device (HID) is a type of computer device that
 	  interacts directly with and takes input from humans. The term "HID"