| Message ID | 20221118011714.70877-2-hal.feng@starfivetech.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp723295wrr;
Thu, 17 Nov 2022 17:36:59 -0800 (PST)
X-Google-Smtp-Source:
AA0mqf4JtJp8HRchwqqK8rnSX8eXfRj3/5MFvR5HtNNvShkRqx4Byr77RM9flBDz4IB/OxVppRro
X-Received: by 2002:a17:906:5fd5:b0:7ac:2e16:a8d3 with SMTP id
k21-20020a1709065fd500b007ac2e16a8d3mr4372575ejv.667.1668735419014;
Thu, 17 Nov 2022 17:36:59 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668735419; cv=none;
d=google.com; s=arc-20160816;
b=IDUGu5Ww2YeEf6/rAL/+9Ae1ACNeMs2O5SLsUo/eIYvOTo/WI1gXFs/hzwXkdysYXM
YGpLa9bl9j7T38s8z5oLbvE/h/Stdd//4fUursAKXj5atJBSHg5+WYftYPvKz3WWiKt7
PeJeNAT2tr0/F0d6mTbrYZhwBNBXZdvwPrd4i2wJhbHIl0OMNTwcJRLxZcUgkH1MUwQ7
MUpbCOEfyhkH3eH2r3oPBykaJnw9KPoky3HhXxAvR3Gw8UQzoUT9nC5hjvCmUUcZ7GkA
MX7vzzBAB7MIXbI/qn4IDvxwesoqzmt+Jry/yQ0oo0VLwJJfsM1V6A29Sngufn7msAGL
XZ1g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=treFSL1tV9tEVKVIrmEmoFdklRz1/3m+kkjrQHMXc9k=;
b=hYBJr90uOcdGba1O1Y1goSHFVItBKKIcA0AgibiI8UeceoLikXOfwvgkubTr6w1Xmo
lhpE3wRWO7RXfMv0i+AMYqJYsEVgsc2Nkbrs1/oFk7t8rQUYslrLRy5sgFxlS4ANcMj9
qyEEtGQAb25qcVts7yLu83vhqsORUZ5w/92I9FGhmsJHsyMqVOKYYw5nHfPEec0Os2hA
bcZpgryyG56U0II9YPK+WJG+ZzvAHzbsNNQ7zyur7GfvIvP9ugvi84cAcmT3rB7sfZq5
NqHRWi2eArPB8iDsoiOO+NUVRKbiZwlfNpddSTNILxwk2h5E2zisU1cPesembl1iDOxZ
yhDA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ef8-20020a05640228c800b0045c9dbe290csi1980578edb.406.2022.11.17.17.36.35;
Thu, 17 Nov 2022 17:36:59 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S240662AbiKRBep convert rfc822-to-8bit (ORCPT
<rfc822;a1648639935@gmail.com> + 99 others);
Thu, 17 Nov 2022 20:34:45 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47016 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S240887AbiKRBeX (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 17 Nov 2022 20:34:23 -0500
Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B898E63BA;
Thu, 17 Nov 2022 17:34:22 -0800 (PST)
Received: from EXMBX165.cuchost.com (unknown [175.102.18.54])
(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
(Client CN "EXMBX165", Issuer "EXMBX165" (not verified))
by ex01.ufhost.com (Postfix) with ESMTP id 9E25524E206;
Fri, 18 Nov 2022 09:17:18 +0800 (CST)
Received: from EXMBX072.cuchost.com (172.16.6.82) by EXMBX165.cuchost.com
(172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 18 Nov
2022 09:17:18 +0800
Received: from ubuntu.localdomain (183.27.96.116) by EXMBX072.cuchost.com
(172.16.6.82) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 18 Nov
2022 09:17:17 +0800
From: Hal Feng <hal.feng@starfivetech.com>
To: <linux-riscv@lists.infradead.org>, <devicetree@vger.kernel.org>
CC: Conor Dooley <conor@kernel.org>,
Palmer Dabbelt <palmer@dabbelt.com>,
"Rob Herring" <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Ben Dooks <ben.dooks@sifive.com>,
Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>, Stephen Boyd <sboyd@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
"Linus Walleij" <linus.walleij@linaro.org>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Hal Feng <hal.feng@starfivetech.com>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v2 1/8] dt-bindings: riscv: Add StarFive JH7110 SoC and
VisionFive2 board
Date: Fri, 18 Nov 2022 09:17:07 +0800
Message-ID: <20221118011714.70877-2-hal.feng@starfivetech.com>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221118011714.70877-1-hal.feng@starfivetech.com>
References: <20221118011714.70877-1-hal.feng@starfivetech.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Originating-IP: [183.27.96.116]
X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX072.cuchost.com
(172.16.6.82)
X-YovoleRuleAgent: yovoleflag
Content-Transfer-Encoding: 8BIT
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749795910606841022?=
X-GMAIL-MSGID: =?utf-8?q?1749795910606841022?=
|
| Series |
Basic device tree support for StarFive JH7110 RISC-V SoC
|
|
Commit Message
Hal Feng
Nov. 18, 2022, 1:17 a.m. UTC
From: Emil Renner Berthing <kernel@esmil.dk> Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] and the VisionFive2 board [2] equipped with it. [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> Signed-off-by: Hal Feng <hal.feng@starfivetech.com> --- Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On Fri, Nov 18, 2022 at 09:17:07AM +0800, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > and the VisionFive2 board [2] equipped with it. > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html Could you make these two into "Link:" tags please? Otherwise, Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > --- > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > index 5b36243fd674..64008c57e31f 100644 > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > @@ -22,6 +22,10 @@ properties: > - const: beagle,beaglev-starlight-jh7100-r0 > - const: starfive,jh7100 > > + - items: > + - const: starfive,visionfive-v2 > + - const: starfive,jh7110 > + > additionalProperties: true > > ... > -- > 2.38.1 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv
On 18/11/2022 02:17, Hal Feng wrote: > From: Emil Renner Berthing <kernel@esmil.dk> > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > and the VisionFive2 board [2] equipped with it. > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html As Conor said, I think Links are preferred. With that: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, 18 Nov 2022 at 02:17, Hal Feng <hal.feng@starfivetech.com> wrote: > > From: Emil Renner Berthing <kernel@esmil.dk> > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > and the VisionFive2 board [2] equipped with it. > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > --- > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > index 5b36243fd674..64008c57e31f 100644 > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > @@ -22,6 +22,10 @@ properties: > - const: beagle,beaglev-starlight-jh7100-r0 > - const: starfive,jh7100 > > + - items: > + - const: starfive,visionfive-v2 I think StarFive has switched to just calling it VisionFive 2 and not V2. Please check up on this before committing to the compatible string. Also there are going to be different revisions of the VisionFive 2 board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and starfive,visionfive-2-v1,2b early. > + - const: starfive,jh7110 > + > additionalProperties: true > > ... > -- > 2.38.1 >
On Fri, 18 Nov 2022 19:31:36 +0800, Conor Dooley wrote: > On Fri, Nov 18, 2022 at 09:17:07AM +0800, Hal Feng wrote: > > From: Emil Renner Berthing <kernel@esmil.dk> > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > and the VisionFive2 board [2] equipped with it. > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > Could you make these two into "Link:" tags please? > Otherwise, > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> OK, will fix it in the next version. Thanks. Best regards, Hal
On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote: > On Fri, 18 Nov 2022 at 02:17, Hal Feng <hal.feng@starfivetech.com> wrote: > > > > From: Emil Renner Berthing <kernel@esmil.dk> > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > and the VisionFive2 board [2] equipped with it. > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > --- > > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > index 5b36243fd674..64008c57e31f 100644 > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > @@ -22,6 +22,10 @@ properties: > > - const: beagle,beaglev-starlight-jh7100-r0 > > - const: starfive,jh7100 > > > > + - items: > > + - const: starfive,visionfive-v2 > > I think StarFive has switched to just calling it VisionFive 2 and not > V2. Please check up on this before committing to the compatible > string. > > Also there are going to be different revisions of the VisionFive 2 > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and > starfive,visionfive-2-v1,2b early. I checked that the official name of this board is "VisionFive 2". The board has version A and version B, which are different in gmac and phy chip. The version A board has one 1000M and one 100M Ethernet ports while the version B board has two 1000M Ethernet ports. In dts, they have different configuration parameters for gmac. So I would like to distinguish them by two compatibles as below in the next version. - items: - enum: - starfive,visionfive-2-va - starfive,visionfive-2-vb - const: starfive,jh7110 Best regards, Hal > > > + - const: starfive,jh7110 > > + > > additionalProperties: true
On Thu, 24 Nov 2022 at 06:56, Hal Feng <hal.feng@starfivetech.com> wrote: > > On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote: > > On Fri, 18 Nov 2022 at 02:17, Hal Feng <hal.feng@starfivetech.com> wrote: > > > > > > From: Emil Renner Berthing <kernel@esmil.dk> > > > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > > and the VisionFive2 board [2] equipped with it. > > > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > > > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > > --- > > > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > > > 1 file changed, 4 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > index 5b36243fd674..64008c57e31f 100644 > > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > @@ -22,6 +22,10 @@ properties: > > > - const: beagle,beaglev-starlight-jh7100-r0 > > > - const: starfive,jh7100 > > > > > > + - items: > > > + - const: starfive,visionfive-v2 > > > > I think StarFive has switched to just calling it VisionFive 2 and not > > V2. Please check up on this before committing to the compatible > > string. > > > > Also there are going to be different revisions of the VisionFive 2 > > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and > > starfive,visionfive-2-v1,2b early. > > I checked that the official name of this board is "VisionFive 2". The > board has version A and version B, which are different in gmac and phy > chip. The version A board has one 1000M and one 100M Ethernet ports > while the version B board has two 1000M Ethernet ports. In dts, they > have different configuration parameters for gmac. So I would like to > distinguish them by two compatibles as below in the next version. > > - items: > - enum: > - starfive,visionfive-2-va > - starfive,visionfive-2-vb > - const: starfive,jh7110 Cool. Though the silkscreen on my board says "VisionFive 2 V1.2B" so I think it would be less confusing if you used that as the model, and "starfive,visionfive-2-v1.2b" as the compatible string for the board. > Best regards, > Hal > > > > > > + - const: starfive,jh7110 > > > + > > > additionalProperties: true >
On Thu, 24 Nov 2022 10:20:32 +0100, Emil Renner Berthing wrote: > On Thu, 24 Nov 2022 at 06:56, Hal Feng <hal.feng@starfivetech.com> wrote: > > > > On Sat, 19 Nov 2022 01:28:48 +0800, Emil Renner Berthing wrote: > > > On Fri, 18 Nov 2022 at 02:17, Hal Feng <hal.feng@starfivetech.com> wrote: > > > > > > > > From: Emil Renner Berthing <kernel@esmil.dk> > > > > > > > > Add device tree bindings for the StarFive JH7110 RISC-V SoC [1] > > > > and the VisionFive2 board [2] equipped with it. > > > > > > > > [1]: https://doc-en.rvspace.org/Doc_Center/jh7110.html > > > > [2]: https://doc-en.rvspace.org/Doc_Center/visionfive_2.html > > > > > > > > Signed-off-by: Emil Renner Berthing <kernel@esmil.dk> > > > > Signed-off-by: Hal Feng <hal.feng@starfivetech.com> > > > > --- > > > > Documentation/devicetree/bindings/riscv/starfive.yaml | 4 ++++ > > > > 1 file changed, 4 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > > index 5b36243fd674..64008c57e31f 100644 > > > > --- a/Documentation/devicetree/bindings/riscv/starfive.yaml > > > > +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml > > > > @@ -22,6 +22,10 @@ properties: > > > > - const: beagle,beaglev-starlight-jh7100-r0 > > > > - const: starfive,jh7100 > > > > > > > > + - items: > > > > + - const: starfive,visionfive-v2 > > > > > > I think StarFive has switched to just calling it VisionFive 2 and not > > > V2. Please check up on this before committing to the compatible > > > string. > > > > > > Also there are going to be different revisions of the VisionFive 2 > > > board, so maybe consider adding eg. starfive,visionfive-2-v1.1 and > > > starfive,visionfive-2-v1,2b early. > > > > I checked that the official name of this board is "VisionFive 2". The > > board has version A and version B, which are different in gmac and phy > > chip. The version A board has one 1000M and one 100M Ethernet ports > > while the version B board has two 1000M Ethernet ports. In dts, they > > have different configuration parameters for gmac. So I would like to > > distinguish them by two compatibles as below in the next version. > > > > - items: > > - enum: > > - starfive,visionfive-2-va > > - starfive,visionfive-2-vb > > - const: starfive,jh7110 > > Cool. Though the silkscreen on my board says "VisionFive 2 V1.2B" so I > think it would be less confusing if you used that as the model, and > "starfive,visionfive-2-v1.2b" as the compatible string for the board. As far as I know, VisionFive 2 V1.3B is coming and all version B boards use the same configuration. It's unnecessary to add the detailed number of PCB version. > > > > Best regards, > > Hal > > > > > > > > > + - const: starfive,jh7110 > > > > + > > > > additionalProperties: true > >
diff --git a/Documentation/devicetree/bindings/riscv/starfive.yaml b/Documentation/devicetree/bindings/riscv/starfive.yaml index 5b36243fd674..64008c57e31f 100644 --- a/Documentation/devicetree/bindings/riscv/starfive.yaml +++ b/Documentation/devicetree/bindings/riscv/starfive.yaml @@ -22,6 +22,10 @@ properties: - const: beagle,beaglev-starlight-jh7100-r0 - const: starfive,jh7100 + - items: + - const: starfive,visionfive-v2 + - const: starfive,jh7110 + additionalProperties: true ...