From patchwork Thu Nov 17 16:19:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 21775 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp491815wrr; Thu, 17 Nov 2022 08:22:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf63HNAXHFlxwWlMphiZZqVPPBcJkPWOxmQ5R34b1mLnGb/MD6FcZLzcdHpbh5QZOPBnbLye X-Received: by 2002:a17:906:55c5:b0:78d:3862:4488 with SMTP id z5-20020a17090655c500b0078d38624488mr2599675ejp.683.1668702128998; Thu, 17 Nov 2022 08:22:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668702128; cv=none; d=google.com; s=arc-20160816; b=bH/IWP0AhO/fftL85Z+qpBt8S14saO/XH88XaRkRhudbkb33rWNVEWJ6PT64KnMJue opFk7/vRlm76uWARtOINc9TKUwkXbFThBXLhVpA0MnuDFRtYlJcrt2JfQ8gyCmuBOl// 60HKaTV7HuZeAvrII2XJ11uo5P6CnJFCrjmFDb8ITexrx8pMpCv+82WqfQ7qwl38JJXY bNdkj5J5TvUtJ5oA+3ZB2oHkHoD8d/PoGl0uzbWev6/TA40ntMDxWlJ/fK2NAsOiefnB eAkLrs4j6lmi806v2Z7SdydxS6k4ru+6OUMN2kFdYYe4YqElAJ+d4vQc26Jw1zJWsKSz jreA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=GoTFpTGYiISArqD5s/zx9WDe+Qbt9dH5E89DGQZjxj0=; b=T/bh8nx7FF8au1SvCveCBev1qM7076fHOhlvtRgtrwR/Iq1FSW7F89mJSbUgMsO3By OmERpVSTGIfvn9bHrPnR/YHXowkd6HFzqmLDpl+fXeHtCCq9hQc2+W6qmqyw2zzBFXZ1 sJ31cBBwN72vpMsJFz0qt3+8kqDNbaY3fE/AJ7FlFzbl8plCwq3kRYCeji8fTlNHr5Qf s+lsfODglmcTBeDDGo2pM2+K/TUWgpgqLKp9R2dfFeHHGxzr3yBPsCw9mkjEcVFI1d/i JBEYeW2yZwD1nbAfMzKE1XXKNKlUbjpmGftylVKe0O0EusMr3JoDz0FanYibhvKfgyIw KEtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HIq57JAo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hg4-20020a1709072cc400b0078dc3cb8b48si966745ejc.625.2022.11.17.08.21.44; Thu, 17 Nov 2022 08:22:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=HIq57JAo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240131AbiKQQUu (ORCPT + 99 others); Thu, 17 Nov 2022 11:20:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240127AbiKQQUf (ORCPT ); Thu, 17 Nov 2022 11:20:35 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F25F7A37F for ; Thu, 17 Nov 2022 08:20:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C40A462129 for ; Thu, 17 Nov 2022 16:20:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68B97C43470; Thu, 17 Nov 2022 16:20:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668702013; bh=awJcsInCrnpYPooCsXmTvq88qOaCFASkgl3nzDbnHPk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HIq57JAoDRaj58PMEcNmC8uPLkoF+sZmJAf0+i9riIje4fcxajltdx7uWHUyEsygf wrf4q05yDtUqPPzbQYnjIKaGJDcvaaVfzLscujFi1FSbvznJojFtYmbktiw5DviV9o aVPxr0ppFZNRzwQ7TY1LpA0KMSs1QwNZpC6mtST7tiaqQJaqTyjeKVJV5d0DKnOLJq IWgdDHMxXJH3yLz2zKkcUaaOGbA+lQiigssGJhLpm/v26i/GHd4dAxj9Y+5pd4L34l GDsDnDUSno9lxyNwJtZWnjOkwbjJrwyWkomS//k0uTzTym4WJ5C54ibV8f3YUgwVqP F5/DGiZoJKteA== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: farah kassabri Subject: [PATCH 13/20] habanalabs/gaudi2: remove redundant firmware version check Date: Thu, 17 Nov 2022 18:19:44 +0200 Message-Id: <20221117161951.845454-13-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221117161951.845454-1-ogabbay@kernel.org> References: <20221117161951.845454-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749761003500893136?= X-GMAIL-MSGID: =?utf-8?q?1749761003500893136?= From: farah kassabri Firmware 1.7 is the first official firmware, so no need to check if we are running a version below it. Signed-off-by: farah kassabri Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi2/gaudi2.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/gaudi2/gaudi2.c b/drivers/misc/habanalabs/gaudi2/gaudi2.c index bdb5782afb7e..36f0ea1100bb 100644 --- a/drivers/misc/habanalabs/gaudi2/gaudi2.c +++ b/drivers/misc/habanalabs/gaudi2/gaudi2.c @@ -10358,10 +10358,9 @@ int gaudi2_send_device_activity(struct hl_device *hdev, bool open) { struct gaudi2_device *gaudi2 = hdev->asic_specific; - if (!(gaudi2->hw_cap_initialized & HW_CAP_CPU_Q) || hdev->fw_major_version < 37) + if (!(gaudi2->hw_cap_initialized & HW_CAP_CPU_Q)) return 0; - /* TODO: add check for FW version using minor ver once it's known */ return hl_fw_send_device_activity(hdev, open); }