From patchwork Thu Nov 17 15:51:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 21750 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp475368wrr; Thu, 17 Nov 2022 07:54:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf4hX0SLRb1e4nYKc3AAcKOzUPEvVupxYOoGcCTJNFWmps8twPMOB0jvLcNUtN9L1kVLuRmK X-Received: by 2002:a17:906:5409:b0:7b2:7b45:848f with SMTP id q9-20020a170906540900b007b27b45848fmr2694234ejo.129.1668700450310; Thu, 17 Nov 2022 07:54:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668700450; cv=none; d=google.com; s=arc-20160816; b=aAEztvgDKDr61Dha8bZpOc4biGRZj33MtAPZ7lsBkRlGFqObVoH5dm6W2py53sMy2F eL3o/yC6Waz5utT9mT5VYyZFOIGC9BhOrizOQF0rWFDBphc5wi9vnaqMKBIFi2kg242A Ifmnp/iF7OPGuMUyWMzVl9kSuy/VsndfWDbGEMvBYg9M1POcZZWnjvB9RWHj44csTktG yoZEjaeQ2bmA/ikPMJQtccq6ighYLBpJAtfERcXLXedu4mugTY8Ct6DuTsALPyQeGaLy Ki0WndxUTG/OgKP6NcFTJvcH36Hm1SgAssdY717PVpz+YGK+ZZEv1IoqwwY1RvPSDLYH m5Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=vMjPUU0VYESSE22HZBsKx6i7iBnyqQkEkgek1A3a5Xc=; b=NnYoVZh8c9gv1+9ECHI+dV9CdUPUWo+NddKgfSfNQABLfWP5PCMJWpJbc/bYUTdkF/ MWLlf2x1J283GX/A/ZsSW2oQyY0ITZCKL8NuC2Yk2CACXtM0t+8+H7ywP2MjZ2lj0qLK CHm6+zRyPIPaQWhrJZ1HovcN4r8S/oG4xUG0XFORn1kLnZHDZtMI2OJ9xLNK4TX8XYAp n8kuqY/WP+brdm8Nv0BiQhCe3eSdUbyzX+4Ag1Wx23CB9XbZqd23bWig8zcVItJ+5LTM htQZP6W8lfFmBZ3TONJhak3ZDhPYyPrKArXfss9H+kbYnpzYm18KYIkfkIkk06N0IcvU 7yqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QvD1DJK3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p13-20020a05640210cd00b0046272b487cesi879195edu.331.2022.11.17.07.53.46; Thu, 17 Nov 2022 07:54:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=QvD1DJK3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235103AbiKQPvG (ORCPT + 99 others); Thu, 17 Nov 2022 10:51:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234851AbiKQPvB (ORCPT ); Thu, 17 Nov 2022 10:51:01 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F64E701B1; Thu, 17 Nov 2022 07:51:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668700260; x=1700236260; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=6MgUUvyelCWY06xmow9rc5WGciB3OvxEMw2tLw+abCI=; b=QvD1DJK3SUgCU5a0bnz3FiSqhtlwyE93sWDISpJ8HKzGMwzeD+s9zs8Y uDqJseOqu2wWqhEsjU11/GzXtwK6jMTV7TEMTfeYaPMXjUyqMJfMdR0QM n6w78EBI5gIhfaxdNqWuguf7XOJqWaH2LiyCf7FBsoBAtf+wCaeBotnuC SXSQlsU6AQ9+yAMrO+vjY9SzXBV4MFTbc93JLoCZEj1EBfCwxumEptULe JGfE/JLPZiGe/Jl/tWcCA0Fx+tDcFvqr8Yj8prdic3WtYiQ5a2IlSpOY0 lFZ/x79gXgrMgSEraHGwXSgenwrbAh72XWmU53Zhlj0Fhb86MHVGlk/7O w==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="312898973" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="312898973" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 07:50:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="968919505" X-IronPort-AV: E=Sophos;i="5.96,171,1665471600"; d="scan'208";a="968919505" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga005.fm.intel.com with ESMTP; 17 Nov 2022 07:50:49 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 023D6B7; Thu, 17 Nov 2022 17:51:13 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michael Turquette , Stephen Boyd Subject: [PATCH v1 2/3] clk: fractional-divider: Show numerator and denominator in debugfs Date: Thu, 17 Nov 2022 17:51:04 +0200 Message-Id: <20221117155105.1486-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221117155105.1486-1-andriy.shevchenko@linux.intel.com> References: <20221117155105.1486-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749759243366695850?= X-GMAIL-MSGID: =?utf-8?q?1749759243366695850?= It's very useful to see what are the values of the fractional divider. For that, add respective debugfs files. Signed-off-by: Andy Shevchenko --- drivers/clk/clk-fractional-divider.c | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/clk/clk-fractional-divider.c b/drivers/clk/clk-fractional-divider.c index 5c6f1d0f8fb4..b6b52b79d671 100644 --- a/drivers/clk/clk-fractional-divider.c +++ b/drivers/clk/clk-fractional-divider.c @@ -39,6 +39,7 @@ */ #include +#include #include #include #include @@ -193,10 +194,45 @@ static int clk_fd_set_rate(struct clk_hw *hw, unsigned long rate, return 0; } +#ifdef CONFIG_DEBUG_FS +static int clk_fd_numerator_get(void *hw, u64 *val) +{ + struct u32_fract fract; + + clk_fd_get_div(hw, &fract); + + *val = fract.numerator; + + return 0; +} +DEFINE_DEBUGFS_ATTRIBUTE(clk_fd_numerator_fops, clk_fd_numerator_get, NULL, "%llu\n"); + +static int clk_fd_denominator_get(void *hw, u64 *val) +{ + struct u32_fract fract; + + clk_fd_get_div(hw, &fract); + + *val = fract.denominator; + + return 0; +} +DEFINE_DEBUGFS_ATTRIBUTE(clk_fd_denominator_fops, clk_fd_denominator_get, NULL, "%llu\n"); + +static void clk_fd_debug_init(struct clk_hw *hw, struct dentry *dentry) +{ + debugfs_create_file("numerator", 0444, dentry, hw, &clk_fd_numerator_fops); + debugfs_create_file("denominator", 0444, dentry, hw, &clk_fd_denominator_fops); +} +#endif + const struct clk_ops clk_fractional_divider_ops = { .recalc_rate = clk_fd_recalc_rate, .round_rate = clk_fd_round_rate, .set_rate = clk_fd_set_rate, +#ifdef CONFIG_DEBUG_FS + .debug_init = clk_fd_debug_init, +#endif }; EXPORT_SYMBOL_GPL(clk_fractional_divider_ops);