From patchwork Thu Nov 17 14:28:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Lin, Meng-Bo" X-Patchwork-Id: 21681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp432680wrr; Thu, 17 Nov 2022 06:34:25 -0800 (PST) X-Google-Smtp-Source: AA0mqf7QmmuD8MrdaeCnpjqanFXcwFpU5bFm/o6bdLp8gTGh9D64IJ0xZ7C8RP3nQ+HKfACEyPVu X-Received: by 2002:a17:902:e995:b0:186:ceff:f818 with SMTP id f21-20020a170902e99500b00186cefff818mr3154742plb.11.1668695665080; Thu, 17 Nov 2022 06:34:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668695665; cv=none; d=google.com; s=arc-20160816; b=v2F1ZTXYbGjDmvLogDjqyZD9yVlQTDr4izm7hdgSlnUds9FmTGY1VTi3FFobsOHnQJ PTb66Rh71nueNkaGoIWdgHqKv0XdW7U/h23L4ewk8P4qcLrh5tW+LGJ2bIbDvtBJjDLq N2BSFpzy/OZ3iZk9/+garmWaS3Q+cCTtQkHRaUjhwjO8x65Cfb2KTXCxpSFGDS9/gS9a wWKkCLGA71stCEgjx3iEEeCTWIx7RD1G1izMATUT5gUJA5SJamqDNrKIMVNw60nlgCAM IyVKpIvZeNzNmerwc13lCUdV8O3RT27WnwpJExMrE4mgScxrK/1XVx8GGDgu93cfXJH0 KYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:message-id:subject:cc:from:to:dkim-signature:date; bh=h8QUQMuBeId16fwT8sIh6ZqutzDewiMZtFIp21P7mOY=; b=z0Si6ZLn14E8uhDY6A3vd867iwvQnz4QToctj82R1L0fPqxn73fVxeNxE6pQgr8xZ7 +wHsJa658DGZctp3pkMmIWOJarHrjIbEt+fB0GZkzZSVd7oQbvMVbHqjOzId2ypuMEOh f50VYd82nDOLRnBf98kKGahTeoWKEGLg3fWVsx4zjJprUQZibRwIJZH6DiuWx7IGKsRd jd2XbGJVlxjuLjpsy214MUIixn0D58WqdRyL79lYk/Q4YLp6Gqbn5zXIxFKKlDALNwCJ hufk1paKMnAFpHLhylsNRaVtrkT+j6nL4LYdGYG2Ta7BGSnDvYDcnhf1bxwsGBB9TkCB dvcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=cLYLHTMv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id t9-20020a17090a510900b001fe39932aa3si4516816pjh.48.2022.11.17.06.34.10; Thu, 17 Nov 2022 06:34:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@protonmail.com header.s=protonmail3 header.b=cLYLHTMv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=protonmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239483AbiKQO2v (ORCPT + 99 others); Thu, 17 Nov 2022 09:28:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240352AbiKQO2o (ORCPT ); Thu, 17 Nov 2022 09:28:44 -0500 Received: from mail-0201.mail-europe.com (mail-0201.mail-europe.com [51.77.79.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 293951261B for ; Thu, 17 Nov 2022 06:28:42 -0800 (PST) Date: Thu, 17 Nov 2022 14:28:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1668695315; x=1668954515; bh=h8QUQMuBeId16fwT8sIh6ZqutzDewiMZtFIp21P7mOY=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=cLYLHTMvI4pQQtyVvzPKzaE42SZoN0qoVPQeQLANiJ77ipklFCAlKAu9C2fUV9eQn B+dBlatkXMTkQhcJxLeUiX5os+iXkuE6Dny9XEf+idfQzdHupDpmBG/f6/MHmuA7Lr XEd9hN5wfk4hjQEfPv1xyMlEAh3lnNglucGJ2Xdk43Vwhsz2JpZFKojtMoU4tDd1lf YP3z2yogAUeXhmE3lTxsdYliSWbIy5uNXp1g7nrsotbj8VmDvtOGHEq5ekFX3m6LdO i1eJuzY10Jz64eFubqo79KYtQfTU/717jpWZI7ABXH9twBqmoSps8Uow3PsOpbOHes aCVnYVrwm/oQw== To: linux-input@vger.kernel.org From: "Lin, Meng-Bo" Cc: Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Corey Minyard , Srinivas Pandruvada , Benjamin Mugnier , Greg Kroah-Hartman , Zheng Yongjun , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Stephan Gerhold , Nikita Travkin , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: [PATCH] Input: stmfts - retry commands after timeout Message-ID: <20221117142753.2477-1-linmengbo0689@protonmail.com> Feedback-ID: 40467236:user:proton MIME-Version: 1.0 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749754225285221682?= X-GMAIL-MSGID: =?utf-8?q?1749754225285221682?= Add #define STMFTS_RETRY_COUNT 3 to retry stmfts_command() 3 times. Without it, STMFTS_SYSTEM_RESET or STMFTS_SLEEP_OUT may return -110 to failed attempt due to no event received for completion. Signed-off-by: Lin, Meng-Bo Reviewed-by: Mattijs Korpershoek --- drivers/input/touchscreen/stmfts.c | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c index d5bd170808fb..22de34966373 100644 --- a/drivers/input/touchscreen/stmfts.c +++ b/drivers/input/touchscreen/stmfts.c @@ -68,6 +68,7 @@ #define STMFTS_DATA_MAX_SIZE (STMFTS_EVENT_SIZE * STMFTS_STACK_DEPTH) #define STMFTS_MAX_FINGERS 10 #define STMFTS_DEV_NAME "stmfts" +#define STMFTS_RETRY_COUNT 3 enum stmfts_regulators { STMFTS_REGULATOR_VDD, @@ -317,19 +318,20 @@ static irqreturn_t stmfts_irq_handler(int irq, void *dev) static int stmfts_command(struct stmfts_data *sdata, const u8 cmd) { - int err; + int err, retry; reinit_completion(&sdata->cmd_done); - err = i2c_smbus_write_byte(sdata->client, cmd); - if (err) - return err; - - if (!wait_for_completion_timeout(&sdata->cmd_done, - msecs_to_jiffies(1000))) - return -ETIMEDOUT; + for (retry = 0; retry < STMFTS_RETRY_COUNT; retry++) { + err = i2c_smbus_write_byte(sdata->client, cmd); + if (err) + return err; - return 0; + if (wait_for_completion_timeout(&sdata->cmd_done, + msecs_to_jiffies(1000))) + return 0; + } + return -ETIMEDOUT; } static int stmfts_input_open(struct input_dev *dev)