[5/5] drm/panel-samsung-atna33xc20: Extend autosuspend delay

Message ID 20221117133655.5.I96ce2a565ff893eddcbee70174c991179311a3ae@changeid
State New
Headers
Series [1/5] drm/panel-edp: Use ktime_get_boottime for delays |

Commit Message

Drew Davenport Nov. 17, 2022, 8:38 p.m. UTC
  Avoid the panel oscillating on and off during boot. In some cases it
will be more than 1000ms between powering the panel to read the EDID early
during boot, and enabling the panel for display. Extending the
autosuspend delay avoids autosuspending during this interval.

Signed-off-by: Drew Davenport <ddavenport@chromium.org>

---

 drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Doug Anderson Nov. 17, 2022, 9:15 p.m. UTC | #1
Hi,

On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport <ddavenport@chromium.org> wrote:
>
> Avoid the panel oscillating on and off during boot. In some cases it
> will be more than 1000ms between powering the panel to read the EDID early
> during boot, and enabling the panel for display. Extending the
> autosuspend delay avoids autosuspending during this interval.
>
> Signed-off-by: Drew Davenport <ddavenport@chromium.org>
>
> ---
>
>  drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
  
Doug Anderson Nov. 29, 2022, 10:28 p.m. UTC | #2
Hi,

On Thu, Nov 17, 2022 at 1:15 PM Doug Anderson <dianders@chromium.org> wrote:
>
> Hi,
>
> On Thu, Nov 17, 2022 at 12:39 PM Drew Davenport <ddavenport@chromium.org> wrote:
> >
> > Avoid the panel oscillating on and off during boot. In some cases it
> > will be more than 1000ms between powering the panel to read the EDID early
> > during boot, and enabling the panel for display. Extending the
> > autosuspend delay avoids autosuspending during this interval.
> >
> > Signed-off-by: Drew Davenport <ddavenport@chromium.org>
> >
> > ---
> >
> >  drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Pushed to drm-misc-next:

8d5d063fd669 drm/panel-samsung-atna33xc20: Extend autosuspend delay
  

Patch

diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
index f4616f0367846..5703f4712d96e 100644
--- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
+++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
@@ -310,7 +310,7 @@  static int atana33xc20_probe(struct dp_aux_ep_device *aux_ep)
 	ret = devm_add_action_or_reset(dev,  atana33xc20_runtime_disable, dev);
 	if (ret)
 		return ret;
-	pm_runtime_set_autosuspend_delay(dev, 1000);
+	pm_runtime_set_autosuspend_delay(dev, 2000);
 	pm_runtime_use_autosuspend(dev);
 	ret = devm_add_action_or_reset(dev,  atana33xc20_dont_use_autosuspend, dev);
 	if (ret)