From patchwork Thu Nov 17 12:13:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcus Folkesson X-Patchwork-Id: 21614 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp364155wrr; Thu, 17 Nov 2022 04:12:47 -0800 (PST) X-Google-Smtp-Source: AA0mqf5sgQKjBHnvZbzVqfJVk+Nl3KU83Q3UZYxQl0AIa7lU5Mrv4NtQIu8sJpxq+zsfis+fCFwz X-Received: by 2002:a17:906:9402:b0:78d:8bb6:ba7f with SMTP id q2-20020a170906940200b0078d8bb6ba7fmr2031990ejx.100.1668687167760; Thu, 17 Nov 2022 04:12:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668687167; cv=none; d=google.com; s=arc-20160816; b=M58NbcaEU6/z8lh9xKCr+Qc5Mjum8+A8cihA1kUITOeTTluldVRUPHhMReAQ8dN1Ia 0bQ5GuVkv6w5gzwTqq8w6M1udbp1PBj36MM1pryM1FhTGredPZiK4lF4BxmyQ/mqZLqL DGH5nbkigIRM4jJc8gIaaidRODBsKkuR0QzmqeknFzlULsKqhpFtsgtglIpMhD9s9WfY fotN2zFI+PongU1OVwf/8cAcr3C0GSNfZt98c+cY13MtbutO1QRVSgfE/pFXUl+pUCDY ySGtMbszuiJ3bp37r2jele3H7F2VSZOJ/ee/gfJKJ7m8psfFTAhFp+Qu8yGsUYEd02l2 omPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=2ZQ6+hOFaKk/5UeozWSpWsKewGAgOXsoqvkqyl7Kn/s=; b=tDk6SKkva5UkFfd+vIHF4HR8SJzh4uRXa1C0rWR4wKZxpf+0SfMKVv8Vy1TnFGTh70 SdDi6ZPPiuRhAlTd/MAg6sDp4irqehHri5hj4Dw9uCPREntEG0GRtnMF5txs3yzjDSF5 g6dORRFrslA4aTmU8McfNPoSt6O+R6WvNtkbMMhoRR9B6R0QM6HcZlWturXpA+q/XS1w 2APOzRNINUCeOVUmGIVzfOHhA7jkKklI7Pgia4pq3jP1xmywQAaOOPAqVOP7ojYwP4po qUDij3wewMXjVjMpks6Zjru5jqjeQWi7Dyn0X7oQPhoFksdJNL1J09aJC3iE9UXNPokw kqhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gd0JLH35; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sg34-20020a170907a42200b00780805b99ccsi401545ejc.648.2022.11.17.04.12.23; Thu, 17 Nov 2022 04:12:47 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=gd0JLH35; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240015AbiKQMMD (ORCPT + 99 others); Thu, 17 Nov 2022 07:12:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239972AbiKQML7 (ORCPT ); Thu, 17 Nov 2022 07:11:59 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4077C47330; Thu, 17 Nov 2022 04:11:58 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id d6so2448946lfs.10; Thu, 17 Nov 2022 04:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=2ZQ6+hOFaKk/5UeozWSpWsKewGAgOXsoqvkqyl7Kn/s=; b=gd0JLH35qEWIjmLmCtR4y/iAm4+gwaDbDFYCCtYxgF+WPz0Ke/3cofKm/TqUTFc6Jt K1VRk8lhx5uhhXSN0vjRU8GGheQv2Cnmgb5hdHhcU4UKKKvUzYqqGlmstI3JG3yov5ft pT94l/csTjImx5XWffKwAshz7rPQoO/+Y4Hy7yd+jQCm81tLfufVgtovNIOw9nvCnKf7 N5If/F8jptlniIVIKz2q0i6P1jl7++hS2KgoRVhLnY/E8DQfSTaLGatr3VnrBwFJfzGj fDeKu6zS5F0o9xw0MX3BLD7IzD7LaGKQrqlvhCScI5fD0/v1DXeswUBbcU+ebPSTKa0j l4RA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2ZQ6+hOFaKk/5UeozWSpWsKewGAgOXsoqvkqyl7Kn/s=; b=xT5Q0NzgXdvMOaJVgGIAWQ7YEeIWfNX6Tml5NvC1ZmEvyQ6xNypoilVnGMugA11emD /D/CsTDrvp/GbP2BhF/DbTjFY8CV2V/5m4OgWiDuCTk2x2GjVnt1mRHdrGgkbW3HNUON Xim3MNgED6KT2nbkWIsgojkEvTe6d4IeFIuJCvBybL45/UsHougdGN9tLJdVTQGW4GpI DX876fF/nU42mKiYmubkT6knBApjoeALq1fz5jS5k+FiL5/2/dHwQq1L5F8OqdfbQ4/9 9wZmZ/TRmj2FtmCzrmYq/hek3rAxF+72CVFh4sjF0Fr0NR8er0nS43HgfwWPr7BespOq shCw== X-Gm-Message-State: ANoB5pnpIcVtOGrGH4mjJtwyyF31wrWSB8GP9DJTuaYr6bpK6KIYG5L4 hSIocANag7a0jhyUOZwHSzw= X-Received: by 2002:a05:6512:376c:b0:4ad:70c1:de61 with SMTP id z12-20020a056512376c00b004ad70c1de61mr745657lft.509.1668687116549; Thu, 17 Nov 2022 04:11:56 -0800 (PST) Received: from localhost.localdomain (82-209-154-112.cust.bredband2.com. [82.209.154.112]) by smtp.gmail.com with ESMTPSA id be40-20020a056512252800b00497a61453a9sm117565lfb.243.2022.11.17.04.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Nov 2022 04:11:55 -0800 (PST) From: Marcus Folkesson To: Jiri Kosina , Benjamin Tissoires , Marcus Folkesson Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: [PATCH RESEND] HID: hid-elan: use default remove for hid device Date: Thu, 17 Nov 2022 13:13:14 +0100 Message-Id: <20221117121314.5577-1-marcus.folkesson@gmail.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749745315495035479?= X-GMAIL-MSGID: =?utf-8?q?1749745315495035479?= hid_device_remove() will call hid_hw_stop() as default .remove function if no function is specified. Signed-off-by: Marcus Folkesson --- drivers/hid/hid-elan.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/hid/hid-elan.c b/drivers/hid/hid-elan.c index 8e4a5528e25d..76d93fc48f6a 100644 --- a/drivers/hid/hid-elan.c +++ b/drivers/hid/hid-elan.c @@ -507,11 +507,6 @@ static int elan_probe(struct hid_device *hdev, const struct hid_device_id *id) return ret; } -static void elan_remove(struct hid_device *hdev) -{ - hid_hw_stop(hdev); -} - static const struct hid_device_id elan_devices[] = { { HID_USB_DEVICE(USB_VENDOR_ID_ELAN, USB_DEVICE_ID_HP_X2), .driver_data = ELAN_HAS_LED }, @@ -529,7 +524,6 @@ static struct hid_driver elan_driver = { .input_configured = elan_input_configured, .raw_event = elan_raw_event, .probe = elan_probe, - .remove = elan_remove, }; module_hid_driver(elan_driver);