From patchwork Thu Nov 17 09:05:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Tang X-Patchwork-Id: 21514 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp293165wrr; Thu, 17 Nov 2022 01:10:07 -0800 (PST) X-Google-Smtp-Source: AA0mqf70HyRlR64Mh0A85/23BeMaUyNaCvHNAU71JpKai8ulXrdKdMgf2+wvOVeBMMBHEiaerQUQ X-Received: by 2002:a65:6808:0:b0:43c:758:5190 with SMTP id l8-20020a656808000000b0043c07585190mr1238259pgt.339.1668676207551; Thu, 17 Nov 2022 01:10:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668676207; cv=none; d=google.com; s=arc-20160816; b=fe7Fy0lPVYYDMgypm/AOVqqNrOIbld/E4bY1Foapy0FuVbpwws+isyNZetAaFvn7qP JAIqgFK1jXuFXuH5F7np64274SPq++AK+AP+eesvDf1wF0Vkjct/C6yREmTpkon20sU+ 3IrGmkRtWOtrxZ17D8HeEc6V+XvDJrmQY0IBcN97FjZBW9w/9UGJRWdIVNwQHHe1oS/j YZJ2cDt3tasyJWIvqqDIYmgBFd3mWAYmpBojOI/5h7T9UCUkARLdgdrsJQ1Grzvelfhy CKyJyZgzxivpYnqI0ceDHe+jlGz6YmBwG0/a3qoLFqoxiVseM9poyP4KUE+ItLtKRLVh CtkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=XcflEfAsl1kER3opwufULZWmC+IaH1Y5ZdTQRPhe4lU=; b=bQ+UB3tPUhJP7XUWHOkREPcjcNz/FLDlSlt8DjNuKmcsDUNxfw5Eav7NFPYxpsVlBr xQZXAtojixcmOQTrG/c/ck3fdnZVSEOGSIVASo5ZbJj19VFQThCTBFxOs2BT3jvd2Akn SklHLPtir9dsC8IaU1YxEn5Kll1C/6qd3o8jhfNA7PRUOZBCH8sz3kljvN73qIY47NO1 1T8KvJCwVkVY1/lJdPNLiXECxf7XLo6FnEdZ3ArfBotr3MDDmbuTjpEw1IWXAzBH2Yp+ UPm5wTf0m/jCWIs/Kvrjfo5t6o10ySKD7WlkPv54KwDNSjUTfNvwBcbOeBhOJdGjQ+F9 Plcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l17-20020a637011000000b0046a1ae37df5si555974pgc.147.2022.11.17.01.09.54; Thu, 17 Nov 2022 01:10:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239712AbiKQJIi (ORCPT + 99 others); Thu, 17 Nov 2022 04:08:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36212 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239715AbiKQJIf (ORCPT ); Thu, 17 Nov 2022 04:08:35 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE4F0A1B9; Thu, 17 Nov 2022 01:08:34 -0800 (PST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.56]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NCYsT1ZPJzJnpT; Thu, 17 Nov 2022 17:05:17 +0800 (CST) Received: from kwepemm600005.china.huawei.com (7.193.23.191) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 17:08:26 +0800 Received: from ubuntu1804.huawei.com (10.67.175.30) by kwepemm600005.china.huawei.com (7.193.23.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 17:08:26 +0800 From: Hui Tang To: , , , , , , CC: , , Subject: [PATCH net v2] net: mdio-ipq4019: fix possible invalid pointer dereference Date: Thu, 17 Nov 2022 17:05:14 +0800 Message-ID: <20221117090514.118296-1-tanghui20@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.30] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600005.china.huawei.com (7.193.23.191) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749537411846688266?= X-GMAIL-MSGID: =?utf-8?q?1749733822574382151?= priv->eth_ldo_rdy is saved the return value of devm_ioremap_resource(), which !IS_ERR() should be used to check. Fixes: 23a890d493e3 ("net: mdio: Add the reset function for IPQ MDIO driver") Signed-off-by: Hui Tang --- v1 -> v2: set priv->eth_ldo_rdy NULL, if devm_ioremap_resource() failed --- drivers/net/mdio/mdio-ipq4019.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mdio/mdio-ipq4019.c b/drivers/net/mdio/mdio-ipq4019.c index 4eba5a91075c..dfd1647eac36 100644 --- a/drivers/net/mdio/mdio-ipq4019.c +++ b/drivers/net/mdio/mdio-ipq4019.c @@ -231,8 +231,11 @@ static int ipq4019_mdio_probe(struct platform_device *pdev) /* The platform resource is provided on the chipset IPQ5018 */ /* This resource is optional */ res = platform_get_resource(pdev, IORESOURCE_MEM, 1); - if (res) + if (res) { priv->eth_ldo_rdy = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(priv->eth_ldo_rdy)) + priv->eth_ldo_rdy = NULL; + } bus->name = "ipq4019_mdio"; bus->read = ipq4019_mdio_read;