From patchwork Thu Nov 17 06:47:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jinjie Ruan X-Patchwork-Id: 21463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp248652wrr; Wed, 16 Nov 2022 22:55:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf6TetkhG+gsoBCPZFjXkQGzoGr2/6xSe++Psf7WzKoVANnJnquTlitqsD3HZhJoLhi52R5z X-Received: by 2002:a17:906:1b52:b0:7ad:90dc:b7d4 with SMTP id p18-20020a1709061b5200b007ad90dcb7d4mr1030326ejg.278.1668668136100; Wed, 16 Nov 2022 22:55:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668668136; cv=none; d=google.com; s=arc-20160816; b=JdJfxCYyjEeC5GSPSlBhWPQ5nj1Ky7zuEiyoBTCXFTOuUPFWyeLTkq8hYtF6hZ+bOn Q06awWthHSt54ZzrSJciRFujyr2FMObsHatvQIR0KIlxQ0XFhHRi/pSWV3TR5OwCFbhU /4rzDfIPkt0MqyQPCSbtfV3WVBG8cRDnNjjHKCQp4+HBtccoyqFIWsZ6RaviOSaBqo7A FPcX4WGkqYAHrSGMHvXDEQJzXeVb658fe3sTna6vSXlxayMxYk4mW0D1O12Tm9PV6uxz pGbXWelbe4/5PQBoJ7j0fOwGNdsSHOZr0SR9XfeI1DJ/3vUS8Jv9dDb9Eaj/BT0YwU3k ZRYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=7glFi6fw7zOPAt+vlUUNgXrE/XnyhBb5Tmmfpr/u8v0=; b=0RjQk5+Fu/kpVt28rBLn/+4DZHmNgRaISBrZJ4X1ksmXlN1MtvX9Q4ws4ARpK7G5Ja HutzLv4M6TlANLOb/5w3dqn0QuZgsAduwSfnt/9K3slnPsFm6uovQuG7afPgTd3Kd1FS tlMN56sdq4clLVc0TMDamhcgv3UhsrqtM1awYCe2LBG04Jj9aXCE0Tz8eVmjPBIutcbA 2YU9Aq8Kp3nDFeXI+F8s0OmF1eSo4pgVSbCl/iDyImg+XaQ4VftsnVA8FOQKrwv4vCnW tgf2BGlGjnzCHJZ2AMoJA8rVAEhfdTKcQyQxbphDPjeKfgkgfM/Ift+k9nOyG0QnRmw2 FpXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dz8-20020a0564021d4800b00461992160edsi266381edb.384.2022.11.16.22.55.13; Wed, 16 Nov 2022 22:55:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238813AbiKQGus (ORCPT + 99 others); Thu, 17 Nov 2022 01:50:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234756AbiKQGun (ORCPT ); Thu, 17 Nov 2022 01:50:43 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 343A86BDD5 for ; Wed, 16 Nov 2022 22:50:41 -0800 (PST) Received: from kwepemi500008.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4NCVsW67wlzHvql; Thu, 17 Nov 2022 14:50:07 +0800 (CST) Received: from huawei.com (10.67.175.83) by kwepemi500008.china.huawei.com (7.221.188.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 17 Nov 2022 14:50:38 +0800 From: ruanjinjie To: , , , , CC: Subject: [PATCH] misc: tifm: fix possible memory leak in tifm_7xx1_switch_media() Date: Thu, 17 Nov 2022 14:47:25 +0800 Message-ID: <20221117064725.3478402-1-ruanjinjie@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.83] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500008.china.huawei.com (7.221.188.139) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749725359475419844?= X-GMAIL-MSGID: =?utf-8?q?1749725359475419844?= If device_register() returns error in tifm_7xx1_switch_media(), name of kobject which is allocated in dev_set_name() called in device_add() is leaked. Never directly free @dev after calling device_register(), even if it returned an error! Always use put_device() to give up the reference initialized. Fixes: 2428a8fe2261 ("tifm: move common device management tasks from tifm_7xx1 to tifm_core") Signed-off-by: ruanjinjie --- drivers/misc/tifm_7xx1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/tifm_7xx1.c b/drivers/misc/tifm_7xx1.c index 017c2f7d6287..7dd86a9858ab 100644 --- a/drivers/misc/tifm_7xx1.c +++ b/drivers/misc/tifm_7xx1.c @@ -190,7 +190,7 @@ static void tifm_7xx1_switch_media(struct work_struct *work) spin_unlock_irqrestore(&fm->lock, flags); } if (sock) - tifm_free_device(&sock->dev); + put_device(&sock->dev); } spin_lock_irqsave(&fm->lock, flags); }