From patchwork Thu Nov 17 01:05:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shaopeng Tan X-Patchwork-Id: 21363 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp152436wrr; Wed, 16 Nov 2022 17:13:42 -0800 (PST) X-Google-Smtp-Source: AA0mqf75OhQ+f+TwIwKJXZGZoWLmPUWArrgimuCdJyio4rYqBlTDDnZH7/9LqRMFhOFj/sdlW5UZ X-Received: by 2002:aa7:d2c5:0:b0:459:1788:5e49 with SMTP id k5-20020aa7d2c5000000b0045917885e49mr225557edr.321.1668647622690; Wed, 16 Nov 2022 17:13:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668647622; cv=none; d=google.com; s=arc-20160816; b=wiCAfdQGgcdDz2vy39mVtsuOoiM8+DtUDMgHegRCCDAIYaJRuZAEi76UdWJgwkrJqC F2t8p5Fk1S+lMMiAc2xXOWkz57gQoMem4u9r0WAbqlBHLIOYWVmbr3n/ToOZqEdbbJ22 z2WtSASflF0pBRL2ozxp0QF1plR3F5HDhGArgMCkzRKKD41I5ZBzuoycTczlbL2vBtbD KvoX8oDtZUO0fK77Ny7Ix/c92HXwa+BLxh3zQU+2QIyibP1RuL9d3xWX3jzXbANkXFz6 V5Wt209ZBxPXHeR/bOx5uh1nnuyIf1AQ9K79Ah1LGVKH5mFkVTgEGdyxq4rqKHqps5rZ wn3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8vB7wSoHkVQdDBEgWvv4iIcFC9Fe76TYmbSGIUh7/DA=; b=anLNJDeshqqBOgNvo2sj5bhN3jONiTU4PugFO2gmaJecRUIgbWNsekxDBI6ZAt/IAF fj4W9I+EIj4sdDY1Zb98LE0/GfL7AFi+TFJwRjM4dIy6lbxopaMWpPKuVyS5NQgQKdI+ +PMLXQVCxdWbjSkXSmkCRhHuxd1PSIq6dSv5Cnn9UbX3m4OL04kRMPmfOF9FD35E1k5B fXCKpqwViViaOx3rotccLdExjYm4SfXHGxpbYkhVeH6l+FqWBPQRliVU+axTt+cVNilK Tj6QCflvr4xplxpR1OX45qtSmqPp7RxNZ5oF3MdNmcETnXxxoJqVU7iUUfK0DdG7SkcM 3cJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qq16-20020a17090720d000b007721f88d3e0si12214125ejb.554.2022.11.16.17.13.19; Wed, 16 Nov 2022 17:13:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=fujitsu.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238754AbiKQBLs (ORCPT + 99 others); Wed, 16 Nov 2022 20:11:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234238AbiKQBLj (ORCPT ); Wed, 16 Nov 2022 20:11:39 -0500 Received: from esa7.hc1455-7.c3s2.iphmx.com (esa7.hc1455-7.c3s2.iphmx.com [139.138.61.252]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A65C2496B; Wed, 16 Nov 2022 17:11:37 -0800 (PST) X-IronPort-AV: E=McAfee;i="6500,9779,10533"; a="75100886" X-IronPort-AV: E=Sophos;i="5.96,169,1665414000"; d="scan'208";a="75100886" Received: from unknown (HELO yto-r4.gw.nic.fujitsu.com) ([218.44.52.220]) by esa7.hc1455-7.c3s2.iphmx.com with ESMTP; 17 Nov 2022 10:11:35 +0900 Received: from yto-m1.gw.nic.fujitsu.com (yto-nat-yto-m1.gw.nic.fujitsu.com [192.168.83.64]) by yto-r4.gw.nic.fujitsu.com (Postfix) with ESMTP id BB290D3EA0; Thu, 17 Nov 2022 10:11:34 +0900 (JST) Received: from oym-om4.fujitsu.com (oym-om4.o.css.fujitsu.com [10.85.58.164]) by yto-m1.gw.nic.fujitsu.com (Postfix) with ESMTP id 1B6D2CFF8A; Thu, 17 Nov 2022 10:11:34 +0900 (JST) Received: from cn-r05-10.example.com (n3235113.np.ts.nmh.cs.fujitsu.co.jp [10.123.235.113]) by oym-om4.fujitsu.com (Postfix) with ESMTP id ED07840089710; Thu, 17 Nov 2022 10:11:33 +0900 (JST) From: Shaopeng Tan To: Fenghua Yu , Reinette Chatre , Shuah Khan Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, tan.shaopeng@jp.fujitsu.com, Shuah Khan Subject: [PATCH v4 2/5] selftests/resctrl: Return MBA check result and make it to output message Date: Thu, 17 Nov 2022 10:05:38 +0900 Message-Id: <20221117010541.1014481-3-tan.shaopeng@jp.fujitsu.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com> References: <20221117010541.1014481-1-tan.shaopeng@jp.fujitsu.com> MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749703850066993143?= X-GMAIL-MSGID: =?utf-8?q?1749703850066993143?= Since MBA check result is not returned, the MBA test result message is always output as "ok" regardless of whether the MBA check result is true or false. Make output message to be "not ok" if MBA check result is failed. Reviewed-by: Shuah Khan Reviewed-by: Reinette Chatre Signed-off-by: Shaopeng Tan --- tools/testing/selftests/resctrl/mba_test.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/resctrl/mba_test.c b/tools/testing/selftests/resctrl/mba_test.c index 1a1bdb6180cf..e3a473976d74 100644 --- a/tools/testing/selftests/resctrl/mba_test.c +++ b/tools/testing/selftests/resctrl/mba_test.c @@ -51,10 +51,10 @@ static int mba_setup(int num, ...) return 0; } -static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) +static bool show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) { int allocation, runs; - bool failed = false; + bool ret = false; ksft_print_msg("Results are displayed in (MB)\n"); /* Memory bandwidth from 100% down to 10% */ @@ -90,13 +90,15 @@ static void show_mba_info(unsigned long *bw_imc, unsigned long *bw_resc) ksft_print_msg("avg_bw_imc: %lu\n", avg_bw_imc); ksft_print_msg("avg_bw_resc: %lu\n", avg_bw_resc); if (avg_diff_per > MAX_DIFF_PERCENT) - failed = true; + ret = true; } ksft_print_msg("%s Check schemata change using MBA\n", - failed ? "Fail:" : "Pass:"); - if (failed) + ret ? "Fail:" : "Pass:"); + if (ret) ksft_print_msg("At least one test failed\n"); + + return ret; } static int check_results(void) @@ -132,9 +134,7 @@ static int check_results(void) fclose(fp); - show_mba_info(bw_imc, bw_resc); - - return 0; + return show_mba_info(bw_imc, bw_resc); } void mba_test_cleanup(void)