From patchwork Wed Nov 16 20:53:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Markus Schneider-Pargmann X-Patchwork-Id: 21268 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:f944:0:0:0:0:0 with SMTP id q4csp57521wrr; Wed, 16 Nov 2022 12:57:36 -0800 (PST) X-Google-Smtp-Source: AA0mqf7/gF3q0fdCTYWpKVV2nMzjQTVz0MnlC3G6eMf6lFYcvAlQ1IAVEan0jSXuqc1Ophajb21E X-Received: by 2002:a17:902:e847:b0:186:8d12:f51f with SMTP id t7-20020a170902e84700b001868d12f51fmr10767211plg.129.1668632256207; Wed, 16 Nov 2022 12:57:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668632256; cv=none; d=google.com; s=arc-20160816; b=rUscsl8lN0PE68ReC3nWTJah3niDwVbEuiifJHTqi3O86YO90AeRCJH4fjwd2aqmDK B1JGt2g3BdJAELiRLEUI2MwEs+bmddaocP7V3R7Pqm19dq2fdgm4tQWyLv7PpF09spaq gn8zkyJoaxDLsjZUXb61x2UQd50evg/LVPE9v3kwRerKWwippQ3oqYHlT8PidKLSqFKM BOQbkZcu9xf5+QurVjbrNRG/y58Q4efsNcjGS9Es/x6FHs3c2vWDj/uEe8VLrEoYOfn0 whmYh8J75H8DBvLMMvmATHxXNabF2jwyih9A1I6V9f5k8e+nbtGkPDaiECJzvsfDiDJQ smcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ah82tTOOObOFB3MDfuIM4J36KFmptfShWyxBMhuP5Xo=; b=aErgHBVIZIgmIpxJJU+8iB+Qc1HJV+nbl6JRovFcjU1tygBK2mEi+UK4zX42QPghdR 7Ocrym+bZyjd0S2qgJ3n9R2fg3PVrmdBHIGSwtSjjzzXxz+z7vMhCYStBxcwTZQfLauU RGUPjtPmdUxrsJfwSnZOrE15Z7F+fkdEIBpksmVMpL87zdJ6hpxtBj2cFBojhpErFRvX 47plAwcqWuXYt6wd4h2BJEySz5J0O2aHIP80dufzpcJPmJen6BJVYzJb7I3dg9jQQP/E +g6ineJad6/pf7hohMv4mMURj5jOOryiqkD2ZWsUy3RI0Mdja0aGEoe4DAWOcJsDXr/e c0/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=FuFd7KEQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n21-20020aa78a55000000b0056ec4a6babasi13909411pfa.381.2022.11.16.12.57.23; Wed, 16 Nov 2022 12:57:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20210112.gappssmtp.com header.s=20210112 header.b=FuFd7KEQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239074AbiKPUzA (ORCPT + 99 others); Wed, 16 Nov 2022 15:55:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238534AbiKPUx5 (ORCPT ); Wed, 16 Nov 2022 15:53:57 -0500 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26F366546 for ; Wed, 16 Nov 2022 12:53:34 -0800 (PST) Received: by mail-ej1-x633.google.com with SMTP id n20so99547ejh.0 for ; Wed, 16 Nov 2022 12:53:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ah82tTOOObOFB3MDfuIM4J36KFmptfShWyxBMhuP5Xo=; b=FuFd7KEQ6d41KZBOZhhpBhnMjYXdxKD3gEK+faGWa/XfhW2EFx9CCnj4pbSYMac2Rg VIuXojA8qB/pnTAwSH/PmZxKpCmL2eAkLQyhE5BR42zG3IEDpWTJHKhUoMPbBlM0cwsa aoDXSsa8MbXs5ScTvpr0crbR+Zr5r66T3BoltNI3RObZ5w0EZWcatVi6Jt5ZsATEp/Dw jt8b+Zt2tr8/FhtYKWD6X46XX4b1PFmxtCddxq2uisW6m40miJnZawPupYuP4ofRL7OM qqYATmJca9f9feYgFHce3A/dYWupesj+8yaW4A7p+R4+b/3M0R4QMymOG5zlpIyc1L2s gTUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ah82tTOOObOFB3MDfuIM4J36KFmptfShWyxBMhuP5Xo=; b=jYylEn3XdlXg9e2zO4B7Dp4X2LqHlFos6Cq53QRkalDXbAH1mQrhho2WuX3R9YF9zD m/Kdtr3EcFiN5nwYGFbU5VjNNb7xLsRUIT4QCslI2cyIKKQNPfZNkxPr0afG4N4z2TjO p94dhoMJAJeKHm9DtSeP/i9X1OM8ia0KRaiP0tTT2B8PipyMK1wy9XZWwwtLNOV3hxtC BGtgITu/KpbWOmKVS/b8zCJILK6b7zjErZK7QYe7nUx41fHPERQ45mzY+I8qL1g0Q+vq c9dm7VWSG9s4f5b4SmpZoVJ/wFPAmaZON+Zw5/qAwgkTxoeu/I7F1Gz1CAhFjpJfuw4I mLmw== X-Gm-Message-State: ANoB5pkzt0857Xey6hrLumUWiibN4BLedLJ9XwWeNTFW1pf6tNeU6OUz sgjw50dHatzeaCZcJMn+mWAJ9g== X-Received: by 2002:a17:906:53cd:b0:78c:1f2f:233e with SMTP id p13-20020a17090653cd00b0078c1f2f233emr19534963ejo.307.1668632013651; Wed, 16 Nov 2022 12:53:33 -0800 (PST) Received: from blmsp.fritz.box ([2001:4090:a244:804b:353b:565:addf:3aa7]) by smtp.gmail.com with ESMTPSA id kv17-20020a17090778d100b007aece68483csm6782828ejc.193.2022.11.16.12.53.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 12:53:33 -0800 (PST) From: Markus Schneider-Pargmann To: Chandrasekar Ramakrishnan , Marc Kleine-Budde , Wolfgang Grandegger Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann Subject: [PATCH 12/15] can: tcan4x5x: Remove invalid write in clear_interrupts Date: Wed, 16 Nov 2022 21:53:05 +0100 Message-Id: <20221116205308.2996556-13-msp@baylibre.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221116205308.2996556-1-msp@baylibre.com> References: <20221116205308.2996556-1-msp@baylibre.com> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749687736491009583?= X-GMAIL-MSGID: =?utf-8?q?1749687736491009583?= Register 0x824 TCAN4X5X_MCAN_INT_REG is a read-only register. Any writes to this register do not have any effect. Remove this write. The m_can driver aldready clears the interrupts in m_can_isr() by writing to M_CAN_IR which is translated to register 0x1050 which is a writable version of this register. Signed-off-by: Markus Schneider-Pargmann --- drivers/net/can/m_can/tcan4x5x-core.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/can/m_can/tcan4x5x-core.c b/drivers/net/can/m_can/tcan4x5x-core.c index 41645a24384c..1fec394b3517 100644 --- a/drivers/net/can/m_can/tcan4x5x-core.c +++ b/drivers/net/can/m_can/tcan4x5x-core.c @@ -204,11 +204,6 @@ static int tcan4x5x_clear_interrupts(struct m_can_classdev *cdev) if (ret) return ret; - ret = tcan4x5x_write_tcan_reg(cdev, TCAN4X5X_MCAN_INT_REG, - TCAN4X5X_ENABLE_MCAN_INT); - if (ret) - return ret; - ret = tcan4x5x_write_tcan_reg(cdev, TCAN4X5X_INT_FLAGS, TCAN4X5X_CLEAR_ALL_INT); if (ret)