From patchwork Wed Nov 16 16:49:13 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roger Quadros X-Patchwork-Id: 21181 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp248119wru; Wed, 16 Nov 2022 08:59:29 -0800 (PST) X-Google-Smtp-Source: AA0mqf7agKJigDDLMh9DEDBikNYcj5+BO0rSZ44qWYq6AiP3lMo+EVggd78awhGyHnO2ZdWZLqVZ X-Received: by 2002:a17:902:a402:b0:186:994b:5b55 with SMTP id p2-20020a170902a40200b00186994b5b55mr10033017plq.100.1668617968971; Wed, 16 Nov 2022 08:59:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668617968; cv=none; d=google.com; s=arc-20160816; b=sBNEmRiXcCl5E8M+A3l0Bx2bC09DMrhJht/ZOW77NBXNPOtO+Qg1NKBVVABL4rSPNr 1kNu6ihTBtdRovjrZK2ojsEJ5hlJolxIJVFsXYcSrfdzwf7wjBbfUR40+Zu6EeJXDTsX hOBTAs/RJPKpCc7Xv3ybWJWhMktxSOtmBXNtN0sLpjaTXR5mlpKGKSrtwwGZABDtEEvN Hhmk9dDc7STBitqAyf15rsA2y1+trY7FfaB7BdzZ4Vlti2cKohKOAsR97FHTZCX+yaCL S9lvbTrrvGdLq6qUlNnhzd6qpaO1FcqU1rJ1vJXlpCLpKqo9Wf5LIJQ5bNT65BPvpoZi sT5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=ByuitP/gl1A6jrn6Sjyz8Qzq9Z6CHdwwioyVapJn0xk=; b=vz8sUg1xdXwnCOrOBIVx7SidVbGff1vOHClDOc1aSuAzo7YuA9eCcVL2RRPCTt9MbL 3hUoGN++NMpGZZGuJx8Zu5IyHR7H0/tjWC4BbbVoSiKo3F5rsRG0Ir0iSRnICe2Z1Xfr WPDk8GQtBYbwErnwXgqjRKQKCYQnLS3JBZ4E+b3UmKaVter9ERyD7v8/o2t/bXkrBYIA yJgrxzShiHnQZOYKV8jTUAQY0IXu//u7hz6c69bmLfZ2RcMUIff0LMxz4W4A3nm6Dujf lclv3H4Jhi0UlOZw/lFtzsWaYB/lT7wNrvIXCL3futMWOQEDMQlFQODfHCdqMf3iDZBU OL0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cRlE3TGR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k36-20020a635624000000b00476cd353915si4061254pgb.63.2022.11.16.08.59.16; Wed, 16 Nov 2022 08:59:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cRlE3TGR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229863AbiKPQva (ORCPT + 99 others); Wed, 16 Nov 2022 11:51:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35930 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239079AbiKPQur (ORCPT ); Wed, 16 Nov 2022 11:50:47 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F223EBFD; Wed, 16 Nov 2022 08:49:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8F47C61EEE; Wed, 16 Nov 2022 16:49:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C8684C433C1; Wed, 16 Nov 2022 16:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668617367; bh=16nnj3/xX+6iwyOgTVs9QzovzYa3SNqQYQfd1VXyLeo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cRlE3TGR1U6cSXl9fCHIs/XV+TdWdcs1TMYAMDX5IWHXUGnSlu2GVTDFRuKhE4VOl +abfIUsa9kbUOuYcqWi7o4oDK+DCRpCYUNAC0nXEAqzWT5dGEgam3hyrxSPVyCdl7j oU2woeD6kE4BKXBAw98UQ5WEAXiNatFhBmHIqd5brvAI3eS9nhYBuoApAp+fYZ4p3d F0091tTLQTi7S4kWOZv9wBUX3PYpw1HBskoCE1MstIiJ5eWwR4mIcFp7XGOYFCqytb 7rfAdNldYJd88eUIHV+EOgK1PQ3rqyrsnPbcQaibnCEKtCWWEWohoH6EiMXkTnBzL4 eYweCjtYAAKLA== From: Roger Quadros To: davem@davemloft.net, kuba@kernel.org Cc: edumazet@google.com, pabeni@redhat.com, vigneshr@ti.com, linux-omap@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Roger Quadros Subject: [PATCH 2/4] net: ethernet: ti: am65-cpsw-nuss: Remove redundant ALE_CLEAR Date: Wed, 16 Nov 2022 18:49:13 +0200 Message-Id: <20221116164915.13236-3-rogerq@kernel.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221116164915.13236-1-rogerq@kernel.org> References: <20221116164915.13236-1-rogerq@kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749672755306032389?= X-GMAIL-MSGID: =?utf-8?q?1749672755306032389?= ALE_CLEAR command is issued in cpsw_ale_start() so no need to issue it before the call to cpsw_ale_start(). Fixes: fd23df72f2be ("net: ethernet: ti: am65-cpsw: Add suspend/resume support") Signed-off-by: Roger Quadros --- drivers/net/ethernet/ti/am65-cpsw-nuss.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.c b/drivers/net/ethernet/ti/am65-cpsw-nuss.c index f8899ac5e249..4107e9df65cd 100644 --- a/drivers/net/ethernet/ti/am65-cpsw-nuss.c +++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.c @@ -404,7 +404,6 @@ static int am65_cpsw_nuss_common_open(struct am65_cpsw_common *common) /* disable priority elevation */ writel(0, common->cpsw_base + AM65_CPSW_REG_PTYPE); - cpsw_ale_control_set(common->ale, 0, ALE_CLEAR, 1); cpsw_ale_start(common->ale); /* limit to one RX flow only */