From patchwork Wed Nov 16 13:37:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukas Bulwahn X-Patchwork-Id: 21071 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp146126wru; Wed, 16 Nov 2022 05:45:31 -0800 (PST) X-Google-Smtp-Source: AA0mqf5nGpUzztKJZavKm5UyezP+tu4LIYZVc2Dm8Mf98yowbd8LAEyUPJzyQvkiIDZN9WoJkDC4 X-Received: by 2002:a05:6402:c05:b0:460:5340:d522 with SMTP id co5-20020a0564020c0500b004605340d522mr18838605edb.87.1668606331787; Wed, 16 Nov 2022 05:45:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668606331; cv=none; d=google.com; s=arc-20160816; b=C7OpM0z0IkR84VGjpGzFekMCa17C7tV8vMkGXvJH/AydHcsoYMEngBlcEc3522iYdj IWX92j18pKtmmyiayZrglWDq4kdHIXgb41SSk1bdqok3hESAE1CwCAlqo5JdezhuJpMl DtdkUW+UIFlwIASBn46Y+ISZyotXmTiKY/kHfFn3iVdpA7BI3gtSoDQicksyPMVObNCq f7rM0U9fVXAn9pyNFlnsGyfv27dg3bI8fRB5STEhOcgdeI9FH/j6uhbW3P/MBo02qYDS lT7eHpeOKxgfO4KaJ+sqmZu25vKMZOS9S00cCaJixdpKE8b3R/CFQyjJh9qPhPx4FkVe XXdA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from :dkim-signature; bh=4wIDFtoQcxM4v9BSbkXANKUxT6C+d890LN3a0zTsJxA=; b=igTEPfDWdPqx3nZelgnFSnYEye/8A+eQkrXMGI7nYBxVkXzO7nfkSFTNUtzTJ9lE3r XB3nRN6PZgK98UU9R8r5cAp2F2QiO0v/XsmAcr9B/4jsqJQL1IW7rpKJRYTKI7478u7i nSEws23gBGPrxHswpNC/v+uBmzoBY5Jqoj6yHPEprKkWHlfiKELX69XKCHuWEhFEYNbC Lryp3452C9g015rG80yNdtzwuE7J2Um2oLtzg2gEyFrvDB5tqGDUf6S2X3ZcZDTXl9St +wtYu+SOYtZi1tdLhytMYXwRRrUXVdWc5k3HftEHf6Gj9FwVnoMYSVbvIExfgYWN1TX0 Ez3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Vr3x0gTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i10-20020a0564020f0a00b004622a17f12bsi13592760eda.259.2022.11.16.05.45.06; Wed, 16 Nov 2022 05:45:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=Vr3x0gTv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234038AbiKPNiU (ORCPT + 99 others); Wed, 16 Nov 2022 08:38:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237831AbiKPNiQ (ORCPT ); Wed, 16 Nov 2022 08:38:16 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA734429AA; Wed, 16 Nov 2022 05:38:14 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id ft34so44045390ejc.12; Wed, 16 Nov 2022 05:38:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4wIDFtoQcxM4v9BSbkXANKUxT6C+d890LN3a0zTsJxA=; b=Vr3x0gTvOeZDCKekWYV9fzA8t5IzU6556bd+oUIKmGCAYwjc4GLIlYpkxHKU0vti4h 2zxxSV3A09jjeFsBVAMlhjk4ftpNNJ4qnbQwCO+rK0vIgmXHz9D4KqhUxw85jhDC0mMR eO157reViF9/Hg/c6tgdHtiecbTJw3YA4/ySoBAbm96hSahWOQWH0Fpu+WofM3HkhVHo oG24UOx5pPpOrlrCmCngtboRMTcG4mCHSHIj/RpiVhUCgAToGHIgVcKW1bj7v5cZE5/9 uLSk/ZrcwTExiPKqYtcOCmyAlCRg3Hr+QlpSRuyjztIZQqh9DCW0FF86ELPdqZSl+64f evDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4wIDFtoQcxM4v9BSbkXANKUxT6C+d890LN3a0zTsJxA=; b=vKo4019M5/8N1jAXmasiJNcwnI3U6GqrU2xObxwBBeo62bUqMMOPwYirK8G6TEHekp gKw9TMVXwZV4EchxfpD2VMXUvvWA8cJO1U+7efst6YCEma/Qof3FyIilDaFypQxIzAFJ 1OxmCABlLDu8AMOoomXlWbnXe9G+QkTDUFz995642l2jS/ayNCAlojzoGDjVM9dkrBIw 0qjPbDH/lmd0P2XdEtosFa6FZ1QFVE1ZJsGxjykEArw1ZTKNxnqsBxA59VkJf0n7i/3c q62hf+Ip8bbbP+Uc19vHnueqAIEa70+o2F5wwJxSKJ6g8shXeCZibSaeLHJx5jGCZDze B80A== X-Gm-Message-State: ANoB5pm8QJJd/eBx316/bygKVe1stywDykewDttn54kWTv8iLuGyyKlF b78u4lqn1ciUOcUbk/UhwOc= X-Received: by 2002:a17:907:6f17:b0:791:9801:e48a with SMTP id sy23-20020a1709076f1700b007919801e48amr16926157ejc.738.1668605893180; Wed, 16 Nov 2022 05:38:13 -0800 (PST) Received: from felia.fritz.box (200116b826c55000c59461cca0b9a159.dip.versatel-1u1.de. [2001:16b8:26c5:5000:c594:61cc:a0b9:a159]) by smtp.gmail.com with ESMTPSA id c1-20020a17090618a100b0078b03d57fa7sm6869628ejf.34.2022.11.16.05.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Nov 2022 05:38:12 -0800 (PST) From: Lukas Bulwahn To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" Cc: Masahiro Yamada , Arnd Bergmann , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Lukas Bulwahn Subject: [PATCH v2] x86: make config X86_FEATURE_NAMES visible with EXPERT Date: Wed, 16 Nov 2022 14:37:53 +0100 Message-Id: <20221116133753.5615-1-lukas.bulwahn@gmail.com> X-Mailer: git-send-email 2.17.1 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749660552672081448?= X-GMAIL-MSGID: =?utf-8?q?1749660552672081448?= Commit 6a108a14fa35 ("kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT") introduces CONFIG_EXPERT to carry the previous intent of CONFIG_EMBEDDED and just gives that intent a much better name. That has been clearly a good and long overdue renaming, and it is clearly an improvement to the kernel build configuration that has shown to help managing the kernel build configuration in the last decade. However, rather than bravely and radically just deleting CONFIG_EMBEDDED, this commit gives CONFIG_EMBEDDED a new intended semantics, but keeps it open for future contributors to implement that intended semantics: A new CONFIG_EMBEDDED option is added that automatically selects CONFIG_EXPERT when enabled and can be used in the future to isolate options that should only be considered for embedded systems (RISC architectures, SLOB, etc). Since then, this CONFIG_EMBEDDED implicitly had two purposes: - It can make even more options visible beyond what CONFIG_EXPERT makes visible. In other words, it may introduce another level of enabling the visibility of configuration options: always visible, visible with CONFIG_EXPERT and visible with CONFIG_EMBEDDED. - Set certain default values of some configurations differently, following the assumption that configuring a kernel build for an embedded system generally starts with a different set of default values compared to kernel builds for all other kind of systems. Considering the first purpose, at the point in time where CONFIG_EMBEDDED was renamed to CONFIG_EXPERT, CONFIG_EXPERT already made 130 more options become visible throughout all different menus for the kernel configuration. Over the last decade, this has gradually increased, so that currently, with CONFIG_EXPERT, roughly 170 more options become visible throughout all different menus for the kernel configuration. In comparison, currently with CONFIG_EMBEDDED enabled, just seven more options are visible, one in x86, one in arm, and five for the ChipIdea Highspeed Dual Role Controller. As the numbers suggest, these two levels of enabling the visibility of even more configuration options---beyond what CONFIG_EXPERT enables---never evolved to a good solution in the last decade. In other words, this additional level of visibility of configuration option with CONFIG_EMBEDDED compared to CONFIG_EXPERT has since its introduction never become really valuable. It requires quite some investigation to actually understand what is additionally visible and it does not differ significantly in complexity compared to just enabling CONFIG_EXPERT. This CONFIG_EMBEDDED---or any other config to show more detailed options beyond CONFIG_EXPERT---is unlikely to be valuable unless somebody puts significant effort in identifying how such visibility options can be properly split and creating clear criteria, when some config option is visible with CONFIG_EXPERT and when some config option is visible only with some further option enabled beyond CONFIG_EXPERT, such as CONFIG_EMBEDDED attempted to do. For now, it is much more reasonable to simply make those additional seven options that are visible with CONFIG_EMBEDDED visible with CONFIG_EXPERT, and then remove CONFIG_EMBEDDED. If anyone spends significant effort in structuring the visibility of config options, they may re-introduce suitable new config options simply as they see fit. Make the config X86_FEATURE_NAMES visible when CONFIG_EXPERT is enabled. Signed-off-by: Lukas Bulwahn Reviewed-by: Masahiro Yamada Acked-by: Arnd Bergmann --- v1: https://lore.kernel.org/lkml/20220908104337.11940-3-lukas.bulwahn@gmail.com/ v1 -> v2: - fixed some omitted words in the commit message - added tags from Masahiro-san and Arnd arch/x86/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index cef0107e4260..4555ca4601e3 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -439,7 +439,7 @@ config SMP If you don't know what to do here, say N. config X86_FEATURE_NAMES - bool "Processor feature human-readable names" if EMBEDDED + bool "Processor feature human-readable names" if EXPERT default y help This option compiles in a table of x86 feature bits and corresponding