From patchwork Tue Nov 15 21:15:14 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 20570 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2947562wru; Tue, 15 Nov 2022 13:24:32 -0800 (PST) X-Google-Smtp-Source: AA0mqf4WumW/QYfZZnb0O+nz3waiPgmuVvZMjpzi963SkEc8cPD5bczPhDT4tsjdmkkLshvjCVHI X-Received: by 2002:aa7:c95a:0:b0:458:b6dc:2b56 with SMTP id h26-20020aa7c95a000000b00458b6dc2b56mr17055999edt.412.1668547471867; Tue, 15 Nov 2022 13:24:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668547471; cv=none; d=google.com; s=arc-20160816; b=ncMKMRrs5uW3NugmQOhTF/UR06PM0hDw0kYhVHdJaC3isxbv17cKoOxRHzueSnYpZ2 WsrMF0cA1CR4uOsgJ21QJJiDRy2Q7KnxUtU36Idyd5+pzNC37cKMNRhO+60JKmTNuFD6 x/YXZ/3TqGUTkSZgzhbuTdlQ3igjz7W5yv5YJQ/f5i9V0JLZvuBJ8lyGZxF/TT+Csa+2 Inf4604gsIUrate+1ZpTjIZ0YKHGpYBjRm0g43psk7DyDcXH4Dd9D8TuJElOEtimX0CM Ijd/BmxiBFdOjkLmZVXnsy/rOiBz6/oErwbqg77BFEbbz5GV/zxwWcmWbvNfx+ip9q/I /+PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=mz+VPiYyhoxC8IIeKLh1XFv7JZNnh+LEhxOjNVKt7Lw=; b=ACJtb8gRJukTeDURD4srxAeKPCKqwZ+Uw3d0m9VL3oca5vka6K+cxKXc/JM50sOfmg +HZ1byt2FR+RphTQcUMhBILju57PaCsZGwDEKFj/UAgbSFnGHBVBD0GUb4nFXgXkdIFO +T1RfeXWgfjeeTD3P7KfKJB6ffkqv+e3jLqDGgrmZJX7J5/lxO3MMZHaCoN05TfbAaKp rp+NzaKtsS4Rs/29XR02cXRKstQZP1KO3oGjyiySa4rRAxnxyJmnE/DU70FhKsfAhG6w 0zcPtexxwsvg95vt986Zx8sxOARL/ClGi5V9a78QIq3yqY7Hgjgqi7AexnmVQ9GJ0KO3 6/hA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c1-20020a0564021f8100b00452697eda4csi12362817edc.58.2022.11.15.13.24.05; Tue, 15 Nov 2022 13:24:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232084AbiKOVPs (ORCPT + 99 others); Tue, 15 Nov 2022 16:15:48 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231575AbiKOVPi (ORCPT ); Tue, 15 Nov 2022 16:15:38 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F251D0F5 for ; Tue, 15 Nov 2022 13:15:37 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ov3HJ-0005Bt-5a; Tue, 15 Nov 2022 22:15:33 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1ov3HH-004WcP-Ih; Tue, 15 Nov 2022 22:15:32 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ov3HH-00Guk8-Rj; Tue, 15 Nov 2022 22:15:31 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding Cc: Andy Shevchenko , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH 3/4] pwm: Mark free pwm IDs as used in alloc_pwms() Date: Tue, 15 Nov 2022 22:15:14 +0100 Message-Id: <20221115211515.3750209-4-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221115211515.3750209-1-u.kleine-koenig@pengutronix.de> References: <20221115211515.3750209-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1092; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=67Sh+CadgT81I090cww7WtAFSMpXxuv7y697vqIUN84=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBjdAFcha5RDK/Csdijh+RXlJ5/rD0qN+RkV7pgiJNr qNhACfCJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCY3QBXAAKCRDB/BR4rcrsCZwnCA Cc3xvqmi1E8ngVJ7uaHyqdaIhQavFIq9IkQ/T5DOyTwekg8BE8gScSt2W0Ws5YAKMA1P+5k1InVhd0 jCjGtwIMYC3sVBsAUELVBJf/8vsXkBDdmu7TzWkzflxXdfKDMMvOc/kK+FZibS+DK1aDJkeVMATqr6 zEiZFNvX2pup/pRpOWIpBgq7oN6fwSOEla2qYzTLlkMopabsqHZIH3f1VrHfvfCrTuXLsz9aZqFZ10 g8vbQ34H2YuV/I1wRr5HZ5cNfo+CQ6gCdn8wReig2RVVlE7fxZ6Z84Rbpo5nvzbqsakC+Dlr/AsnUD fFShg/hirsxNmggqkl8DPrqoFLxcsi X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749598833714756710?= X-GMAIL-MSGID: =?utf-8?q?1749598833714756710?= alloc_pwms() only identified a free range of IDs and this range was marked as used only later by pwmchip_add(). Instead let alloc_pwms() already do the marking (which makes the function actually allocating the range and so justifies the function name). This way access to the allocated_pwms bitfield is limited to two functions only. Signed-off-by: Uwe Kleine-König Reviewed-by: Andy Shevchenko --- drivers/pwm/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pwm/core.c b/drivers/pwm/core.c index 2338119a09d8..b43b24bd3c9f 100644 --- a/drivers/pwm/core.c +++ b/drivers/pwm/core.c @@ -51,6 +51,8 @@ static int alloc_pwms(unsigned int count) if (start + count > MAX_PWMS) return -ENOSPC; + bitmap_set(allocated_pwms, start, count); + return start; } @@ -297,8 +299,6 @@ int pwmchip_add(struct pwm_chip *chip) radix_tree_insert(&pwm_tree, pwm->pwm, pwm); } - bitmap_set(allocated_pwms, chip->base, chip->npwm); - INIT_LIST_HEAD(&chip->list); list_add(&chip->list, &pwm_chips);