From patchwork Tue Nov 15 17:17:09 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenXiaoSong X-Patchwork-Id: 20461 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2819492wru; Tue, 15 Nov 2022 08:19:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf4cx1gbV4e5uEnoInUPM9seQBIwRVBidUNKZL+xzNmju7x6kneFIbZ0qPdD5t/VQlSOrlfq X-Received: by 2002:a17:906:4d58:b0:781:bc28:f455 with SMTP id b24-20020a1709064d5800b00781bc28f455mr14295161ejv.170.1668529190434; Tue, 15 Nov 2022 08:19:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668529190; cv=none; d=google.com; s=arc-20160816; b=tEum+8PBvzqr/FghFwTOD75XzwFW4npWSx4opGZ1WtvsVmpE414GpI9LYRKxUA/ppt 2/t0eWz/9R/ePWvlacJ0JWbCqcGq1u8Yj/0zMbkPZcIuFaCuezYutAM7133XkJEROFsW j9XM8ijVCafBU/c3EbAR/xl9j3At+OUXqQ2nc5bzGuCd+yjozgtz3JhFsduZ650V1xyS hsDO91q7BFWlE0P3oiaIy/B/AMwjdUvKRrIdZ6WvU8yZ8pQE0LerkOe669pl+fA7GMPb fbJRngyuOE4NZZ9xbFqp1AITtKXvijhhBXO9Hs4wRm+/I1qzzUmqLgYsBqMRU5/aAW6X Dplg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Prj5yc69E/4s6WK2ZdbEMBmaQP1Vw7swPeVtvLWP0Rs=; b=WXh0TtYq7sYVUgt5S8AGWZpKpKS8jVFRKcU4BT/jNRcuK2RrDZ/uQDWQk6XEi7/Qpr 2Cj+XdpQOWQYlJs9tuJ6MD93VpZ8wA/SWBJiHSnDMUaZmWGmMr7A7EMV3MqyWnGMt70K ZC6A7beWj1RrR28zTZtlT1Sr+bDT4vQuRh8qvJQ3hcwPP8zMvr5GVWXDfv7z0BmPYGns oDgdw627nVwCcA7KB2DQYyNduZBfWTLLiutRkz8mCDoc9ozajNukhyZ+/IcRgtU50aFf OIBtGksrafYq2E2GG34v3d0ta71MpZy6HvP32AAyaFTW/DcicyRRTQd8EVN5tEAMlf18 I9Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q21-20020a50cc95000000b00462af00c12bsi10717629edi.398.2022.11.15.08.19.25; Tue, 15 Nov 2022 08:19:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238376AbiKOQMn (ORCPT + 99 others); Tue, 15 Nov 2022 11:12:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238109AbiKOQMi (ORCPT ); Tue, 15 Nov 2022 11:12:38 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AE0B2264AE; Tue, 15 Nov 2022 08:12:36 -0800 (PST) Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.57]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4NBWMp0BVszJnlH; Wed, 16 Nov 2022 00:09:26 +0800 (CST) Received: from kwepemm600015.china.huawei.com (7.193.23.52) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 00:12:33 +0800 Received: from huawei.com (10.175.101.6) by kwepemm600015.china.huawei.com (7.193.23.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 16 Nov 2022 00:12:32 +0800 From: ChenXiaoSong To: , , CC: , , , , , , Subject: [PATCH v4 3/3] btrfs: qgroup: fix sleep from invalid context bug in update_qgroup_limit_item() Date: Wed, 16 Nov 2022 01:17:09 +0800 Message-ID: <20221115171709.3774614-4-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20221115171709.3774614-1-chenxiaosong2@huawei.com> References: <20221115171709.3774614-1-chenxiaosong2@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To kwepemm600015.china.huawei.com (7.193.23.52) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749579664370045726?= X-GMAIL-MSGID: =?utf-8?q?1749579664370045726?= Syzkaller reported BUG as follows: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:274 Call Trace: dump_stack_lvl+0xcd/0x134 __might_resched.cold+0x222/0x26b kmem_cache_alloc+0x2e7/0x3c0 update_qgroup_limit_item+0xe1/0x390 btrfs_qgroup_inherit+0x147b/0x1ee0 create_subvol+0x4eb/0x1710 btrfs_mksubvol+0xfe5/0x13f0 __btrfs_ioctl_snap_create+0x2b0/0x430 btrfs_ioctl_snap_create_v2+0x25a/0x520 btrfs_ioctl+0x2a1c/0x5ce0 __x64_sys_ioctl+0x193/0x200 do_syscall_64+0x35/0x80 Fix this by delaying the limit item updates until unlock the spin lock. Signed-off-by: ChenXiaoSong --- fs/btrfs/qgroup.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index ca609a70d067..f84507ca3b99 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -2867,6 +2867,8 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, bool need_rescan = false; u32 level_size = 0; u64 nums; + bool update_limit = false; + int err; /* * There are only two callers of this function. @@ -2957,10 +2959,7 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, dstgroup->max_excl = inherit->lim.max_excl; dstgroup->rsv_rfer = inherit->lim.rsv_rfer; dstgroup->rsv_excl = inherit->lim.rsv_excl; - - ret = btrfs_update_quoto_limit(trans, dstgroup, fs_info); - if (ret) - goto unlock; + update_limit = true; } if (srcid) { @@ -2987,6 +2986,7 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, dstgroup->max_excl = srcgroup->max_excl; dstgroup->rsv_rfer = srcgroup->rsv_rfer; dstgroup->rsv_excl = srcgroup->rsv_excl; + update_limit = false; qgroup_dirty(fs_info, dstgroup); qgroup_dirty(fs_info, srcgroup); @@ -3055,6 +3055,11 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, unlock: spin_unlock(&fs_info->qgroup_lock); + if (update_limit) { + err = btrfs_update_quoto_limit(trans, dstgroup, fs_info); + if (err) + ret = err; + } if (!ret) ret = btrfs_sysfs_add_one_qgroup(fs_info, dstgroup); out: