From patchwork Tue Nov 15 14:39:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 20409 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2767424wru; Tue, 15 Nov 2022 06:42:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf6mghgyFVYrJlY8V3+/NblW0JRQhDYvhIHw3zc755TfMvq4UDvzBBmGzrKyONnJKP9Ts1TP X-Received: by 2002:aa7:cc91:0:b0:459:4c7:60d7 with SMTP id p17-20020aa7cc91000000b0045904c760d7mr15858999edt.175.1668523377753; Tue, 15 Nov 2022 06:42:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668523377; cv=none; d=google.com; s=arc-20160816; b=GaIggqYwLiVS/aa3huK7KUpGoLT9i5Xgq1Il8q4QuzyVaWegr+JDw5O2nXYSMuHgw1 VzFZV0EfI+XkFFCLafZ7GHb23leTR6WX2jxXhEhh+9qZ6QPJsjkEGo+Khimu1MocgxVT bBmfHIO44HXdAWZjy18MQVCBqLWgF1lxWakkalLTKe/dw8W7Is96yIDbNI7L4DqpS1Ti SP0Z6PLSU2zlc9RJWmb8UyRSfF+L0VtXoLQ1HZ51Gryl1MZAfYRa9tr1hy3xRolkvNbo CgPUy9so0IWSMeHaEqjdPbX0uL2UZH6pGEFQb2IVNJFwqMbUeeIQbK8X9IfGxAfqgZXz g1LQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oIcbow0NFIZSLOBcR7tW8qc+0vYTMTznFTSJh0o6BTY=; b=RKb4GDZa72lzop8HJZQsr1Jf2osm6KaietGQVggiUKwXbY0J4pmhxovh7QKME+UUzx 7VjkTIzWw8knvzJRuWjv/PO+a+kdvbLOMdWcW7MNPpbK28Tm0qMPiij1EXr4f8JFUlUT r3QwS6CqLF2nfBf1kuNeYpUrmPvU0ectkY0kgoB9+FjatRt5foX0zVPIdnmTq0eZO3r7 2AHou6Hr7BePtvB/4L8M0QkpnneZRWOLZLWhQBb9bHl8MxhNnJ3EQ+ycZYN0JKigN6qz j0ppIj0ifEzsISONRMrawdZrEhxTeIYYYvxZiJbsj0hQzV7qxc/qoa1L2Bq3qooxxrRh QLpg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hauROZjV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b68-20020a509f4a000000b00459f9c3d02bsi10398862edf.22.2022.11.15.06.42.31; Tue, 15 Nov 2022 06:42:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=hauROZjV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238095AbiKOOlf (ORCPT + 99 others); Tue, 15 Nov 2022 09:41:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232301AbiKOOk4 (ORCPT ); Tue, 15 Nov 2022 09:40:56 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF5B1FCDC; Tue, 15 Nov 2022 06:40:55 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 48DF6B8198D; Tue, 15 Nov 2022 14:40:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7393AC43157; Tue, 15 Nov 2022 14:40:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668523252; bh=WfOHBJjixJuQ4FLUSSwYNB6T5TOaxLa26wr1JxeAHYo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hauROZjV+aqnSa14og8RbAK/+bbgEzh1yaVnYpQ3ARkPzatWPOYoj1RKt9HUUKIlR /J9GfCuBg9Ku3L/wzNGeI/E2aEY8y5MnGU7v4sQUaIvafmH8OoF3XAjoGkonnuRdjf ckxbaN8pMAQXw1J0D4pXqhs/hZ/mecZ5L0jKaR1qWEV+dm2M6CSC5I9iwVzVYa/t7y aeqSNLcbrgbwI3lV++6H6R/BhqoBA6O6RnueaniMLcv6gtKGRoB1oU2tHICbmPClkA QHeeTRcuIZaHF4W8Xv41jaTqp3hBeiJIsySMb7luKjeZUSGajXl5XqD0gpD0co2IYa 0LR3g0BhXl71w== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1oux6t-0000fa-1o; Tue, 15 Nov 2022 15:40:23 +0100 From: Johan Hovold To: Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH v2 07/15] phy: qcom-qmp-combo: drop redundant clock allocation Date: Tue, 15 Nov 2022 15:39:57 +0100 Message-Id: <20221115144005.2478-8-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221115144005.2478-1-johan+linaro@kernel.org> References: <20221115144005.2478-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749573569511982578?= X-GMAIL-MSGID: =?utf-8?q?1749573569511982578?= Since the QMP driver split, there is no reason to allocate the fixed-rate pipe clock structure separately from the driver data. Reviewed-by: Dmitry Baryshkov Signed-off-by: Johan Hovold --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index ebfefecffd86..9b945a72ae9b 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -895,6 +895,7 @@ struct qmp_combo { unsigned int dp_aux_cfg; struct phy_configure_opts_dp dp_opts; + struct clk_fixed_rate pipe_clk_fixed; struct clk_hw dp_link_hw; struct clk_hw dp_pixel_hw; }; @@ -2239,15 +2240,11 @@ static void phy_clk_release_provider(void *res) */ static int phy_pipe_clk_register(struct qmp_combo *qmp, struct device_node *np) { - struct clk_fixed_rate *fixed; + struct clk_fixed_rate *fixed = &qmp->pipe_clk_fixed; struct clk_init_data init = { }; char name[64]; int ret; - fixed = devm_kzalloc(qmp->dev, sizeof(*fixed), GFP_KERNEL); - if (!fixed) - return -ENOMEM; - snprintf(name, sizeof(name), "%s::pipe_clk", dev_name(qmp->dev)); init.name = name; init.ops = &clk_fixed_rate_ops;