diff mbox series

[v5,3/3] ARM: dts: exynos: Add new SoC specific compatible string for Exynos3250 SoC

Message ID 20221114115024.69591-4-aakarsh.jain@samsung.com
State New
Headers
Series Add new compatible for Exynos3250 |

Commit Message

Aakarsh Jain Nov. 14, 2022, 11:50 a.m. UTC 
  Commit 752d3a23d1f68de ("ARM: dts: add MFC codec device node for
exynos3250") which adds MFC codec device node for exynos3250 SoC.
Since exynos3250.dtsi and exynos5420.dtsi are using same compatible
string as "samsung,mfc-v7" but their node properties are different.
As both SoCs have MFC v7 hardware module but with different clock 
hierarchy and complexity.
Add new compatible string followed by mfc-v7 fallback for Exynos3250
SoC.

Reviewed-by: Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Suggested-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
---
 arch/arm/boot/dts/exynos3250.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Nov. 15, 2022, 9:35 a.m. UTC | #1 
On Mon, 14 Nov 2022 17:20:24 +0530, Aakarsh Jain wrote:
> Commit 752d3a23d1f68de ("ARM: dts: add MFC codec device node for
> exynos3250") which adds MFC codec device node for exynos3250 SoC.

This sentence ends prematurely. I don't know what you wanted to say here, so I
dropped it.

> Since exynos3250.dtsi and exynos5420.dtsi are using same compatible
> string as "samsung,mfc-v7" but their node properties are different.
> As both SoCs have MFC v7 hardware module but with different clock
> hierarchy and complexity.
> Add new compatible string followed by mfc-v7 fallback for Exynos3250
> SoC.
> 
> [...]

Applied with changes to commit msg, thanks!

[3/3] ARM: dts: exynos: Add new SoC specific compatible string for Exynos3250 SoC
      https://git.kernel.org/krzk/linux/c/c9259e0d224b15a734673200e0825fae5ea2ab1e

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi
index 326b9e0ed8d3..a2d6ee7fff08 100644
--- a/arch/arm/boot/dts/exynos3250.dtsi
+++ b/arch/arm/boot/dts/exynos3250.dtsi
@@ -485,7 +485,7 @@ 
 		};
 
 		mfc: codec@13400000 {
-			compatible = "samsung,mfc-v7";
+			compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
 			reg = <0x13400000 0x10000>;
 			interrupts = <GIC_SPI 102 IRQ_TYPE_LEVEL_HIGH>;
 			clock-names = "mfc", "sclk_mfc";