From patchwork Mon Nov 14 11:43:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 19755 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2098177wru; Mon, 14 Nov 2022 03:49:19 -0800 (PST) X-Google-Smtp-Source: AA0mqf5Mzk00Z6oiikXHEcvrsiOBQjJUt88RbzNTSbF6Qan4i034IyPzHOhY72awlz5CLMRU4x5T X-Received: by 2002:a17:906:eca7:b0:7aa:6998:ad72 with SMTP id qh7-20020a170906eca700b007aa6998ad72mr10168522ejb.763.1668426558784; Mon, 14 Nov 2022 03:49:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668426558; cv=none; d=google.com; s=arc-20160816; b=KJv0fQcrhRgb0scmTNXPFCDpXTXqXpP7M8m+IUG6lB8jtWCTMdtZJpmYBZjnw4EZN2 8KCl0pZyJPrXU5WLEsQbDiAy6ujEBPTjqqbuqhHsx/AeLQTZQPNBsoue4V21KEXshmrG AOBFkgKoIXNr9pT3z+o2VggBPEpqAApzUoXTVwS6VvjRLaq/8txp2iH0zzUdz2eQfjvz PD+5UOAUZtUs5U+E+BZLepmyn0a4uOHIgByWEF1yE8+NIQOWMHN6hhZJ7a7oVkt0kkY4 NGrfVpVvzyjX5HXnB7/c7647uOAR+kuLnotRhATRqiSJ0KmRLMwkeM1LXOEl/1WYw9of i2aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=/BrU/y+CSSvNZcbm3qUhy1jSpabUUTyv+j7fBbKHBRM=; b=hdvWkuJQJbCfjPdw6v68a5hZ1d5QuSNJ85YkTDdcBTWO3NJLug3XldpDe3lcpcMsTq ZlB+a0L7ALyeuaQ0UPtIsx5GblisHNrVHasT+jWURH+j2V8aTtgt73e8Hzswn+giLdSy s9zpu/vE7JN6zRyHVWCpuzHAOfDGAMYKePsLw+hwxVBKcTfQw1bIhofxFJ491jO9mpac z6PD9/7scQJMMFuZHb9x+caBZe9ayEsMuMM+Tdl3QHO6ktx9p1dc70xPsqm0HODknP3s TSOQxMaquQr30ZQ8LK0lTprecU0VR1UfhH7xeiKNmCRRVo7avn3FRMbQmDSP6HVp9ci0 rPng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OA+g6g1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dm14-20020a170907948e00b0078d3b940ec5si521089ejc.373.2022.11.14.03.48.55; Mon, 14 Nov 2022 03:49:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=OA+g6g1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236781AbiKNLqu (ORCPT + 99 others); Mon, 14 Nov 2022 06:46:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236769AbiKNLqF (ORCPT ); Mon, 14 Nov 2022 06:46:05 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDCD523179 for ; Mon, 14 Nov 2022 03:45:03 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 81933B80E77 for ; Mon, 14 Nov 2022 11:45:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3997EC433D6; Mon, 14 Nov 2022 11:44:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668426301; bh=5FX1a1JgcDe4CO/FI8j/3+v36Volg7rloP622gTjs4c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=OA+g6g1OOecEy+y6VOPK3J54mGvMkQm2tYT6ZFbxX+0wGYJHWM01XYB/5x9ld9PVo ktQcoiU9YUeFjxsllBKPobxgacW1tr1IHrVPZsiXK8EjBpyZvTtFrjM5G5dCk4x8HZ nc88qy7GvW16gdXTeBP4dZuKahL4Kr5aCEgo/L/GJirF85Y7RtvE3uyW/YtCECZ8Lr 01J3///gSOype8s079CsWY2X0rJMO1TSSGscywo63cbm0Jp6GtaC+Qd5PHI4hW1A9Q 828gJx3mCuVbH1A/6dw/5GGVj3d6bol7osArPmK8EJ1BAdoJMqnpdJWjNVVer16h8v sFHNuPR0rd9Vw== From: "Jiri Slaby (SUSE)" To: linux-kernel@vger.kernel.org Cc: Jiri Slaby , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , x86@kernel.org, Martin Liska Subject: [PATCH 26/46] x86/apic, lto: Mark apic_driver*() as __noreorder Date: Mon, 14 Nov 2022 12:43:24 +0100 Message-Id: <20221114114344.18650-27-jirislaby@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221114114344.18650-1-jirislaby@kernel.org> References: <20221114114344.18650-1-jirislaby@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749472047452030799?= X-GMAIL-MSGID: =?utf-8?q?1749472047452030799?= From: Jiri Slaby The apic code assumes that the apic drivers are in a particular order in memory. gcc LTO can violate this. So add __noreorder to apic_driver() and apic_drivers() to avoid a boot BUG(). Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: Dave Hansen Cc: "H. Peter Anvin" Cc: x86@kernel.org Cc: Martin Liska Signed-off-by: Jiri Slaby --- arch/x86/include/asm/apic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h index 3415321c8240..9c5c69482ab0 100644 --- a/arch/x86/include/asm/apic.h +++ b/arch/x86/include/asm/apic.h @@ -363,12 +363,12 @@ extern struct apic *apic; * to enforce the order with in them. */ #define apic_driver(sym) \ - static const struct apic *__apicdrivers_##sym __used \ + static const struct apic *__apicdrivers_##sym __used __noreorder \ __aligned(sizeof(struct apic *)) \ __section(".apicdrivers") = { &sym } #define apic_drivers(sym1, sym2) \ - static struct apic *__apicdrivers_##sym1##sym2[2] __used \ + static struct apic *__apicdrivers_##sym1##sym2[2] __used __noreorder \ __aligned(sizeof(struct apic *)) \ __section(".apicdrivers") = { &sym1, &sym2 }