From patchwork Mon Nov 14 11:43:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 19756 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2098226wru; Mon, 14 Nov 2022 03:49:27 -0800 (PST) X-Google-Smtp-Source: AA0mqf7btBFrvjmahrLkQ/D6VudeR2Td2ixpnCgSgKzA3s9Z/jeqH/fdYDrPRwk6fi3Vj7868ZSQ X-Received: by 2002:aa7:d803:0:b0:467:67e1:ca61 with SMTP id v3-20020aa7d803000000b0046767e1ca61mr10188203edq.27.1668426567322; Mon, 14 Nov 2022 03:49:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668426567; cv=none; d=google.com; s=arc-20160816; b=UF/RGwvXLKwxsF1KnlvCqvRsZHbZUd++XPTfnZ2yXyuKloF4Wh0wWZ6jogfFHSjq9S KPWHp1NOgRmLSS9nKn3lv57cTc28O/WnfkA8TRw8wyhH/JCEu8OUNP4Xb+BcnHji1lNJ gSFsZLb4AwZrEwDpzMoxXNdiQfRKIZKzJ3zOPXWxVvnZGvcQwdkkKxqpfEEiAMjx8RI1 nsNelukTlmatTyGgl41/Eucz0YjE72KoZ8zamaSCS6sGb4LRfgojnsc/opr9nrcJbm4c F3KVr1zoxA9+yrtwTyml1+538iihHmQUqYn3aWGgqsTSSt+vkLrNNj9963kGR54/ieOw IU5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=8y6sOVxlBHMizTVtMSfPfoz1iFFwRdL5g3Bh4Z03K4Y=; b=LVBTNIArtHOtTfSOyfrSt7mkN3ui3vDozSV+aezIJuRpo5QZWEaNtn0eIvMl0Jkt3e RgVrm2sa4AUVkULr5b/JPr93w8t8vZb/XdY7dHLa7XPP+qiyAk37iyvjIQUpXyr+qV16 TcELaGh5nKE//DmSqorSu8p51sQTatCHvtvTkQofmCIYmHUUW0EJqCjIHiGLLVKhaEaE iOOWU/+hpWuxyabKLKzTyngy1VJrUyQeUmq4DyLmVgs6LkGd75WJEl/nkVEGo2Mh0Qpv 8g9RhlZMCdKP2YQfQd7VyeB14XYS98X8M5SBE92V0xaTV6rgvjyGlWABoTgMs/dghhi5 uxOg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q0s1lYPl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w10-20020aa7cb4a000000b00463c5c32c65si7937080edt.457.2022.11.14.03.49.04; Mon, 14 Nov 2022 03:49:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=q0s1lYPl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236758AbiKNLpr (ORCPT + 99 others); Mon, 14 Nov 2022 06:45:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236666AbiKNLpQ (ORCPT ); Mon, 14 Nov 2022 06:45:16 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F055222BA for ; Mon, 14 Nov 2022 03:44:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AD35E61029 for ; Mon, 14 Nov 2022 11:44:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10ED3C433D7; Mon, 14 Nov 2022 11:44:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668426281; bh=Vpg6dWTArUNw6H1lp7TcQixC3uvVmofgAH+VJ8M/i8U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q0s1lYPlaouNk03bC26jwsoY4uhDQn4c/yiJljQW+qknmxh2wfkw8UMc4xzmdLbwb 8EK/BGDTUVjnZgsMyONGcULwuWqCX3z31MbWTfr51XDNW9qiS3m8STiTX5QB16N2E/ vGQ3IL2EqJ1dc3MJ6AVlp6V/yqwWHyZCn/hTlDsL+x1v9O9ZO6RGXaD6SUr8lX5cwH Qoy/f7mfPdppxhBeD0rz6ra4XwgbgfkzkVaAatAIY7IUdoMD5hruELQaEXTVWdoTQN fC8SpRDcxbqjzrelOgX31DQsloDxNfNW+OWanKD/bo0A1q3yV72l6aAXPdpjh+L4bL JKJd/i3tYjV5Q== From: "Jiri Slaby (SUSE)" To: linux-kernel@vger.kernel.org Cc: Andi Kleen , Martin Liska , Jiri Slaby Subject: [PATCH 19/46] export, lto: Mark __kstrtab* in EXPORT_SYMBOL() as global and __visible Date: Mon, 14 Nov 2022 12:43:17 +0100 Message-Id: <20221114114344.18650-20-jirislaby@kernel.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221114114344.18650-1-jirislaby@kernel.org> References: <20221114114344.18650-1-jirislaby@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749472056145384029?= X-GMAIL-MSGID: =?utf-8?q?1749472056145384029?= From: Andi Kleen Symbols referenced from assembler (either directly or e.f. from DEFINE_STATIC_KEY()) need to be global and visible in gcc LTO because they could end up in a different object file than the assembler. This can lead to linker errors without this patch. So mark __kstrtab_*[] and __kstrtabns_*[] symbols as global and __visible. Signed-off-by: Andi Kleen Signed-off-by: Martin Liska Signed-off-by: Jiri Slaby --- include/linux/export.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/export.h b/include/linux/export.h index 3f31ced0d977..3cb5f85327da 100644 --- a/include/linux/export.h +++ b/include/linux/export.h @@ -85,11 +85,13 @@ struct kernel_symbol { */ #define ___EXPORT_SYMBOL(sym, sec, ns) \ extern typeof(sym) sym; \ - extern const char __kstrtab_##sym[]; \ - extern const char __kstrtabns_##sym[]; \ + extern const char __visible __kstrtab_##sym[]; \ + extern const char __visible __kstrtabns_##sym[]; \ asm(" .section \"__ksymtab_strings\",\"aMS\",%progbits,1 \n" \ + " .globl __kstrtab_" #sym " \n" \ "__kstrtab_" #sym ": \n" \ " .asciz \"" #sym "\" \n" \ + " .globl __kstrtabns_" #sym " \n" \ "__kstrtabns_" #sym ": \n" \ " .asciz \"" ns "\" \n" \ " .previous \n"); \