Message ID | 20221114015749.28490-2-samuel@sholland.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1915700wru; Sun, 13 Nov 2022 17:59:52 -0800 (PST) X-Google-Smtp-Source: AA0mqf4UTFecGPCmYQRL0sUo7RmCBk2xQE+EIC0DG7GkC5e8ctZ0JkZWvmU0353Unvrkuzlx/T/l X-Received: by 2002:aa7:d3da:0:b0:460:9994:1b9b with SMTP id o26-20020aa7d3da000000b0046099941b9bmr9207932edr.155.1668391192169; Sun, 13 Nov 2022 17:59:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668391192; cv=none; d=google.com; s=arc-20160816; b=lGXaFjsh8z/hT1XNzfqO32Mllp1Atu/z4JNP/6qTYX+T3UGEYpqUhHsIy84QUjWlLK B2aSd/LNolGZrYty29A3TFCODk3BbPvPsSIUA1btsSSxfhxD+adk4Wnwj0rgd3kLBLUs +wIiGdTkSVUA2w8zrz8/K1NxRCn+llEkKXdncq/5Mwq2EYUTydd2VMJzqaxIZef96BB5 0sB3jWRRQ3+YDS5vfl39VLS+s5rFPXCB8aoBX+U7Q5rYG6Z2Il0l3nDpsFPYsRJpOQnu ZDRRaW+akWSNqvb0+XCtEzDSO4DkLy1VqW5rv3fUWMSd0JaRpjQ88ud4E7NpwWfKUKWr KbKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :feedback-id:dkim-signature:dkim-signature; bh=E9uIAIxUjiZh/NqdAFhxdQQd6pb0o+DNnALIZuHYHOs=; b=VmcUr1s7x1SUzx/Ne99CmxDDO2ibQ7tPUhIf6bPBfJOj91cPFxxihKmf//8QYFOUj8 f5k8hzQlGOiUzf/K3v30zkL8tGJokm4Nfis4+iuPz9yNXe9RzJ49+QCTBG5tONKNW8NY vayZLrMN7t66fZSF9uMgj0gHb241buJV2d5uFsRHiIKa8qptwJAvd8Fpg1cMRYJQS/Yh /MVYEs2GKV6SfbuO2YbZC2enZwVt5LHqHfXv/36mpXdplhCZT4+3x6eItHWd57deAo0u d+IG5yPIK9vlUnmorM6qk6FFPxzwmAIN0fxiOZjFDDP/uItzDcuPne+863GZhV6WWBK+ Ejbw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sholland.org header.s=fm2 header.b="OfbZpT/d"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=tKxDvCrO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o12-20020a170906860c00b007ae37a89b5bsi5633453ejx.601.2022.11.13.17.59.29; Sun, 13 Nov 2022 17:59:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sholland.org header.s=fm2 header.b="OfbZpT/d"; dkim=pass header.i=@messagingengine.com header.s=fm1 header.b=tKxDvCrO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=sholland.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235431AbiKNB6K (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Sun, 13 Nov 2022 20:58:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235752AbiKNB57 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 13 Nov 2022 20:57:59 -0500 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 133DDDF7E for <linux-kernel@vger.kernel.org>; Sun, 13 Nov 2022 17:57:55 -0800 (PST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 982523200913; Sun, 13 Nov 2022 20:57:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 13 Nov 2022 20:57:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1668391073; x=1668477473; bh=E9 uIAIxUjiZh/NqdAFhxdQQd6pb0o+DNnALIZuHYHOs=; b=OfbZpT/d/nCucpY8If Ivz1X1vBDXH5hM0CnqfATv4F0RBYtu3ri+xhPjSNzqa6EVAS74FI5DGhJUnMeZtB prKBAR2MBPoqmVT0h+90mRc+Mu1HCp7lo+S4WWyP3Hhse8FXmWl0ZhSxLd1xiygS Kcw6lsupErjYf9B3lEZoF3wekUSWiO+qdPwoEPUzOxC/jaQPviZXpjIxJ3F3MBVl qdt0892WkXxgGonzlOIezXS6MtB5Na6rdMy4MhL7yPDRlkvEiPGNVeDOHoMbTDuR 43nLOPeS35A0oGcRhmY41jC5xCHygNqBuNOkZllpLGoiRWg/H1UrWsvyqqkqHMEw 9oCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1668391073; x=1668477473; bh=E9uIAIxUjiZh/ NqdAFhxdQQd6pb0o+DNnALIZuHYHOs=; b=tKxDvCrOnkcyDpWUGhUNVe+DjapTA +CI67IjdnEL+FPgyZ+uw3EbJFtY/pOT+MinYhI+WcRatng9gUZE7vlKnux+wQ7Hs AbQy5u1cGG0s5lJ5ktUzKTYfDwgwaEJ7VUF0A0kLzCELBiZ2vNJVln3lnCRBfvn/ 5gJHzsxRzy86xshLtvXABOHKe0+VIe2NAMJU/VeMDwTFEj0PYYjbDvKo00M8o2tG Gof4nKZvZUn78y6SNqlcN/hRAUai/4lkRSIzQ2fk2TB3W6yt6anWZR5MRbO3DVqj mONBzyqyHlkLr8gIDvi6SUaxwCXBnPBvzaJpXnZRE0Mgc7WJJkfPHksuA== X-ME-Sender: <xms:oaBxYyzX8n4jkVtSziMogRwxt3wOm4Bi5cJ_Nw7pqmf3mR5pS0ifQg> <xme:oaBxY-RBPQdcNJcGi-W6VQbiGSLVZRgFH4Te9JCYl5fvtZ3TQDOKv48V6TgRRqQrC SOguGjskzmVKY0arA> X-ME-Received: <xmr:oaBxY0U-2ItKgjgFBPEBHjkEcQWVPhtdIn9g6ImJYIyiMG4ZMWRe1hne_7u7wCH6-NILOj0vvELQT_KeVCx2TtUCbZJ0YKBKpLgikPfN8wDGMaaoDjRZcybFWPVEYc4nltxMmA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrgedugdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefurghmuhgv lhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenucggtf frrghtthgvrhhnpedukeetueduhedtleetvefguddvvdejhfefudelgfduveeggeehgfdu feeitdevteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: <xmx:oaBxY4jtg1V_8juU0A0-CMfelEQ3tbsmgzbh8Cwiwf4-FqLLm8V-jw> <xmx:oaBxY0AXOBbcdR6Y_ptc9t1V8MlpAGLjPQ4jus5aOCITwtuq8GIdwg> <xmx:oaBxY5ICrEogovIkMma7RrKVY9Gf9_Oto-EFklQaSkT4kLJg31kF4g> <xmx:oaBxY21ftMx1vY0nX7hJ5sfgAqaLU4Xe1craM-aTSGY9FV5otsDltg> Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 13 Nov 2022 20:57:52 -0500 (EST) From: Samuel Holland <samuel@sholland.org> To: Chen-Yu Tsai <wens@csie.org>, Jernej Skrabec <jernej.skrabec@gmail.com> Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Andre Przywara <andre.przywara@arm.com>, Samuel Holland <samuel@sholland.org> Subject: [PATCH v3 1/3] bus: sunxi-rsb: Remove the shutdown callback Date: Sun, 13 Nov 2022 19:57:47 -0600 Message-Id: <20221114015749.28490-2-samuel@sholland.org> X-Mailer: git-send-email 2.37.3 In-Reply-To: <20221114015749.28490-1-samuel@sholland.org> References: <20221114015749.28490-1-samuel@sholland.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749434963007189238?= X-GMAIL-MSGID: =?utf-8?q?1749434963007189238?= |
Series |
bus: sunxi-rsb: Fix poweroff issues
|
|
Commit Message
Samuel Holland
Nov. 14, 2022, 1:57 a.m. UTC
Shutting down the RSB controller prevents communicating with a PMIC inside pm_power_off(), since that gets called after device_shutdown(), so it breaks system poweroff on some boards. Reported-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Tested-by: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com> Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com> Fixes: 843107498f91 ("bus: sunxi-rsb: Implement suspend/resume/shutdown callbacks") Signed-off-by: Samuel Holland <samuel@sholland.org> --- Changes in v3: - Adjust patch 1 commit message drivers/bus/sunxi-rsb.c | 9 --------- 1 file changed, 9 deletions(-)
diff --git a/drivers/bus/sunxi-rsb.c b/drivers/bus/sunxi-rsb.c index 4cd2e127946e..17343cd75338 100644 --- a/drivers/bus/sunxi-rsb.c +++ b/drivers/bus/sunxi-rsb.c @@ -812,14 +812,6 @@ static int sunxi_rsb_remove(struct platform_device *pdev) return 0; } -static void sunxi_rsb_shutdown(struct platform_device *pdev) -{ - struct sunxi_rsb *rsb = platform_get_drvdata(pdev); - - pm_runtime_disable(&pdev->dev); - sunxi_rsb_hw_exit(rsb); -} - static const struct dev_pm_ops sunxi_rsb_dev_pm_ops = { SET_RUNTIME_PM_OPS(sunxi_rsb_runtime_suspend, sunxi_rsb_runtime_resume, NULL) @@ -835,7 +827,6 @@ MODULE_DEVICE_TABLE(of, sunxi_rsb_of_match_table); static struct platform_driver sunxi_rsb_driver = { .probe = sunxi_rsb_probe, .remove = sunxi_rsb_remove, - .shutdown = sunxi_rsb_shutdown, .driver = { .name = RSB_CTRL_NAME, .of_match_table = sunxi_rsb_of_match_table,