From patchwork Sun Nov 13 18:07:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 19389 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1780989wru; Sun, 13 Nov 2022 10:09:58 -0800 (PST) X-Google-Smtp-Source: AA0mqf6rv6KiH4+X8ZwxSz/LYoWipePc9Gj9J+/ubUy8UwApVog3Bs/57AQlDBNYUKCtml8PQWr2 X-Received: by 2002:a17:906:6acc:b0:7a8:10d7:a420 with SMTP id q12-20020a1709066acc00b007a810d7a420mr7951237ejs.746.1668362998514; Sun, 13 Nov 2022 10:09:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668362998; cv=none; d=google.com; s=arc-20160816; b=FmwznJYlVn5c630ap2qGSlSGliIzv/hwfrDB+VAe5e0P+Kqwj0Q2pRKtKfYZPqoX6z tmwnQFBdchyvse5YZ+tEbWJnKbXe6WmslQJmaWxvPWGWFt9L2GYD7owtrbrr7WIqVmyy F7MU+x258xDqCRThRcyyR8aQ039Dm011eX9jcwCslxkJCxwabgE2wz0A4UOgn+vHdcpw /sfAi0SLte3lpavCSzMyUKlFCVTXpSivYRrf4VDS31iHYnhPVu4hOJtQkMPiqX+BK7C6 36DKHa2unjkhDPsI+oCTPg+8DKN8QpiFBHtpRhhA9YisEOWdwnocyoU1hHrsRt0GY0x8 icSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=i9rY57aH7I24rE4lreigisIrtzpJlcbzkFokeDM/SUE=; b=AdwbfBiYvAi8pOzy5RjW6I64ypZNC66vpzPhtkpFS8CNQfBn82XWsNDc9ROBAGCtaR pBcQHUfJ3zh6wv029bUur1XVAl7cX8xC5rCN7oSdTbEIIHZ34QjNTfqbaoaRm3jm92x7 Wbxap2jwsbpusG4ipQs5kLEvq4c2UorKZE0vE+hy+h8xvZKIfHrU98rsBxgEGKbB6jwh jbi+GV/um5g1BQ1BB6VSttSkSlnvIl0KQsb9ND6av/WpDLIYnH4JFt+5MZvTi3SwB3Cm T0ETvqdAwfM+icFK2REbuWep8MGacyIafZX3kC08YSQ8FNT2gRs+znE8vypSGPSL4e5w clfA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=pFemdqI3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s2-20020a1709062ec200b0078dc5b2b6c4si5407112eji.666.2022.11.13.10.09.34; Sun, 13 Nov 2022 10:09:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=pFemdqI3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235425AbiKMSH2 (ORCPT + 99 others); Sun, 13 Nov 2022 13:07:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235274AbiKMSHW (ORCPT ); Sun, 13 Nov 2022 13:07:22 -0500 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E89E11455 for ; Sun, 13 Nov 2022 10:07:21 -0800 (PST) Received: by mail-ej1-x630.google.com with SMTP id i10so14731287ejg.6 for ; Sun, 13 Nov 2022 10:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i9rY57aH7I24rE4lreigisIrtzpJlcbzkFokeDM/SUE=; b=pFemdqI3NCKH94vulxhf/vdZTI0Gvuta3r5dUkx3e55XLXOzWd/aFw+aDTHduuYbna D7BGe6sBzXKmd4iwIKdux2WoUg1Bjq9ernlR9knxV8NDbuNhKOxanKETi3KFW0n47gKn MUH2G9SO+q0qZQES6vIbNXsL61weGlblneq9k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i9rY57aH7I24rE4lreigisIrtzpJlcbzkFokeDM/SUE=; b=Ct6tNd+X+vii/Y8y5wWYJMTwXdoiSSO2oHm0GdzswtidrM/6HJ7AbLZ888D0k2ZvWL nBT7TCTdLPK5PX8thBYLuGpGaRuhkHh2gA+kw9/m5ZvGlfKooSJOHRilgCLVLEuMFth6 T0CsDoUi3+aV7Ay0ZazKkfrWPHHX+fVzlnmzEpIbzDgetojP7Xjv/anB1b0mbUvUTXgz Hmh8moSsGVqDBWqF15V7C030rz9a1Q41aF6yIZBtMZKc3Vyiu8pj3tGPx+C1XDzTCmEl IE2PKasPW16JuPK4fp0UUivl1BQWS1OIbga7sJR3PZCwypeECxq1TMcelgRh6KWSkIFm g8DA== X-Gm-Message-State: ANoB5pndmmMdI8crTlrRzo/A39VSSEB3IcOmkWAVIQSJdysdNv+wGsYY 9MdfrNqgQ3zFrqgtpRs5xj1VwjCq25u8GA== X-Received: by 2002:a17:907:9d03:b0:7ae:87ef:d9a6 with SMTP id kt3-20020a1709079d0300b007ae87efd9a6mr8139536ejc.397.1668362839685; Sun, 13 Nov 2022 10:07:19 -0800 (PST) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-79-40-103-33.business.telecomitalia.it. [79.40.103.33]) by smtp.gmail.com with ESMTPSA id n11-20020a170906118b00b007a8de84ce36sm3171058eja.206.2022.11.13.10.07.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Nov 2022 10:07:19 -0800 (PST) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: linux-amarula@amarulasolutions.com, michael@amarulasolutions.com, Dario Binacchi , Abel Vesa , Anson Huang , Fabio Estevam , Michael Turquette , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Stephen Boyd , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: [PATCH 2/5] clk: imx: replace osc_hdmi with dummy Date: Sun, 13 Nov 2022 19:07:07 +0100 Message-Id: <20221113180710.1625410-3-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20221113180710.1625410-1-dario.binacchi@amarulasolutions.com> References: <20221113180710.1625410-1-dario.binacchi@amarulasolutions.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749405399350980642?= X-GMAIL-MSGID: =?utf-8?q?1749405399350980642?= There is no occurrence of the hdmi oscillator in the reference manual (document IMX8MNRM Rev 2, 07/2022). Further, if we consider the indexes 76-81 and 134 of the "Clock Root" table of chapter 5 of the RM, there is no entry for the source select bits 101b, which is the setting referenced by "osc_hdmi". Fix by renaming "osc_hdmi" with "dummy", a clock which has already been used for missing source select bits. Tested on the BSH SystemMaster (SMM) S2 board. Fixes: 96d6392b54dbb ("clk: imx: Add support for i.MX8MN clock driver") Signed-off-by: Dario Binacchi --- drivers/clk/imx/clk-imx8mn.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/clk/imx/clk-imx8mn.c b/drivers/clk/imx/clk-imx8mn.c index 72f9563a0ff6..0fae97e61e2c 100644 --- a/drivers/clk/imx/clk-imx8mn.c +++ b/drivers/clk/imx/clk-imx8mn.c @@ -108,27 +108,27 @@ static const char * const imx8mn_disp_pixel_sels[] = {"osc_24m", "video_pll1_out "sys_pll3_out", "clk_ext4", }; static const char * const imx8mn_sai2_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_sai3_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_sai5_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext2", "clk_ext3", }; static const char * const imx8mn_sai6_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_sai7_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext3", "clk_ext4", }; static const char * const imx8mn_spdif1_sels[] = {"osc_24m", "audio_pll1_out", "audio_pll2_out", - "video_pll1_out", "sys_pll1_133m", "osc_hdmi", + "video_pll1_out", "sys_pll1_133m", "dummy", "clk_ext2", "clk_ext3", }; static const char * const imx8mn_enet_ref_sels[] = {"osc_24m", "sys_pll2_125m", "sys_pll2_50m",