From patchwork Sun Nov 13 07:09:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shang XiaoJing X-Patchwork-Id: 19304 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1576284wru; Sat, 12 Nov 2022 23:12:33 -0800 (PST) X-Google-Smtp-Source: AA0mqf4iEBPhyBvan5mZJaTdQ2ZkSyHPP2vz4Lq5rhI3XO5vOkTqrniOE6BzW9ADFIAZVxDkaQam X-Received: by 2002:a17:906:6042:b0:7ae:f439:320c with SMTP id p2-20020a170906604200b007aef439320cmr972400ejj.452.1668323553454; Sat, 12 Nov 2022 23:12:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668323553; cv=none; d=google.com; s=arc-20160816; b=jbVir1YLunnvei0Y2ZWQj/Qk90EkU/8WMjm2ExlXC7/Nh3DFwhTcLbSzhRKBwHznXs YckAPfJKl6ZkljJI4+NSJiOKnzdDjzEjLrKwRLZbSXs8rs/zqOd1r9kAIdTO+J5hfzte VwNfl3KhT+i1truMQbu7ZrvIkkWQJHJ+CNnGgGJasEHm2wxwSsTo/GX5z5oaQkcoPFHS yaSQ29QFtP0Ama+JADJbT7ep7zq5f8IJdpP71VxXXSqQ62anxw0vrwOaXYZtUDaDGT7r ueLVurpWnPLWedult+ujUTr2/5/G/cAj1WHRy7jAXu/lSOERoqyp/KVlAp/Qcc9KMN1f JsYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=NZ5EOH/YzsRN9tEafrH9F5KNurYHSpQbQZ7H2geBXeM=; b=x8egtWgAHJrcKlt+QR7JKQvrs9i3OqIYiLzcsYvq1z4I1Kfd4BV1QfKK4LmCg+wR8n ZSRaowfW90Z10f76477U6pv5+u+GPWdW5X0bNiDxtRyNB8YioJbQ8YvObk0YL9vUnsBc VveuuL+lp9jfqUtwFvxkoi5YtjHizhF6sG6pInJoszmwL2muzVAFTYUTzBpkl9VVy9qN r4oIR46XoeZfGNVimzFo/UsSuht8ccI1Gvdy2vhDjD5cG0do6dtSQTpC5bbrxA/9NTFg wL0sxSclOtueom3WEfWOrWac7uh8Aa4JbpcC116I8fDATVE0cTV2pWCSwe41m2+ALkIU uIGA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hp17-20020a1709073e1100b007a7d37e4681si6096111ejc.845.2022.11.12.23.12.10; Sat, 12 Nov 2022 23:12:33 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235138AbiKMHKy (ORCPT + 99 others); Sun, 13 Nov 2022 02:10:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231252AbiKMHKw (ORCPT ); Sun, 13 Nov 2022 02:10:52 -0500 Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 495F9D2D1 for ; Sat, 12 Nov 2022 23:10:50 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.54]) by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4N93Rf5522zJn1g; Sun, 13 Nov 2022 15:07:42 +0800 (CST) Received: from huawei.com (10.175.100.227) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 13 Nov 2022 15:10:47 +0800 From: Shang XiaoJing To: , , , , CC: Subject: [PATCH v2 1/2] tracing: Fix memory leak in test_gen_synth_cmd() and test_empty_synth_event() Date: Sun, 13 Nov 2022 15:09:19 +0800 Message-ID: <20221113070920.26236-2-shangxiaojing@huawei.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20221113070920.26236-1-shangxiaojing@huawei.com> References: <20221113070920.26236-1-shangxiaojing@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.100.227] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749364038254761455?= X-GMAIL-MSGID: =?utf-8?q?1749364038254761455?= test_gen_synth_cmd() only free buf in fail path, hence buf will leak when there is no failure. Add kfree(buf) to prevent the memleak. The same reason and solution in test_empty_synth_event(). unreferenced object 0xffff8881127de000 (size 2048): comm "modprobe", pid 247, jiffies 4294972316 (age 78.756s) hex dump (first 32 bytes): 20 67 65 6e 5f 73 79 6e 74 68 5f 74 65 73 74 20 gen_synth_test 20 70 69 64 5f 74 20 6e 65 78 74 5f 70 69 64 5f pid_t next_pid_ backtrace: [<000000004254801a>] kmalloc_trace+0x26/0x100 [<0000000039eb1cf5>] 0xffffffffa00083cd [<000000000e8c3bc8>] 0xffffffffa00086ba [<00000000c293d1ea>] do_one_initcall+0xdb/0x480 [<00000000aa189e6d>] do_init_module+0x1cf/0x680 [<00000000d513222b>] load_module+0x6a50/0x70a0 [<000000001fd4d529>] __do_sys_finit_module+0x12f/0x1c0 [<00000000b36c4c0f>] do_syscall_64+0x3f/0x90 [<00000000bbf20cf3>] entry_SYSCALL_64_after_hwframe+0x63/0xcd unreferenced object 0xffff8881127df000 (size 2048): comm "modprobe", pid 247, jiffies 4294972324 (age 78.728s) hex dump (first 32 bytes): 20 65 6d 70 74 79 5f 73 79 6e 74 68 5f 74 65 73 empty_synth_tes 74 20 20 70 69 64 5f 74 20 6e 65 78 74 5f 70 69 t pid_t next_pi backtrace: [<000000004254801a>] kmalloc_trace+0x26/0x100 [<00000000d4db9a3d>] 0xffffffffa0008071 [<00000000c31354a5>] 0xffffffffa00086ce [<00000000c293d1ea>] do_one_initcall+0xdb/0x480 [<00000000aa189e6d>] do_init_module+0x1cf/0x680 [<00000000d513222b>] load_module+0x6a50/0x70a0 [<000000001fd4d529>] __do_sys_finit_module+0x12f/0x1c0 [<00000000b36c4c0f>] do_syscall_64+0x3f/0x90 [<00000000bbf20cf3>] entry_SYSCALL_64_after_hwframe+0x63/0xcd Fixes: 9fe41efaca08 ("tracing: Add synth event generation test module") Signed-off-by: Shang XiaoJing --- changes in v2: - adjust code for clean. --- kernel/trace/synth_event_gen_test.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/kernel/trace/synth_event_gen_test.c b/kernel/trace/synth_event_gen_test.c index 0b15e975d2c2..8d77526892f4 100644 --- a/kernel/trace/synth_event_gen_test.c +++ b/kernel/trace/synth_event_gen_test.c @@ -120,15 +120,13 @@ static int __init test_gen_synth_cmd(void) /* Now generate a gen_synth_test event */ ret = synth_event_trace_array(gen_synth_test, vals, ARRAY_SIZE(vals)); - out: + free: + kfree(buf); return ret; delete: /* We got an error after creating the event, delete it */ synth_event_delete("gen_synth_test"); - free: - kfree(buf); - - goto out; + goto free; } /* @@ -227,15 +225,13 @@ static int __init test_empty_synth_event(void) /* Now trace an empty_synth_test event */ ret = synth_event_trace_array(empty_synth_test, vals, ARRAY_SIZE(vals)); - out: + free: + kfree(buf); return ret; delete: /* We got an error after creating the event, delete it */ synth_event_delete("empty_synth_test"); - free: - kfree(buf); - - goto out; + goto free; } static struct synth_field_desc create_synth_test_fields[] = {