From patchwork Sun Nov 13 03:30:22 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 19287 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1534617wru; Sat, 12 Nov 2022 20:03:28 -0800 (PST) X-Google-Smtp-Source: AA0mqf5hOjSRRzUofym2TwXmBKJItR2rU/FRvxENF6OmSAjxqQwpuNLUjoNc1HDHdFOvrQpW6lnB X-Received: by 2002:a17:907:9a85:b0:7ad:b45c:dbca with SMTP id km5-20020a1709079a8500b007adb45cdbcamr6800247ejc.388.1668312207836; Sat, 12 Nov 2022 20:03:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668312207; cv=none; d=google.com; s=arc-20160816; b=L8rjVu+Xk8Ue+Bqbx2iB5jBBEyH70uYqkizca9XJBQU4+Lw8quD7zqNk5l2ikgZqyV 1cQGyENxG4ZLvH2wM4ipzLtdehhhFnN5GGn+2bJWYuhGG6musuKnjGeA0FO98Ukr92iB eYPvY+bCKr3674IOaaZNdb7KqkviyuS1G/Ou3si3g8Y175fEynyzSa8uDlRnRSamOM0w qvjl1FaeU3/8zSjRjGlcFGm4xB7S7J/m+m9bZJ40Xxf2SRuiwH9+pVqXRg1VeWwFrfAE lAwmfrkGXhco1+HMO4/npyLun4dUXtxgOYpl1SPAzMwLuPtzSFNCPEqMV71U43RcJmtv Da8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:dkim-signature:from; bh=IsZDhBAzGtnfSJhErRIZ9p76983WmikXsHOZP+0NC18=; b=LRb7ERK1ZLoFG2ad+pb814dMKRI2KW/VeMFOQeHRB8S4iPFlpcqoEhe1A7eqFhaEoL /Zu5QEsudWKtzEN2+22B9f6uE18kTc+aDeKOqfW63W1/gAdgHvSYFabRNTz4MR8zDNTB vfbgf6x+Qy/nioA1vm9JswCFnogzE6ClbUVeBKBh0pAfq0hr+RC9zLsZVchv6by1zmvg IbrFyfUCAg/+xjAfY4pfqkBRT55g8V1nQN/h3DCD8LJfXlV4WZvoa6POtR7q1l43VtVf za43K4MY+nf3ReVUSXUHPwS1RAJDIz9NBYBG6yaLL7xNMlbgh65ziBTG+C0F0WbgeOQ/ cZTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=b+WhP7YA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id js21-20020a17090797d500b0078ddff4b3absi6967198ejc.423.2022.11.12.20.02.52; Sat, 12 Nov 2022 20:03:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b=b+WhP7YA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235127AbiKMDal (ORCPT + 99 others); Sat, 12 Nov 2022 22:30:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbiKMDai (ORCPT ); Sat, 12 Nov 2022 22:30:38 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [IPv6:2a01:4f8:c010:41de::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B95E913DF7 for ; Sat, 12 Nov 2022 19:30:36 -0800 (PST) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1668310234; bh=2gTkiOcwRu1rvtsieSB6uYYfG6KwpnDzYJ7VI3RNyQA=; h=From:To:Cc:Subject:Date:From; b=b+WhP7YAnAS8pr7aHdB3Jd89kWdSvdLDW7JXO+7p6QDkJPFCKHIeablhfi6hZJVAk aUPJmiokBqqZEYesqNT2f2QNOEsfiRhZ0byPrg7N8FzHSxPzcBp0KmR5X8OuA1+k0/ qh3BCMAbMS2ky54HSMU/PAH9kuVRnT3Xx/bcUyf8= To: Benjamin Herrenschmidt , Dmitry Torokhov Cc: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , linux-input@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: [PATCH] macintosh/mac_hid.c: don't load by default Date: Sun, 13 Nov 2022 04:30:22 +0100 Message-Id: <20221113033022.2639-1-linux@weissschuh.net> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1668310220; l=1025; i=linux@weissschuh.net; s=20211113; h=from:subject; bh=2gTkiOcwRu1rvtsieSB6uYYfG6KwpnDzYJ7VI3RNyQA=; b=/j6qqxCFitLVms6T0bo554pD1PYuGU4fej2PB1Xt0KyhqBLYFyNUkX4SOqLu/KdIPnSZhFsqjkBg 3h1eojjyBbDRrxOrzFCCOvAKyxqK+6wbQJaNfxQj6LsvS1MZuqjR X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749352141393349528?= X-GMAIL-MSGID: =?utf-8?q?1749352141393349528?= There should be no need to automatically load this driver on *all* machines with a keyboard. This driver is of very limited utility and has to be enabled by the user explicitly anyway. Furthermore its own header comment has deprecated it for 17 years. Fixes: 99b089c3c38a ("Input: Mac button emulation - implement as an input filter") Signed-off-by: Thomas Weißschuh --- drivers/macintosh/mac_hid.c | 2 -- 1 file changed, 2 deletions(-) base-commit: fef7fd48922d11b22620e19f9c9101647bfe943d diff --git a/drivers/macintosh/mac_hid.c b/drivers/macintosh/mac_hid.c index d8c4d5664145..d01d28890db4 100644 --- a/drivers/macintosh/mac_hid.c +++ b/drivers/macintosh/mac_hid.c @@ -149,8 +149,6 @@ static const struct input_device_id mac_hid_emumouse_ids[] = { { }, }; -MODULE_DEVICE_TABLE(input, mac_hid_emumouse_ids); - static struct input_handler mac_hid_emumouse_handler = { .filter = mac_hid_emumouse_filter, .connect = mac_hid_emumouse_connect,