Message ID | 20221112092541.3605038-1-yangyingliang@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1191273wru; Sat, 12 Nov 2022 01:32:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf5pQjI1m4+k+WA+4Q6ZKFbBrCuWDusF9STu2P+H2ZU6ldpf22AfXeJOVV975J/1llVbR1QG X-Received: by 2002:aa7:cb92:0:b0:459:f897:7940 with SMTP id r18-20020aa7cb92000000b00459f8977940mr4613643edt.168.1668245541404; Sat, 12 Nov 2022 01:32:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668245541; cv=none; d=google.com; s=arc-20160816; b=fSanKF6O9IJGOYRVBIYpC2SKFz1xIy2RoEUkDc01JIb0NqmG7zKCwhoLDqc0Q/Znt6 pktI04ac2tcb7ZwW9DBo3Sb/4Aph0c1yvaBDJHdaT0dbiKAQBOs5cP+Rl93ECMm/k1y8 fde8JmGd9y3H6HTXI6lrZlGFRE1rzPkv9xlJZpxIylbkJjLra8Ggz5nzcCabTJKxmyIP MyBUnoQK5E7hhgsR+pxW4URHBDIazQQdjN9r7F+3Cgg9FJbSQTyoHOm0woq7S57FoGL4 nrio3NSJVDSxld2KEcgpfvu59yfqABkankrq5XfhIIJ4iLqDX0x2J39A3l68Lv/4TqeZ 5aog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JOP8pjqt2khxKMPxcwvw1WttWJz12cxm1fUrL5KW3GA=; b=jUjmWODDbKayC95igjK8oImP/WZLBf+funNEKpRruCMjyRuwjbUJR8ki0dmm+gYUnX 6s64zuQj3lFXl7+eWZhL4ffa3qhencXQw/XemhP6jL6k3cFJa3UuTbnNY46+WTVbz+0e pYeYqacF3H1ENC+faAnYsQVTPl8rkqw5X3NhVLtuHqyVTLwGE67PsaaOC9q5lpb6jPWD SrnJfd1emk2Y1GLdyobIYUmCnFAJLjYE709mLa6U9V4qr8rc1hMDhIr+CHLQ9BMlyFiU K8aC4Y+dc6LzmprN8aLkbiK6tNHeFJG2ciAe42IN2V30tQHlgmepJJz4Jpl3iMpSuHwT zEuw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v7-20020a50a447000000b00463d1e2639fsi3866461edb.363.2022.11.12.01.31.57; Sat, 12 Nov 2022 01:32:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234542AbiKLJ1N (ORCPT <rfc822;winker.wchi@gmail.com> + 99 others); Sat, 12 Nov 2022 04:27:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233223AbiKLJ1M (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 12 Nov 2022 04:27:12 -0500 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CB7F389F for <linux-kernel@vger.kernel.org>; Sat, 12 Nov 2022 01:27:08 -0800 (PST) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4N8VZd3TTqzmVkt; Sat, 12 Nov 2022 17:26:49 +0800 (CST) Received: from dggpemm500007.china.huawei.com (7.185.36.183) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 12 Nov 2022 17:27:06 +0800 Received: from huawei.com (10.175.103.91) by dggpemm500007.china.huawei.com (7.185.36.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 12 Nov 2022 17:27:06 +0800 From: Yang Yingliang <yangyingliang@huawei.com> To: <linux-kernel@vger.kernel.org> CC: <linux@dominikbrodowski.net> Subject: [PATCH] pcmcia: cs: fix possible hung task and memory leak pccardd() Date: Sat, 12 Nov 2022 17:25:41 +0800 Message-ID: <20221112092541.3605038-1-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm500007.china.huawei.com (7.185.36.183) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749282237286296489?= X-GMAIL-MSGID: =?utf-8?q?1749282237286296489?= |
Series |
pcmcia: cs: fix possible hung task and memory leak pccardd()
|
|
Commit Message
Yang Yingliang
Nov. 12, 2022, 9:25 a.m. UTC
If device_register() returns error in pccardd(), it leads two issues:
1. The socket_released has never been completed, it will block
pcmcia_unregister_socket(), because of waiting for completion
of socket_released.
2. The device name allocated by dev_set_name() is leaked.
Fix this two issues by calling put_device() when device_register() fails.
socket_released can be completed in pcmcia_release_socket(), the name can
be freed in kobject_cleanup().
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/pcmcia/cs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pcmcia/cs.c b/drivers/pcmcia/cs.c index f70197154a36..820cce7c8b40 100644 --- a/drivers/pcmcia/cs.c +++ b/drivers/pcmcia/cs.c @@ -605,6 +605,7 @@ static int pccardd(void *__skt) dev_warn(&skt->dev, "PCMCIA: unable to register socket\n"); skt->thread = NULL; complete(&skt->thread_done); + put_device(&skt->dev); return 0; } ret = pccard_sysfs_add_socket(&skt->dev);