From patchwork Sat Nov 12 03:22:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Namhyung Kim X-Patchwork-Id: 19091 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1089557wru; Fri, 11 Nov 2022 19:24:21 -0800 (PST) X-Google-Smtp-Source: AA0mqf79ezKbpqyPopAJ6ojOPzF8PFAAwRI5zc5eRbxoFd/c7qdjXtHUAlvmKhU0aocZPnlud0xI X-Received: by 2002:a17:907:b60f:b0:78d:9f25:6103 with SMTP id vl15-20020a170907b60f00b0078d9f256103mr4111860ejc.168.1668223461145; Fri, 11 Nov 2022 19:24:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668223461; cv=none; d=google.com; s=arc-20160816; b=tnACa9VuQpbVMMtBLl+M2PIuit99kIcnKjozMWfjWcd4PH9A1Lo6uokN/5FatlLviM gWZDMaIgX1XkLjpFxOp9sMKNY5GZZaEESe/keEaAMiaro+OQtL4747552113uoigleJO hD+eQ9/lybh8rRQ5PpayDo2RcNY2FBOzb5i8aS2MX37s3mqOLOlzRIge1AQWHrFy++Os HJvnLrwSkb7BNW38rJAkrN07OQxQATHWCzpBQuAdyGisMBCF26fZQ3mY8XTWpQAcvy6t X7ih/bYDBabtuQfxoKvGwRUpcCEwr3+0zC9YJ1zkgDXItFta5eP+Ss14nncpvirWqcGx c2zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from:sender :dkim-signature; bh=rt0OZoaxk4oNSiXVua0yf4Wn8zR1kll8hc9QqXyH+pA=; b=AUKpJbnECE7rVTR0QRvhrX4ZfbVqUx+oKp6ub9xSdFW7zvqbMrP55jAe7F6Trq/DUT 0fvF8RcjLmRDs38uuonYPq0OoPj0DosqowqV3ifU6lhb9ezuzuYnN2SeEwvm6ti+b6yL rfGoXVO91rzwr3nTdPJWd5uimqltCUH7GBpbzRGwh61sMj3wpl9mMsoI23JOY8iARTsY Jh/6j+7NpLNUGKCaq2hJ8NCVT9+RW2qZeCrW3KEUUTLpujiTcrC2MbeSKfPxNZ9XwV5b 5zvwTuLSxztqUsG82v0F+9qFHA6WXS0Ab+axvjdo889DLXQDG/mEN9+uLZsAo/qtdHLo +1Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UOLbFmT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y12-20020a50ce0c000000b00463153e1627si3419652edi.146.2022.11.11.19.23.57; Fri, 11 Nov 2022 19:24:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=UOLbFmT5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234551AbiKLDXJ (ORCPT + 99 others); Fri, 11 Nov 2022 22:23:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234252AbiKLDW5 (ORCPT ); Fri, 11 Nov 2022 22:22:57 -0500 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 501D96BDEF; Fri, 11 Nov 2022 19:22:57 -0800 (PST) Received: by mail-pl1-x631.google.com with SMTP id 4so5730035pli.0; Fri, 11 Nov 2022 19:22:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=rt0OZoaxk4oNSiXVua0yf4Wn8zR1kll8hc9QqXyH+pA=; b=UOLbFmT5ToNAoU3oPqqERXV5uMrPQHnO6gCJI8tQqh9v7o8jFkF5sgAzfSAWDG6InF l3ATOCc1++/TBvjiELfNQhZLn1wBtovjj0FqUIsQIMaFBV7B265HLHDIk4a8vxaZvMMp SPPnyIiNweg1NQ5W2X0lR5WWJmc2zqdRZQD0njN/0r9NfrSqz8eW7tFSZ0ZwNuvdH1eO 2q+uBE43cMrIHHElSIuJKdAO7VPhCW7xBSTD98Q/OOLPTMtJmEOFyuR3QnlGmEvEUJ/v BbRqwHcdfb89H608XYwh2esOsLAEGjwNQIMlKQFHklbzK4M3Kxp83i2WOgKsmHBwGZMk kKtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rt0OZoaxk4oNSiXVua0yf4Wn8zR1kll8hc9QqXyH+pA=; b=c/6ToJCf3CbQK3fHwCWdixZFyU8sZvn7zdInM4WKBtO4rJjqj/xNN41K3HBzgSta9+ 3+RczZcitl3HilLVMEWvmjEuK70cgQ6d3zD4pBy8b1hOITN2KGsFwQZyXRubGSADW3I+ oR2Z7ZuCgcVcEVKPUAA9Wjbl+MeoEt5WexVqC8RgI/+Uxer1NPmKaafFbnYqr/GVNRTF mAKJW4GnMTN2jTjtdU2c5j5GEPNBrpnfdFyGX5dAETDTJYQGDVgG13eWOumkZNX6Micq q1rq3UUleda4YFpFwZZcHoFPaeTq28nZEfTMQTiC1KpklEBR84ROs7fYv1YbWk5N6wMb +5ig== X-Gm-Message-State: ANoB5plHbetTn7ujbyUH7EWDhLWp56FdyfKU2udY54CDWM66cmZDXJpt RRtkTVz8ENrDwcf+gerKB9c= X-Received: by 2002:a17:90b:3c4b:b0:215:f80c:18e6 with SMTP id pm11-20020a17090b3c4b00b00215f80c18e6mr4908393pjb.45.1668223376717; Fri, 11 Nov 2022 19:22:56 -0800 (PST) Received: from balhae.roam.corp.google.com ([2607:fb90:27dc:8408:33d7:3b01:eee1:84b]) by smtp.gmail.com with ESMTPSA id ij25-20020a170902ab5900b00186f0f59d1esm2434552plb.192.2022.11.11.19.22.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Nov 2022 19:22:56 -0800 (PST) Sender: Namhyung Kim From: Namhyung Kim To: Arnaldo Carvalho de Melo , Jiri Olsa Cc: Ingo Molnar , Peter Zijlstra , LKML , Ian Rogers , Adrian Hunter , linux-perf-users@vger.kernel.org, Kan Liang , Zhengjun Xing , James Clark Subject: [PATCH 05/11] perf stat: Clear screen only if output file is a tty Date: Fri, 11 Nov 2022 19:22:38 -0800 Message-Id: <20221112032244.1077370-6-namhyung@kernel.org> X-Mailer: git-send-email 2.38.1.493.g58b659f92b-goog In-Reply-To: <20221112032244.1077370-1-namhyung@kernel.org> References: <20221112032244.1077370-1-namhyung@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749259083755369208?= X-GMAIL-MSGID: =?utf-8?q?1749259083755369208?= The --interval-clear option makes perf stat to clear the terminal at each interval. But it doesn't need to clear the screen when it saves to a file. Make it fail when it's enabled with the output options. $ perf stat -I 1 --interval-clear -o myfile true --interval-clear does not work with output Usage: perf stat [] [] -o, --output output file name --log-fd log output to fd, instead of stderr --interval-clear clear screen in between new interval Signed-off-by: Namhyung Kim Acked-by: Ian Rogers --- tools/perf/builtin-stat.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c index d5e1670bca20..1d79801f4e84 100644 --- a/tools/perf/builtin-stat.c +++ b/tools/perf/builtin-stat.c @@ -2403,6 +2403,14 @@ int cmd_stat(int argc, const char **argv) } } + if (stat_config.interval_clear && !isatty(fileno(output))) { + fprintf(stderr, "--interval-clear does not work with output\n"); + parse_options_usage(stat_usage, stat_options, "o", 1); + parse_options_usage(NULL, stat_options, "log-fd", 0); + parse_options_usage(NULL, stat_options, "interval-clear", 0); + return -1; + } + stat_config.output = output; /*