diff mbox series

scsi: libfc: remove redundant variable ev_qual

Message ID 20221111170824.558250-1-colin.i.king@gmail.com
State New
Headers
Series scsi: libfc: remove redundant variable ev_qual |

Commit Message

Colin Ian King Nov. 11, 2022, 5:08 p.m. UTC 
  Variable ev_qual is being assigned and modified but the end result
is never used. The variable is redundant and can be removed.

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/scsi/libfc/fc_disc.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Martin K. Petersen Nov. 17, 2022, 6:14 p.m. UTC | #1 
Colin,

> Variable ev_qual is being assigned and modified but the end result is
> never used. The variable is redundant and can be removed.

Applied to 6.2/scsi-staging, thanks!
Martin K. Petersen Nov. 26, 2022, 3:27 a.m. UTC | #2 
On Fri, 11 Nov 2022 17:08:24 +0000, Colin Ian King wrote:

> Variable ev_qual is being assigned and modified but the end result
> is never used. The variable is redundant and can be removed.
> 
> 

Applied to 6.2/scsi-queue, thanks!

[1/1] scsi: libfc: remove redundant variable ev_qual
      https://git.kernel.org/mkp/scsi/c/0824050682ae
diff mbox series

Patch

diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
index 942fc60f7c21..0f32ded246d0 100644
--- a/drivers/scsi/libfc/fc_disc.c
+++ b/drivers/scsi/libfc/fc_disc.c
@@ -75,7 +75,6 @@  static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp)
 	struct fc_seq_els_data rjt_data;
 	unsigned int len;
 	int redisc = 0;
-	enum fc_els_rscn_ev_qual ev_qual;
 	enum fc_els_rscn_addr_fmt fmt;
 	LIST_HEAD(disc_ports);
 	struct fc_disc_port *dp, *next;
@@ -107,8 +106,6 @@  static void fc_disc_recv_rscn_req(struct fc_disc *disc, struct fc_frame *fp)
 		goto reject;
 
 	for (pp = (void *)(rp + 1); len > 0; len -= sizeof(*pp), pp++) {
-		ev_qual = pp->rscn_page_flags >> ELS_RSCN_EV_QUAL_BIT;
-		ev_qual &= ELS_RSCN_EV_QUAL_MASK;
 		fmt = pp->rscn_page_flags >> ELS_RSCN_ADDR_FMT_BIT;
 		fmt &= ELS_RSCN_ADDR_FMT_MASK;
 		/*