diff mbox series

[1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb3-uni: drop reference-clock source

Message ID 20221111093857.11360-2-johan+linaro@kernel.org
State New
Headers
Series phy: qcom-qmp-usb: drop sc8280xp reference-clock source |

Commit Message

Johan Hovold Nov. 11, 2022, 9:38 a.m. UTC 
  The source clock for the reference clock is not used by the PHY directly
and should not be included in the devicetree binding.

Fixes: e8e58e29a0c9 ("dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding")
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
---
 .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml       | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Bjorn Andersson Nov. 11, 2022, 8:26 p.m. UTC | #1 
On Fri, Nov 11, 2022 at 10:38:55AM +0100, Johan Hovold wrote:
> The source clock for the reference clock is not used by the PHY directly
> and should not be included in the devicetree binding.
> 
> Fixes: e8e58e29a0c9 ("dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

> ---
>  .../bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml       | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> index ef080509747a..16fce1038285 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> @@ -22,12 +22,11 @@ properties:
>      maxItems: 1
>  
>    clocks:
> -    maxItems: 5
> +    maxItems: 4
>  
>    clock-names:
>      items:
>        - const: aux
> -      - const: ref_clk_src
>        - const: ref
>        - const: com_aux
>        - const: pipe
> @@ -82,12 +81,10 @@ examples:
>        reg = <0x088ef000 0x2000>;
>  
>        clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>,
> -               <&rpmhcc RPMH_CXO_CLK>,
>                 <&gcc GCC_USB3_MP0_CLKREF_CLK>,
>                 <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>,
>                 <&gcc GCC_USB3_MP_PHY_PIPE_0_CLK>;
> -      clock-names = "aux", "ref_clk_src", "ref", "com_aux",
> -                    "pipe";
> +      clock-names = "aux", "ref", "com_aux", "pipe";
>  
>        power-domains = <&gcc USB30_MP_GDSC>;
>  
> -- 
> 2.37.4
>
Krzysztof Kozlowski Nov. 15, 2022, 1:38 p.m. UTC | #2 
On 11/11/2022 10:38, Johan Hovold wrote:
> The source clock for the reference clock is not used by the PHY directly
> and should not be included in the devicetree binding.
> 
> Fixes: e8e58e29a0c9 ("dt-bindings: phy: qcom,qmp-usb: fix sc8280xp binding")
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
index ef080509747a..16fce1038285 100644
--- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
@@ -22,12 +22,11 @@  properties:
     maxItems: 1
 
   clocks:
-    maxItems: 5
+    maxItems: 4
 
   clock-names:
     items:
       - const: aux
-      - const: ref_clk_src
       - const: ref
       - const: com_aux
       - const: pipe
@@ -82,12 +81,10 @@  examples:
       reg = <0x088ef000 0x2000>;
 
       clocks = <&gcc GCC_USB3_MP_PHY_AUX_CLK>,
-               <&rpmhcc RPMH_CXO_CLK>,
                <&gcc GCC_USB3_MP0_CLKREF_CLK>,
                <&gcc GCC_USB3_MP_PHY_COM_AUX_CLK>,
                <&gcc GCC_USB3_MP_PHY_PIPE_0_CLK>;
-      clock-names = "aux", "ref_clk_src", "ref", "com_aux",
-                    "pipe";
+      clock-names = "aux", "ref", "com_aux", "pipe";
 
       power-domains = <&gcc USB30_MP_GDSC>;