From patchwork Fri Nov 11 09:20:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: ChenXiaoSong X-Patchwork-Id: 18583 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp629331wru; Fri, 11 Nov 2022 01:06:41 -0800 (PST) X-Google-Smtp-Source: AA0mqf7xVFhJu+0O4tZiV7sAk0fsMoAngRBuRVRfR/eCGgQh1jTOBGdDkMlmlgyUhbzfju+1l8wj X-Received: by 2002:a50:cc9e:0:b0:461:523d:332e with SMTP id q30-20020a50cc9e000000b00461523d332emr620753edi.421.1668157600929; Fri, 11 Nov 2022 01:06:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668157600; cv=none; d=google.com; s=arc-20160816; b=NfOqApmil2TEy+v4Xf4V/W1JqRoFpG+3VolOfg1QPOZydQYTD4Ucr4Sr9gwX33j4Fj HTFTsARH9PUF3dteIuWri1YxRKeKnv5XWnz+3gQYo7x8g5CX1p6N6GyXAXqj2y3mvqpo L2RftHxGcxSi0fVdny7FDzJ6adOr5VkWlnseX95WZW2ktBiYCVIO9/ucGEwOAkR8yFUe 9AzzLVpboNgoDBe9Q1kRVeJQetb/jRWzXxS0c9h5gNq+FoTGkoakdYKQ1fwY/zJlI7LH fpnm0m/dUBQonQVZ/oQzlU2Bk48wWWlaAne8H1AuMhmlI7ZUWFHO6hGB4II9yjX+A3/C Z0YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=N7ggEsAWRmgd3B0sEcQR0kw8gFiI25a3nt57Ha3uWK0=; b=ohWHzfrVUxgJyarL9Uzezj0RaU7/G54Rd2X9Rjhqik2iqI5tFys/79nLFLQ6XGUQT/ JTFa6dlRmCD0CvyeJlmAqeqSRYmAAYVOj5BD/zJRGYQpcDKzNGXHL6fCIQuo5+WvYgHI /vYBJ3gT+KX+d38mBf8fz+VLfPWsP6kU1CaPeHOT6l9/4yHpB747I1PmSzHmA7ywUyAc zYEcQfsVcXUu2qGKLNBvNbaqXCqlSirYddZZIkTez4Ogg5hUOeP6FkC+fipIjUAVlOmR fzMBhhwamX7XkkJqUF5NQtd4yNlt0mx6DJiCC1ACJ7uEUTao3yfNES6X/ScCAEwanVbu PZzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ee16-20020a056402291000b00447a8836a56si1445151edb.208.2022.11.11.01.06.17; Fri, 11 Nov 2022 01:06:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232823AbiKKJFx (ORCPT + 99 others); Fri, 11 Nov 2022 04:05:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52878 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233659AbiKKJFe (ORCPT ); Fri, 11 Nov 2022 04:05:34 -0500 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7001D20364; Fri, 11 Nov 2022 01:05:26 -0800 (PST) Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4N7t7t25QVzHvnr; Fri, 11 Nov 2022 17:04:58 +0800 (CST) Received: from kwepemm600015.china.huawei.com (7.193.23.52) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 17:05:24 +0800 Received: from huawei.com (10.175.101.6) by kwepemm600015.china.huawei.com (7.193.23.52) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 17:05:23 +0800 From: ChenXiaoSong To: , , CC: , , , , Subject: [PATCH v3] btrfs: qgroup: fix sleep from invalid context bug in update_qgroup_limit_item() Date: Fri, 11 Nov 2022 17:20:00 +0800 Message-ID: <20221111092000.2275068-1-chenxiaosong2@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Originating-IP: [10.175.101.6] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemm600015.china.huawei.com (7.193.23.52) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749118782381037016?= X-GMAIL-MSGID: =?utf-8?q?1749190024909258535?= Syzkaller reported BUG as follows: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:274 Call Trace: dump_stack_lvl+0xcd/0x134 __might_resched.cold+0x222/0x26b kmem_cache_alloc+0x2e7/0x3c0 update_qgroup_limit_item+0xe1/0x390 btrfs_qgroup_inherit+0x147b/0x1ee0 create_subvol+0x4eb/0x1710 btrfs_mksubvol+0xfe5/0x13f0 __btrfs_ioctl_snap_create+0x2b0/0x430 btrfs_ioctl_snap_create_v2+0x25a/0x520 btrfs_ioctl+0x2a1c/0x5ce0 __x64_sys_ioctl+0x193/0x200 do_syscall_64+0x35/0x80 Fix this by delaying the limit item updates until unlock the spin lock. Signed-off-by: ChenXiaoSong --- fs/btrfs/qgroup.c | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c index 9334c3157c22..0071b2be6785 100644 --- a/fs/btrfs/qgroup.c +++ b/fs/btrfs/qgroup.c @@ -2860,6 +2860,8 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, bool need_rescan = false; u32 level_size = 0; u64 nums; + bool update_limit = false; + int err; /* * There are only two callers of this function. @@ -2950,15 +2952,7 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, dstgroup->max_excl = inherit->lim.max_excl; dstgroup->rsv_rfer = inherit->lim.rsv_rfer; dstgroup->rsv_excl = inherit->lim.rsv_excl; - - ret = update_qgroup_limit_item(trans, dstgroup); - if (ret) { - qgroup_mark_inconsistent(fs_info); - btrfs_info(fs_info, - "unable to update quota limit for %llu", - dstgroup->qgroupid); - goto unlock; - } + update_limit = true; } if (srcid) { @@ -2985,6 +2979,7 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, dstgroup->max_excl = srcgroup->max_excl; dstgroup->rsv_rfer = srcgroup->rsv_rfer; dstgroup->rsv_excl = srcgroup->rsv_excl; + update_limit = true; qgroup_dirty(fs_info, dstgroup); qgroup_dirty(fs_info, srcgroup); @@ -3053,6 +3048,16 @@ int btrfs_qgroup_inherit(struct btrfs_trans_handle *trans, u64 srcid, unlock: spin_unlock(&fs_info->qgroup_lock); + if (update_limit) { + err = update_qgroup_limit_item(trans, dstgroup); + if (err) { + ret = err; + qgroup_mark_inconsistent(fs_info); + btrfs_info(fs_info, + "unable to update quota limit for %llu", + dstgroup->qgroupid); + } + } if (!ret) ret = btrfs_sysfs_add_one_qgroup(fs_info, dstgroup); out: