diff mbox series

[linux-next] ipasdv4/tcp_ipv4: remove redundant assignment

Message ID 20221111090419.494633-1-xu.xin16@zte.com.cn
State New
Headers
Series [linux-next] ipasdv4/tcp_ipv4: remove redundant assignment |

Commit Message

xu Nov. 11, 2022, 9:04 a.m. UTC 
  From: xu xin <xu.xin16@zte.com.cn>

The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING",
it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it.

Signed-off-by: xu xin <xu.xin16@zte.com.cn>
---
 net/ipv4/tcp_ipv4.c | 1 -
 1 file changed, 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 14, 2022, 11:30 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 11 Nov 2022 09:04:20 +0000 you wrote:
> From: xu xin <xu.xin16@zte.com.cn>
> 
> The value of 'st->state' has been verified as "TCP_SEQ_STATE_LISTENING",
> it's unnecessary to assign TCP_SEQ_STATE_LISTENING to it, so we can remove it.
> 
> Signed-off-by: xu xin <xu.xin16@zte.com.cn>
> 
> [...]

Here is the summary with links:
  - [linux-next] ipasdv4/tcp_ipv4: remove redundant assignment
    https://git.kernel.org/netdev/net-next/c/2fd450cd83e3

You are awesome, thank you!
diff mbox series

Patch

diff --git a/net/ipv4/tcp_ipv4.c b/net/ipv4/tcp_ipv4.c
index 7a250ef9d1b7..0180f3cefa9c 100644
--- a/net/ipv4/tcp_ipv4.c
+++ b/net/ipv4/tcp_ipv4.c
@@ -2478,7 +2478,6 @@  static void *tcp_seek_last_pos(struct seq_file *seq)
 	case TCP_SEQ_STATE_LISTENING:
 		if (st->bucket > hinfo->lhash2_mask)
 			break;
-		st->state = TCP_SEQ_STATE_LISTENING;
 		rc = listening_get_first(seq);
 		while (offset-- && rc && bucket == st->bucket)
 			rc = listening_get_next(seq, rc);