From patchwork Fri Nov 11 08:56:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 18573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp626268wru; Fri, 11 Nov 2022 01:00:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf6KrS/PyEjhad5TZvTfSWv/stGml5g+0P6cDwTwZ5f9y+WeWA/aGkoYOKRy5D/LE3/U4Kl7 X-Received: by 2002:a17:907:6d07:b0:78d:a836:1d88 with SMTP id sa7-20020a1709076d0700b0078da8361d88mr1086501ejc.470.1668157223540; Fri, 11 Nov 2022 01:00:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668157223; cv=none; d=google.com; s=arc-20160816; b=CY2dEPlVuRQFo6mcIOChg0uJnvgR3GlFXPDOSgzImqmortoZ/CJ4dVwAuj3M2jFQJX toqqI0f8chxW8RZUWCP/D7UHdUkh+kjHtOwZVM8RuvWRjCYE2SxIXaBg5sY6heygOBrA H7NwZxVgKR0o1buM+AyxjkD40x2JG13HQQZBQBzApAhJFKQXD6dceaxY6p1z4pN2TpGp ua7A7ZYB5tOpJqKkrr3XvaAkh/MvjLGZwDyB5kfu/bYUrCBq9snyBrVah126+skfoutJ o0h4PnX4KVRPeqFbadvvpKz0Xt3liHqd3jfA/SAoMpja5EDvO/LhuZWiHS4mfPQOfSmp XNAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=w86tmUuz4JDdrSCjDXrK2bM+cuMeULf3aXBn/cMfr7M=; b=CECmz5UN5zZLnVpncpM06/7/B9phXjrXHBNARlkTXAkuppfKHA+D37AMxs4JY6mfdr 7Y3cI4+82Zpw7B0afqD7ICHt4PMfK/iSqr70S9vjmjggE2Wya36fxSBCsSE6N9/cRTph wTPZ9LQcW+d0Nb/RSRxQDrMQC7xkW71olTGd1q24JcaET6TI8UYTgoHygG8bvOg196sj erdquaXC3x7uFBNNn3/AyiLN6o0VImSSnmNz4SuWD1bcxmoCRGR2fLHZelZ2EmH+Quox 2ceVT8vXjxT5fy2YangH/imkp4j21Mjxg0vKaQSc7jszz2IyksIaPigaZS/Vtpi3LzPZ npiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="IhkZiL+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nc30-20020a1709071c1e00b0078dfe6dc4d2si1482713ejc.33.2022.11.11.01.00.00; Fri, 11 Nov 2022 01:00:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="IhkZiL+/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233599AbiKKI6f (ORCPT + 99 others); Fri, 11 Nov 2022 03:58:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233453AbiKKI51 (ORCPT ); Fri, 11 Nov 2022 03:57:27 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C64227E99E; Fri, 11 Nov 2022 00:57:25 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 11EB461F09; Fri, 11 Nov 2022 08:57:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 546FAC433D6; Fri, 11 Nov 2022 08:57:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668157044; bh=wNuGpKWL+DXYqRL8dJhpoLp3afK+DCMbnrSrckORwI0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IhkZiL+/I42sPfWcc6sdn9+jWnAA0mJK8u3W0y13AD442x+oObrzDzripiudhPUOK 39qOEF6jk2jgriEf5IcAwE2AZNTjCSadq5k4Gn4cuVh7C1K02cpwXqhi17ryLEYUPN 8CMsaNUS/wA9W7a1D9YX3wWEGPOytsvQZ/slmI8NlpkUz3kYtJttBcnsvmtn8qU2Wg Zt0kl0dnXA2rR6B+T80SfWAqdX91FM+u1JU2wGMoEoKHdQqZdfm+FwC8h5T3klIEN3 4XgnSruYBewJKQ66ACHhWJAvzR9xvMc03hqln50fnZ/BQ0y53QSCS7J1I/zxqsI90y LtJkBRah2AnsA== Received: from johan by xi.lan with local (Exim 4.94.2) (envelope-from ) id 1otPqK-0002Um-MH; Fri, 11 Nov 2022 09:56:56 +0100 From: Johan Hovold To: Vinod Koul Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Dmitry Baryshkov , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold Subject: [PATCH 21/22] phy: qcom-qmp-combo: clean up PHY init Date: Fri, 11 Nov 2022 09:56:42 +0100 Message-Id: <20221111085643.9478-22-johan+linaro@kernel.org> X-Mailer: git-send-email 2.37.4 In-Reply-To: <20221111085643.9478-1-johan+linaro@kernel.org> References: <20221111085643.9478-1-johan+linaro@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749189629056328291?= X-GMAIL-MSGID: =?utf-8?q?1749189629056328291?= Clean up the USB PHY initialisation somewhat by programming both tx and rx for the second lane after the first lane. Signed-off-by: Johan Hovold Reviewed-by: Dmitry Baryshkov --- drivers/phy/qualcomm/phy-qcom-qmp-combo.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c index bb2c86976f78..6d98d37f8562 100644 --- a/drivers/phy/qualcomm/phy-qcom-qmp-combo.c +++ b/drivers/phy/qualcomm/phy-qcom-qmp-combo.c @@ -1950,14 +1950,12 @@ static int qmp_combo_usb_power_on(struct phy *phy) /* Tx, Rx, and PCS configurations */ qmp_combo_configure_lane(tx, cfg->tx_tbl, cfg->tx_tbl_num, 1); - - if (cfg->lanes >= 2) - qmp_combo_configure_lane(qmp->tx2, cfg->tx_tbl, cfg->tx_tbl_num, 2); - qmp_combo_configure_lane(rx, cfg->rx_tbl, cfg->rx_tbl_num, 1); - if (cfg->lanes >= 2) + if (cfg->lanes >= 2) { + qmp_combo_configure_lane(qmp->tx2, cfg->tx_tbl, cfg->tx_tbl_num, 2); qmp_combo_configure_lane(qmp->rx2, cfg->rx_tbl, cfg->rx_tbl_num, 2); + } qmp_combo_configure(pcs, cfg->pcs_tbl, cfg->pcs_tbl_num);