From patchwork Fri Nov 11 07:40:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Zhongjin X-Patchwork-Id: 18525 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp601193wru; Thu, 10 Nov 2022 23:49:51 -0800 (PST) X-Google-Smtp-Source: AA0mqf5SThz/WqfbNogDmgG8j/FV/Pm0OpEv+0XCvVG02vv60vMYGBmlTe+IXk9cKsYd/0nE2oVL X-Received: by 2002:a05:6402:e93:b0:461:e598:e0bb with SMTP id h19-20020a0564020e9300b00461e598e0bbmr478934eda.21.1668152991638; Thu, 10 Nov 2022 23:49:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668152991; cv=none; d=google.com; s=arc-20160816; b=euySwsz0iiXcCSHhcYnz5ly4QrUXcQSvdI+QmMShPWDG3uZkKCC+SHNwTTRsVI3Y1c P1uc5C9S2cN4uPEKCX+l+KCHfAoORprrdp0ve6szCEgZsSFFrOoKbbDNCL9S1EweKm63 cT2dIfeoxQeTaKGOZ/Q9MD4IZLEuPgo0h7Qh3+giehz6Ewc+QDx2CgCsjEZ1ZuYX7rQh fyWIeg6U3oxETp1tjPwfyN3s823Co3IjuJceI6m/MdquWsztSAPJHMRjmiGQIUjyCgvB wG8A/ovtFQBXqVzGuK50kOELeBdusfq4jwdtf35bmrAmvsqY7S29zwqW6l8Qp7bvLx8L sIIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=jazILk3FB9P24cfCrLQH14zRdmqgg8W8xykBpu5SC24=; b=lanB5jA7eZBYuT64n8mA1UugXLG3htjm9YMfI6Nz8xWHlqIL9EM20oKnbnBzIT7R1a iI0LR8Crmcv9IoAv/8xX8KoGppr9OYdrAynAjSGgdOpi9ECHFijSUqJcLbe2mWZyWOmK AbK42yEAJwx+UVezrzZKh0sFLVrLHXFottxCIR+PLN51izkutVvNT2+YR+8vCsJhCoW4 StFde5DUGPNHE118WQF75W/Yzud9+1NFJNN/a4QZVMiByVEg4oJW+YmLFN2nqxBzImN/ BIipQRk/Aqlh8XfeuBiJMzLy9CBNmZB9Q8OmNIvFCKXllS2C/XeyET0wV9Ym2ZpAiTEW ghYQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dp17-20020a170906c15100b007ae52a5707bsi1586747ejc.95.2022.11.10.23.49.27; Thu, 10 Nov 2022 23:49:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233144AbiKKHoD (ORCPT + 99 others); Fri, 11 Nov 2022 02:44:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232809AbiKKHoC (ORCPT ); Fri, 11 Nov 2022 02:44:02 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 031EA6B22E; Thu, 10 Nov 2022 23:44:00 -0800 (PST) Received: from dggpemm500022.china.huawei.com (unknown [172.30.72.54]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4N7rL737r7z15MXT; Fri, 11 Nov 2022 15:43:43 +0800 (CST) Received: from dggpemm500013.china.huawei.com (7.185.36.172) by dggpemm500022.china.huawei.com (7.185.36.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 15:43:58 +0800 Received: from ubuntu1804.huawei.com (10.67.175.36) by dggpemm500013.china.huawei.com (7.185.36.172) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Fri, 11 Nov 2022 15:43:58 +0800 From: Chen Zhongjin To: , , CC: , , , , , , , Subject: [PATCH] scsi: efct: Fix possible memleak in efct_device_init() Date: Fri, 11 Nov 2022 15:40:46 +0800 Message-ID: <20221111074046.57061-1-chenzhongjin@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.67.175.36] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To dggpemm500013.china.huawei.com (7.185.36.172) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749185191418557928?= X-GMAIL-MSGID: =?utf-8?q?1749185191418557928?= In efct_device_init(), when efct_scsi_reg_fc_transport() fails, efct_scsi_tgt_driver_exit() is not called to release memory for efct_scsi_tgt_driver_init() and causes memleak: unreferenced object 0xffff8881020ce000 (size 2048): comm "modprobe", pid 465, jiffies 4294928222 (age 55.872s) backtrace: [<0000000021a1ef1b>] kmalloc_trace+0x27/0x110 [<000000004c3ed51c>] target_register_template+0x4fd/0x7b0 [target_core_mod] [<00000000f3393296>] efct_scsi_tgt_driver_init+0x18/0x50 [efct] [<00000000115de533>] 0xffffffffc0d90011 [<00000000d608f646>] do_one_initcall+0xd0/0x4e0 [<0000000067828cf1>] do_init_module+0x1cc/0x6a0 ... Fixes: 4df84e846624 ("scsi: elx: efct: Driver initialization routines") Signed-off-by: Chen Zhongjin --- drivers/scsi/elx/efct/efct_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/elx/efct/efct_driver.c b/drivers/scsi/elx/efct/efct_driver.c index b08fc8839808..49fd2cfed70c 100644 --- a/drivers/scsi/elx/efct/efct_driver.c +++ b/drivers/scsi/elx/efct/efct_driver.c @@ -42,6 +42,7 @@ efct_device_init(void) rc = efct_scsi_reg_fc_transport(); if (rc) { + efct_scsi_tgt_driver_exit(); pr_err("failed to register to FC host\n"); return rc; }