| Message ID | 20221110195619.1276302-2-elder@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp349799wru;
Thu, 10 Nov 2022 12:05:16 -0800 (PST)
X-Google-Smtp-Source:
AMsMyM5R3TTwQ278Jg4lxI2OwlJrN2GRgPlrfZRdZN007OJlfJc73TfRlsRxmO56rSj0BAjPLtex
X-Received: by 2002:a17:906:4ad6:b0:7ad:e518:13fd with SMTP id
u22-20020a1709064ad600b007ade51813fdmr3677336ejt.323.1668110716183;
Thu, 10 Nov 2022 12:05:16 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1668110716; cv=none;
d=google.com; s=arc-20160816;
b=WHN0AaZMjubdGriBwcfM/pwQJ0sR4SSt6cmhdUuqFtnV9RVBZCqBo3sKB3lAqljYtj
D5QTeIxfT/FBu6E5ICjoXiMPntaiPwOgGG1/JuPhwKQoZanCqOnx3+hwqCFcD8I11wg5
NCikFKAylfVjic0Okny7Abt+Lbbt2f5JZedg4p1gXxqoR2ykIA0b7mpS4/tbxHTfAKUk
MfLUvuF98PTsEulcGaGhUZ9f80TYTwIeMogfcyKXPRLU+EZzjqFRBDvZCc3JPTd9cmfn
qqUROlck3HImfjNpVzKVEuP3A/C+CMXNFarzElQyZFgtfXOX8XVqVdeXHFHdRSOkXh1W
/TPw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=v945GSX1eV3UJd6GCr0VKFlHKoDz5Oj9+fbjy4q6OhU=;
b=DpM9rEtcl1aVFdtqr4pOdwbXCIJCnL655nWBbBTZdMnKILuIaHCcuKoNe5mZoO6lP9
KfU5M89vx4ThhBlZCkUxk2E9v1yeFMLy4WUViDStM3P/Kz3uFEuergRO/Dah86s5vrkw
GljlWwmOFqt7J7AoX29o8U60o6a+nfYXO2hogVyNGKM1Eg5QVKkW0Oemzw8uCc2oUq9D
EvC2nBHYE53klsEu3mWbz5sHt6TtE8pAnjR/zZkIfypVShF7ZLFt5niys3x9t/n9tM6U
360c6FpXmKE2u3clRl/ZCAEZW8ViUX6R2ZaOHpttn4Tyt+q3NbmbwzTlNu3Atmsabhqe
lnHQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=yFfCLKNr;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
eb5-20020a0564020d0500b0045d292ef641si532761edb.493.2022.11.10.12.04.50;
Thu, 10 Nov 2022 12:05:16 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=yFfCLKNr;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231345AbiKJT4e (ORCPT <rfc822;winker.wchi@gmail.com>
+ 99 others); Thu, 10 Nov 2022 14:56:34 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48382 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229952AbiKJT41 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 10 Nov 2022 14:56:27 -0500
Received: from mail-il1-x135.google.com (mail-il1-x135.google.com
[IPv6:2607:f8b0:4864:20::135])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FE5365CF
for <linux-kernel@vger.kernel.org>;
Thu, 10 Nov 2022 11:56:26 -0800 (PST)
Received: by mail-il1-x135.google.com with SMTP id i5so1541346ilc.12
for <linux-kernel@vger.kernel.org>;
Thu, 10 Nov 2022 11:56:26 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=v945GSX1eV3UJd6GCr0VKFlHKoDz5Oj9+fbjy4q6OhU=;
b=yFfCLKNrKYDXvW92bMbGEQ1ZBinb7uE7Py8eAE0uyj+kVmFXNDcLnWnP/y130vReoN
o/wM9VROwxH34Dxm3sOaMBp2SObqOhOxQB/YuUedPaqLg7pql12PhxUyti3DF57Sv8xY
JCLhjyUvG9I7zI3ysZVBGFcEacWQHXRi75flg2C1KQZJPzJer0ge+M7ylt2OAFgkJrqb
jFUNwynaXQWHRN19w6f2aWrfB5dGsqJaEOVpVBBQV2c06isj23O53N15zElWiAgs1jbq
C3psD3R9mdrsvYFncz4IFc9WaRgeCYVEJ5INry8TWak7FiaFVl4M306FY4WP2CWWXvU4
BwbA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=v945GSX1eV3UJd6GCr0VKFlHKoDz5Oj9+fbjy4q6OhU=;
b=WlTymdXH0P8PT0Xf9358LXPBnzbSwU5jfGXNzhpCmfiE/jzPz3Do/UPQURagdvUlMf
q+eBKMj5do/qW4y7u7Y3dGtGIv6V1H3DflaW9P4aZSBlg8Fe3GzkWzr0ZJIWJ96iHgvg
TYdGCowwoX/pxaw77mQFNriarhsxm8sn6tpxnDxWknW5E7jb9sPdALZ1L2/eiPmbo0oE
rJKjZH64tpSyBfAiseZU2obeSmk5EFggLMz+szNcyaFd18Ah4sytM06WeBcKiyFAakwz
fbIMA4tqtUzws84fDRqeFXNwPRhC1MSvYDiqDhiJbBoOb5M8bT+1Ix4gQlwocbYcQJLO
8L+Q==
X-Gm-Message-State: ACrzQf3xlN68DnfqWZO2VsogKUVtQkXoWoSnahdvzsAyLsTfg0M8GOjS
iBSSxEJjxTTEjWuNqk1+WutkkA==
X-Received: by 2002:a92:d3c8:0:b0:2ec:364c:55c5 with SMTP id
c8-20020a92d3c8000000b002ec364c55c5mr3284669ilh.61.1668110185610;
Thu, 10 Nov 2022 11:56:25 -0800 (PST)
Received: from presto.localdomain ([98.61.227.136])
by smtp.gmail.com with ESMTPSA id
l2-20020a6b3e02000000b006bbddd49984sm28602ioa.9.2022.11.10.11.56.24
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 10 Nov 2022 11:56:24 -0800 (PST)
From: Alex Elder <elder@linaro.org>
To: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com
Cc: andersson@kernel.org, konrad.dybcio@linaro.org, agross@kernel.org,
elder@kernel.org, linux-arm-msm@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 1/2] dt-bindings: net: qcom,ipa: remove an
unnecessary restriction
Date: Thu, 10 Nov 2022 13:56:17 -0600
Message-Id: <20221110195619.1276302-2-elder@linaro.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20221110195619.1276302-1-elder@linaro.org>
References: <20221110195619.1276302-1-elder@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1749140862300451680?=
X-GMAIL-MSGID: =?utf-8?q?1749140862300451680?=
|
| Series |
dt-bindings: net: qcom,ipa: relax some restrictions
|
|
Commit Message
Alex Elder
Nov. 10, 2022, 7:56 p.m. UTC
Commit d8604b209e9b3 ("dt-bindings: net: qcom,ipa: add firmware-name
property") added a requirement for a "firmware-name" property that
is more restrictive than necessary.
If the AP loads GSI firmware, the name of the firmware file to use
may optionally be provided via a "firmware-name" property. If the
*modem* loads GSI firmware, "firmware-name" doesn't need to be
supplied--but it's harmless to do so (it will simply be ignored).
Remove the unnecessary restriction, and allow "firware-name" to be
supplied even if it's not needed.
Signed-off-by: Alex Elder <elder@linaro.org>
---
Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ----------
1 file changed, 10 deletions(-)
Comments
On 10/11/2022 20:56, Alex Elder wrote: > Commit d8604b209e9b3 ("dt-bindings: net: qcom,ipa: add firmware-name > property") added a requirement for a "firmware-name" property that > is more restrictive than necessary. > > If the AP loads GSI firmware, the name of the firmware file to use > may optionally be provided via a "firmware-name" property. If the > *modem* loads GSI firmware, "firmware-name" doesn't need to be > supplied--but it's harmless to do so (it will simply be ignored). > > Remove the unnecessary restriction, and allow "firware-name" to be > supplied even if it's not needed. > > Signed-off-by: Alex Elder <elder@linaro.org> > --- > Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 ---------- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index dd4bb2e748800..2d253ef488188 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -162,16 +162,6 @@ oneOf: - required: - memory-region -# If memory-region is present, firmware-name may optionally be present. -# But if modem-init is present, firmware-name must not be present. -if: - required: - - modem-init -then: - not: - required: - - firmware-name - additionalProperties: false examples: