From patchwork Thu Nov 10 05:49:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Sit, Michael Wei Hong" X-Patchwork-Id: 17956 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp744279wru; Wed, 9 Nov 2022 21:52:46 -0800 (PST) X-Google-Smtp-Source: AMsMyM5xdQjWajvA1vhSYteoE++/cMbDiCuMVVJzIyIN3OIJHWwmmoAOGaba0U9uYQUFXDSQBxaB X-Received: by 2002:a50:a403:0:b0:461:b2b1:9702 with SMTP id u3-20020a50a403000000b00461b2b19702mr1625965edb.274.1668059566764; Wed, 09 Nov 2022 21:52:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668059566; cv=none; d=google.com; s=arc-20160816; b=JOAfgGbIeaZ8fHF7GP5k1AMaZb+KZ3aC6iBIBZJ+gNESDWLd+VQItWv5xFEcP15P0Y RIlohESiaGfxc0KMvLAVGczVwoRCrsqbAlLLRBhBUd1u5NNxZR/xca4Ht3MZRXcIwNw3 /IyCiyydMtM4w61Qhm/DIhS6L5yxb7MM89eRBwZYfu1fEvHZHcKE+XbV4+MN+o0l14ZI R2YXrA0fnAcxqo/u2N2hl6i+rpwKkQdcvS3orpHNhams3lqa3fFIJPU+cGdbezGVL1dT wXk5EJhQNG8Exas/Ek+9wyAmMuo4L3xtWtmlNdFKw08XaxVRwb+WDLvTV/ljoKTkoan7 +xaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gNGrJ0TL80XOLOYrlimEHJpPrih6h/tAYPnksTYvG1c=; b=QJTnKXM3AaEm1FbHchxN9QVSuVnI7AFOWjOMkpFkZ+wT+Dt7WYgZ13SxyaV5XAqeJJ SYuIrgkzmSnZkXn5dsTtAlSXLgLiA9rFMzd9xrfxZYsbVoAAGedKjr/V2PqsIw4Z1qki nHSjCzyHSuq+5B6A4EDWhlRGRp9ZH6wlQQnbbQ2lhYMdM5Ya0Q41Ycp5zPWt7oTZubZ3 EYshm1jivhZUyT7xMzS8HV2VNn4OhbR8Lxk4TprlYG1FtLBQpwH2GxsX+/C2bXIvPGk7 T8J6LoTassm+3x8wijABD+dX1bn9vZn9y2wodsvDC16k8SCsaYIMkEVdn4O0FctkVAV8 BbuQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iLg5nbLJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e9-20020a170906374900b007721f88d3e0si13158407ejc.554.2022.11.09.21.52.23; Wed, 09 Nov 2022 21:52:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=iLg5nbLJ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232167AbiKJFuc (ORCPT + 99 others); Thu, 10 Nov 2022 00:50:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229585AbiKJFu3 (ORCPT ); Thu, 10 Nov 2022 00:50:29 -0500 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A152186D7; Wed, 9 Nov 2022 21:50:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668059429; x=1699595429; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=jpaNDrFwzMZ2iLH1l1kbK43THTPUMBLW8XKIRWONvtQ=; b=iLg5nbLJ/uy01SpvOJ7gNLcVP2YPxfdnZQbYI2u5qhMyZ2tuRrs7C45w jOBVjk7jWZ3tiTfbaGrdnNNI4stxZKzOnd+U3XM4TXw3XmfyzbxPaSuyB hRaTk5Df9Jd2Ma6ajBF7cRSGpZznXo7ED3AjSoafqBpCXKCrnJYsS2QB3 /pLoDt7hHXkQ4ghM10Y0g5gczPRrUY1w0kNhurPSSYwPoi7ZmiMcaYvVH qUVGodAAULxhjmuhHtuJ2ZA5JzbVL8hdbadOzhvuOuCsbttij11//jwof hiOivzTddM6X8s48jM5p542WIrZJSGsXyAgG3tIgZxfMa74vIQkvKRekL g==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="298713473" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="298713473" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 21:50:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="631529192" X-IronPort-AV: E=Sophos;i="5.96,152,1665471600"; d="scan'208";a="631529192" Received: from mike-ilbpg1.png.intel.com ([10.88.227.76]) by orsmga007.jf.intel.com with ESMTP; 09 Nov 2022 21:50:23 -0800 From: Michael Sit Wei Hong To: Andrew Lunn , Heiner Kallweit , Russell King , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Tan Tee Min Cc: Lay Kuan Loon , Ong Boon Leong , Looi Hong Aun , Voon Weifeng , Zulkifli Muhammad Husaini , Gan Yi Fang Subject: [PATCH net v2 RESEND 1/1] net: phy: dp83867: Fix SGMII FIFO depth for non OF devices Date: Thu, 10 Nov 2022 13:49:38 +0800 Message-Id: <20221110054938.925347-1-michael.wei.hong.sit@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.4 required=5.0 tests=AC_FROM_MANY_DOTS,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749087228488724252?= X-GMAIL-MSGID: =?utf-8?q?1749087228488724252?= Current driver code will read device tree node information, and set default values if there is no info provided. This is not done in non-OF devices leading to SGMII fifo depths being set to the smallest size. This patch sets the value to the default value of the PHY as stated in the PHY datasheet. Fixes: 4dc08dcc9f6f ("net: phy: dp83867: introduce critical chip default init for non-of platform") Signed-off-by: Michael Sit Wei Hong --- v1->v2: - Add Fixes tag to commit message --- drivers/net/phy/dp83867.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index 6939563d3b7c..fb7df4baaf6f 100644 --- a/drivers/net/phy/dp83867.c +++ b/drivers/net/phy/dp83867.c @@ -682,6 +682,13 @@ static int dp83867_of_init(struct phy_device *phydev) */ dp83867->io_impedance = DP83867_IO_MUX_CFG_IO_IMPEDANCE_MIN / 2; + /* For non-OF device, the RX and TX FIFO depths are taken from + * default value. So, we init RX & TX FIFO depths here + * so that it is configured correctly later in dp83867_config_init(); + */ + dp83867->tx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB; + dp83867->rx_fifo_depth = DP83867_PHYCR_FIFO_DEPTH_4_B_NIB; + return 0; } #endif /* CONFIG_OF_MDIO */