From patchwork Wed Nov 9 17:46:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 17716 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp474753wru; Wed, 9 Nov 2022 09:50:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf4XtnBwb7PpaQfOmtmm9xLjG92qGRVJiAvvfWiy113G46xkZR33fN1NHfoZdFHGrM2DLp9z X-Received: by 2002:a50:bb67:0:b0:466:f299:bb32 with SMTP id y94-20020a50bb67000000b00466f299bb32mr1973061ede.307.1668016210839; Wed, 09 Nov 2022 09:50:10 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1668016210; cv=pass; d=google.com; s=arc-20160816; b=XG7YRxnjRp4AhpuvKJTkswHRZeoblH1/Q6hZBeqP/BdH7jaUXcBXUitUV3/neThl5o xTElISt8zv9u3Bg/GrvDTtyqIAi231UEOq/0JkbR9G6aeqo1zob4/CCxJHCYcZdov8qs iG9dovv+JcOej82dXe+fMCYl1THrSH55lL91Xjx5GTRv3MRgMnB/tohoxVv5T83j1HAM OjqM0vJizf29YqonGUPJmKy4cQ5yTmvv3XaqHAPCj2kYhk6yfIA65aodi5SUiqTWSbTD 8QaEa6leXJ1o2oYJAlo+3vPF4dSS/wm5OYBUEnXkCvsBXLZr7DMh/SpHZWStUQy7aGF6 6dvg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=kAn/CfaYg8T7hiRGZ/nflqMFNH7A7GqWKnsKdoQepcQ=; b=O+BQfvSnkr3eezI0XowgCS+Egd3WPMxWQzC6PJZvWw/iy3jchPZq11vDdOQZoQz5IU JMccp6RKtI5dCspfZT/lL4oE4q3XgziFACxmg5rF1tRHULa/Z2J+KArXPihQ5qC2+i9F LUftOqLgyjF/477ZyGgIN4HuY1jkr+h+AJLXg1EUCVCna/xROES2IMQIlOxi5k3LkShT aBth1EFUvwnBK6aQOiPcpTkwqCe5MP9QCePRRfzJKffMTdPkhOr6BxXMs59BMngnLEOQ xzZ9kuODKwAJ/fEP8EwP8dt0SreyaMIGgxAkCLpQYFWYG0vbhLhx4gwgFof4xr0MUnoi 8g2Q== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=tcSvj3es; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt20-20020a170907729400b0073d5a794b43si6817120ejc.985.2022.11.09.09.49.47; Wed, 09 Nov 2022 09:50:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=tcSvj3es; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231165AbiKIRqK (ORCPT + 99 others); Wed, 9 Nov 2022 12:46:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56670 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230222AbiKIRqI (ORCPT ); Wed, 9 Nov 2022 12:46:08 -0500 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DCDD64FD for ; Wed, 9 Nov 2022 09:46:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MHfsFUJzMTs+moow60vQwInpGBHbPKoN+2yepis2x+ak1hoGjoHau/AsgPmAGqWWV7efUAk+kQScmH6G3SjMzXG6wXGiS8ubzqymrz5/rebKO+VApNedwlyeg7nO9M5muTHCEqHNJNpCkkKCWA2h9Vzv9aWEx6xd4r/6qkBxQp3DNKVc+MxQmI+QSsfDPkWp5/FDndFxvnj/x9JCP4JiQrJ5m5HFo54L2Zp1BICJ/RvNuwTcVTQ0ac9aovUq61Tt8Vqt1YiEHnm5HVlijPDGqUSSmXdMcnTAVUcd7icWxe/Soo9QcKX9qSbhvi10V7Ecbc5bSWKNr7dQSe7VclE1ZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kAn/CfaYg8T7hiRGZ/nflqMFNH7A7GqWKnsKdoQepcQ=; b=E8ezOiLCwvgilgOLQTotx0kUNbuQ9X5YtIpCSbDX7E2Q3OzkhtdU96hMvhb5LGI0AoUsdtsNcIyDdM08LWDwHzmn+F72uSaL2iDXnkA/rKahVmUAfl6pCvYb4hoDGaeBAJ0/OyBZI1ztJSKjc2/bd2+KrS1stCI0E/FU39iyIcq/bNVk4wkWCIEeZEJGzSE4zbk86rGAIGVaVWIGF+f2rQRRX+NF4kEnO6HPmmmRpWJMZxusI2M1GhkLHMTBlFAf0BD2RENAXbECu4tnhQIG96fZHeY24KntZdzJUhbBJVI4A687sVAHSvE1WE3aLr54WWW5I32SLC5xu1hin0MkXw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kAn/CfaYg8T7hiRGZ/nflqMFNH7A7GqWKnsKdoQepcQ=; b=tcSvj3esFf09eoAgdl9kwPjIo1UM3CAZPa/Pp7zBXRQXLpbeYUpXfk4oYKNavRGEaU7laFqgzuDrzSYbSG1SpPTg0TPdOLWSjR1kiTPdFZ93Kq3jN31LT/AkdjIIINSXXZDRAO7MzQpeDo7G8kJKqm6AOlarmzKgqvt9qO+sD3k= Received: from DM6PR08CA0050.namprd08.prod.outlook.com (2603:10b6:5:1e0::24) by PH7PR12MB5687.namprd12.prod.outlook.com (2603:10b6:510:13e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.27; Wed, 9 Nov 2022 17:46:04 +0000 Received: from DM6NAM11FT107.eop-nam11.prod.protection.outlook.com (2603:10b6:5:1e0:cafe::6f) by DM6PR08CA0050.outlook.office365.com (2603:10b6:5:1e0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 17:46:04 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT107.mail.protection.outlook.com (10.13.172.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 17:46:04 +0000 Received: from hamza-pc.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Wed, 9 Nov 2022 11:46:02 -0600 From: Hamza Mahfooz To: CC: Hamza Mahfooz , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= , "Pan, Xinhui" , David Airlie , Daniel Vetter , Nicholas Kazlauskas , "Roman Li" , Fangzhi Zuo , Aurabindo Pillai , , Subject: [PATCH] drm/amd/display: only fill dirty rectangles when PSR is enabled Date: Wed, 9 Nov 2022 12:46:27 -0500 Message-ID: <20221109174628.150234-1-hamza.mahfooz@amd.com> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT107:EE_|PH7PR12MB5687:EE_ X-MS-Office365-Filtering-Correlation-Id: 879d6752-1cd8-4595-4567-08dac27a4616 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6l7DexLWkh2HOEYjvm+TXdTK11zUixmHgEeT7Po0sqCFO4+sF3u+4LzX8F9oAv7OFzf4IXF5nCHygAR9/WpmrcsvW4/DxpPe9YDi4NUk8pZb9oJwZQe3gdZU9RswsoN4nA7plKca77XRctq+b5BVE07N19oHzghvS2K5g1Mtevypp1S0wOoQ2EBRt4ch4ZhPpmPGQpcpIHfQBEn3xXW5zOkIg/ydvoTeFa/7gA/5logIy0SftXKuf6S73m90rsfFnzL909cIrbc51+/AfwfZAY2bBQZHfOSagKY8Th/2g3kBKmXkqduLr+jhWRaVfuNgDfa/eNwGxBQNQxMVDVZ2SMrGAtCFz/gZo/AdB6ihTmPGLje5Mw+Vp2SUGJrMgePFsHxQuWuynEMdCsX0swoTbG/hGfzZagJk4cX+7ItRyfPZo4B3+uITM43joeamPxpbZmZa65Q7CBHAleOttrP24dHiu/KaSB+UBH3GhiXxcLM1wAwFv9VmFA5iLBFcdl4iENNDAY280d+pkZ20QU8DgNfzulPsvhY4rdEwBZ4JILBUqtfiGCGzzMNtyCygnPGBydyaqz2lSVeSM89g3/bpRTcNST8HSZ/uubT/DkC/WJl8Oo1dWu/JymiBfaV22e4L/IAq3fXg9wbv67Rp3ScmnO/WXwrOhD7WU66IK1jeO7aOjF5jdjpWQjNeu++xT6EpWcNh9/HHK/iwNkj82Whc93Awipv+AQw4Zf2gV4PWr21qyw0JfI7nShEHGxLKu1oWPDwj8IlLkDKLpR4aMgN5jYI7ATlDpDPK1Ba1deEBBD/i7dpfUwNNL1ImjYrTSxqnrGA9lEBaTty25wBLq8/DorHs6QUBKk8EDL5eSli3VS0= X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230022)(4636009)(396003)(39860400002)(136003)(376002)(346002)(451199015)(46966006)(36840700001)(40470700004)(70586007)(70206006)(82740400003)(26005)(8676002)(4326008)(316002)(2906002)(7696005)(47076005)(40480700001)(426003)(336012)(83380400001)(36860700001)(44832011)(40460700003)(86362001)(16526019)(186003)(1076003)(5660300002)(2616005)(41300700001)(36756003)(8936002)(82310400005)(478600001)(6666004)(356005)(81166007)(54906003)(6916009)(14143004)(16060500005)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 17:46:04.3228 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 879d6752-1cd8-4595-4567-08dac27a4616 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT107.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5687 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749041765895004786?= X-GMAIL-MSGID: =?utf-8?q?1749041765895004786?= Currently, we are calling fill_dc_dirty_rects() even if PSR isn't supported by the relevant link in amdgpu_dm_commit_planes(). So, we can instead limit the filling of dirty rectangles to only when PSR is enabled. Signed-off-by: Hamza Mahfooz --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 66eb16fbe09f..956a6e494709 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -7697,9 +7697,10 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state, bundle->surface_updates[planes_count].plane_info = &bundle->plane_infos[planes_count]; - fill_dc_dirty_rects(plane, old_plane_state, new_plane_state, - new_crtc_state, - &bundle->flip_addrs[planes_count]); + if (acrtc_state->stream->link->psr_settings.psr_feature_enabled) + fill_dc_dirty_rects(plane, old_plane_state, + new_plane_state, new_crtc_state, + &bundle->flip_addrs[planes_count]); /* * Only allow immediate flips for fast updates that don't