diff mbox series

[3/5] ARM: dts: nanobone: Enable I2C temperature sensor

Message ID 20221109160904.183147-4-mpfj@newflow.co.uk
State New
Headers
Series ARM: dts: nanobone: Fix missing/incorrect features |

Commit Message

Mark Jackson Nov. 9, 2022, 4:09 p.m. UTC 
  The NanoBone platform supports a temperature sensor on the I2C bus.

Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
---
 arch/arm/boot/dts/am335x-nano.dts | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Krzysztof Kozlowski Nov. 9, 2022, 4:23 p.m. UTC | #1 
On 09/11/2022 17:09, Mark Jackson wrote:
> The NanoBone platform supports a temperature sensor on the I2C bus.
> 
> Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> ---
>  arch/arm/boot/dts/am335x-nano.dts | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> index cecc2afaeff4..2be831927af6 100644
> --- a/arch/arm/boot/dts/am335x-nano.dts
> +++ b/arch/arm/boot/dts/am335x-nano.dts
> @@ -212,6 +212,11 @@ &uart5 {
>  	status = "okay";
>  };
>  
> +temperature-sensor@48 {
> +	compatible = "lm75";
> +	reg = <0x48>;
> +};

This should not work - you put the node in some random place.

Best regards,
Krzysztof
Mark Jackson Nov. 9, 2022, 4:45 p.m. UTC | #2 
On Wed, 9 Nov 2022 at 16:23, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/11/2022 17:09, Mark Jackson wrote:
> > The NanoBone platform supports a temperature sensor on the I2C bus.
> >
> > Signed-off-by: Mark Jackson <mpfj@newflow.co.uk>
> > ---
> >  arch/arm/boot/dts/am335x-nano.dts | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
> > index cecc2afaeff4..2be831927af6 100644
> > --- a/arch/arm/boot/dts/am335x-nano.dts
> > +++ b/arch/arm/boot/dts/am335x-nano.dts
> > @@ -212,6 +212,11 @@ &uart5 {
> >       status = "okay";
> >  };
> >
> > +temperature-sensor@48 {
> > +     compatible = "lm75";
> > +     reg = <0x48>;
> > +};
>
> This should not work - you put the node in some random place.

Ah yes, that should be within the I2C block.
I'll fix that.

Cheers
Mark J.
kernel test robot Nov. 11, 2022, 6:23 p.m. UTC | #3 
Hi Mark,

I love your patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on linus/master v6.1-rc4 next-20221111]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mark-Jackson/ARM-dts-nanobone-Fix-missing-incorrect-features/20221110-001039
base:   https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
patch link:    https://lore.kernel.org/r/20221109160904.183147-4-mpfj%40newflow.co.uk
patch subject: [PATCH 3/5] ARM: dts: nanobone: Enable I2C temperature sensor
config: arm-randconfig-c033-20221110
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/9680450145373c2afeda388991a4a3929a5dfb60
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mark-Jackson/ARM-dts-nanobone-Fix-missing-incorrect-features/20221110-001039
        git checkout 9680450145373c2afeda388991a4a3929a5dfb60
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/am335x-nano.dts:215.1-22 syntax error
   FATAL ERROR: Unable to parse input tree
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/am335x-nano.dts b/arch/arm/boot/dts/am335x-nano.dts
index cecc2afaeff4..2be831927af6 100644
--- a/arch/arm/boot/dts/am335x-nano.dts
+++ b/arch/arm/boot/dts/am335x-nano.dts
@@ -212,6 +212,11 @@  &uart5 {
 	status = "okay";
 };
 
+temperature-sensor@48 {
+	compatible = "lm75";
+	reg = <0x48>;
+};
+
 &i2c0 {
 	status = "okay";
 	pinctrl-names = "default";