From patchwork Wed Nov 9 15:07:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 17630 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp386920wru; Wed, 9 Nov 2022 07:08:43 -0800 (PST) X-Google-Smtp-Source: AA0mqf4QmVWDoSkJinoyiub8MZ/bXa6yFnqcuyIExs1FkWE74YF7YPK4O3vQ4RujTlYRATj3Sbb0 X-Received: by 2002:a17:907:2061:b0:7ae:71d4:37b with SMTP id qp1-20020a170907206100b007ae71d4037bmr512099ejb.237.1668006523361; Wed, 09 Nov 2022 07:08:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1668006523; cv=none; d=google.com; s=arc-20160816; b=y+oQpquPRn/dsQe5jnc6HDh+f7Siu/4WZ0REDby/WRNbed3zHD5zlA6KzTdl6yTAC4 vwHmsCE/UMDB21cPY/CMvRE3TE0n+a+QqiAtzI8o4pXIS+Qu/Va9WksVySi6MqOAZGCP Uhg4j3X+0XBEKCNQ1+owoRbAMZBuAcrvAKuxYoNCNZJOPSk6syUyvIMf3lrd+p23hV54 bH++XgVR+14Jx+x5tE44x+IL3as1Au5b+XkZ8h7tdSssdwcInsQy7Xn8QITpa4VQ27XL qErTCbPaVHt8uTyhXmkIpgRI6rmEY1XvcyzbZ5as5QUJqXaBshg1w0gzlBYykb2LgNCG qaBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=84+Ai4MfAsUeQCK9niTUi97Q2QEGp4zHAKkL0AKPseQ=; b=K9a/HGTir2Nak7F8QLLc2urqdgd/xzywtDBd1vDAw8cYfmXBKM6kpYEtVk5qa3sdGF FAkw/ZbHpowK+vYVlUorDBjt8N7KDi/T7Yylpk3vciFXg9BcjW4tAHqlniZtobd7/tqR m659BdQ91KEAbiX/WICqjk8/SL3f6htUcGQcU7Uw7CYrdGxMwIuSC33Pp5jvMi6L6GPp /pxIpkO6/qgLnhq3yaSmmr6cCAnnofIgQayTGdkl7gx+TOyuf8Thg7SLNaEScv5cvPAR CWJ8QDiY+dyearSAaLGrF9weBC9gNi6ASG67vacW7foj1g+v8E0cv+3vJ7GCYBhFeed6 DMbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Dx3fWmbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o7-20020a17090608c700b00791a67e4c00si12605109eje.835.2022.11.09.07.08.18; Wed, 09 Nov 2022 07:08:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Dx3fWmbC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231867AbiKIPHD (ORCPT + 99 others); Wed, 9 Nov 2022 10:07:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231758AbiKIPG4 (ORCPT ); Wed, 9 Nov 2022 10:06:56 -0500 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5AD301A810; Wed, 9 Nov 2022 07:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668006415; x=1699542415; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=vkdjifLpDIz2k79GbiPxj/nDQjo5PWlLax+xg6MpmuQ=; b=Dx3fWmbC83bjOofNg7hcMScn6sDLjHaojN+vk7xw31mLB0rJVrSSQWOG IE4cGnA46O+Sc2hQ3MHOR2o7x4B3YwydzJlX1RYEWRCAWOxzP6MeFvQtI YygVFSozW4h0ZOWRpTsVxEWY2UDMOt1OkYjopkBHOIZafvjR14iHF8KEG aCzo/zbjmYDidEODMSnOP+jUSBB3DKrdM0/+oF0aRKL8k9OtgE1ZQtnkZ gtdJdVMssfnXB1gnfXOj9sbqnusY41Md6ra1iHVAuv6V/dVoBzkLyr78n sN2QS5FjAfoAK96JmDvDUV3WXUbGUj/LvVENAOZ1m8HbOx5LdNB5+rED3 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="291386812" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="291386812" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Nov 2022 07:06:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10526"; a="705736758" X-IronPort-AV: E=Sophos;i="5.96,150,1665471600"; d="scan'208";a="705736758" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga004.fm.intel.com with ESMTP; 09 Nov 2022 07:06:45 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4AF91155; Wed, 9 Nov 2022 17:07:09 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Raul E Rangel , Bartosz Golaszewski , Dmitry Torokhov , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg , Linus Walleij Subject: [PATCH v1 1/2] gpiolib: of: Drop redundant check in of_mm_gpiochip_remove() Date: Wed, 9 Nov 2022 17:07:05 +0200 Message-Id: <20221109150706.38823-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749031607964913974?= X-GMAIL-MSGID: =?utf-8?q?1749031607964913974?= The callers never call the function with invalid pointer. Moreover, compiler quite likely dropped that check anyway because we use that pointer before the check. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpiolib-of.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index feeb9e8e846d..83997434215e 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -963,9 +963,6 @@ void of_mm_gpiochip_remove(struct of_mm_gpio_chip *mm_gc) { struct gpio_chip *gc = &mm_gc->gc; - if (!mm_gc) - return; - gpiochip_remove(gc); iounmap(mm_gc->regs); kfree(gc->label);