From patchwork Wed Nov 9 12:29:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Dumazet X-Patchwork-Id: 17536 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp307273wru; Wed, 9 Nov 2022 04:36:06 -0800 (PST) X-Google-Smtp-Source: AMsMyM4/cW8eJFAAH9hl7V+EcNFyLThJA2jguBVZG5Oald30BK7UvGroHNk5iMEwtL4VyaSuYL5N X-Received: by 2002:aa7:d6d1:0:b0:463:ba50:e574 with SMTP id x17-20020aa7d6d1000000b00463ba50e574mr41922337edr.158.1667997366117; Wed, 09 Nov 2022 04:36:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667997366; cv=none; d=google.com; s=arc-20160816; b=rI6THKS5SXBcgRBHy8I7hjg498/A4J3UjnGxJsn3dKXOwol5RWs40wo424NJJ5InvP XX9vzQydbFf+e0lrOljIX3byW1+XMoSZa7bT2fz72koHLykMwrd6kDZXk8sPso/bqwpd Vb8UAVoKyYd2Z4RuPcLTTvGKYOYdxyDQXrJ9a6+OZP6gxclH+/R8M/Wu/+DNtvZ1nyXk Thmk1IILhgQ4pbvhYv93dueIDhaI3JOabFHcgFjKXK/Z97wbuH+ns0OT7TgTUtMrwBfb WImT8D8qudtqdCIc41D/V38m+ezDicnCUcW1WsCa2r4ruxs5PEKCAdaxP03tx/hgVRq8 4irQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=hfm2vkzYg9/wh9COPQNzqW4Ldq8cdkzQ10RWJLbmXvY=; b=gDZPA4//oe+7Q+X7Ak5StHmj3pX0iv83koO/ycIpxtMJzIocEmQOHIiomaK8ypxo5k P3zPydRNCG5MRemIiKOy5u/xaQ8CfqVsFkoC2DFDUDpPIDoDHD+OBiJSG8i94pCpGZLS /JWxFe+E/Kkrxm1a9aHoZ6QkiRoJsefXc81dcIBJcW4vKoEvAPJlpEgGpR22/meuzV2P otme5kzwUS+aA8lm1IChbswskfT+Au6qkFFiVzmhTYrrUQ/4KR251G6/fP0kvr4TJeWk S0P7P2w4NEZd+8kC2w6F4QXO+XQwHCcB3Za1nmFNbSvbZZQrClxKDrCW1KwQBYlYPcI4 poDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=NNM5Yuz+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id o21-20020a170906975500b00797670441desi18040991ejy.911.2022.11.09.04.35.41; Wed, 09 Nov 2022 04:36:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=NNM5Yuz+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229587AbiKIMaI (ORCPT + 99 others); Wed, 9 Nov 2022 07:30:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiKIMaG (ORCPT ); Wed, 9 Nov 2022 07:30:06 -0500 Received: from mail-ed1-x549.google.com (mail-ed1-x549.google.com [IPv6:2a00:1450:4864:20::549]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 440041DDFB for ; Wed, 9 Nov 2022 04:30:02 -0800 (PST) Received: by mail-ed1-x549.google.com with SMTP id y20-20020a056402271400b004630f3a32c3so12630765edd.15 for ; Wed, 09 Nov 2022 04:30:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=hfm2vkzYg9/wh9COPQNzqW4Ldq8cdkzQ10RWJLbmXvY=; b=NNM5Yuz++db6o9H0S+lALNGLamT6qyFGnjbiq+Q8DlXH1LGbRq9WswSV/NBqkGLp2z ccMXOzT1RDWLcN8ypsNpStSb3HvKOV+Q6haARhTbliony8JSOfPuAHCHabfhMGijGZpz qLOqv6meYGwGKNgkYVkFAhifAVzhvjTzgeNvHln1WlvMD000AcpN1aV3+xN+vnKktLYD gHTfCsMhgav+v1lczkjfs7WeZX6tzUSYt7Z3+7Ly+psXOlWp1FqGML3ydqgbo+2C7/WX oFpgetQLIIzmuJ+/2dqBgKvJ8DNWOjWLs0/JsTxWT7jZUPojKje/hgKbnolC/6wuaFAO 8psg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=hfm2vkzYg9/wh9COPQNzqW4Ldq8cdkzQ10RWJLbmXvY=; b=DvoFPJk8WTjFAwt2R4RP1PMv59mAhx9Zl/217Zs5JK25V0IarcQrLvM0RYd4rcMr/c vlJEhqql608FRvdERBSrYakaaTAcuhDYx8VzHSkPLXUhJ7W91zgeV+Ku/+zPPdO8RZRw qV1uYd+XPGVPKN9NZYBbbzU3e8k0NEUmWnIdqtpczmKkOzFZdZK3lGg/0PHwjRdeCWJn cM59tKrrEHJdC4XbPoIXNlDs5VRMcGXez+2/72LipRwaJ71omMHOGiAvpS/OhpU7MGfA 0ftk0tIJ2JEI30d+W8h3shR2UNkiwPJ4P/9Y+AfCwU0UqiShPcf+3VLo/AkT4OIvg9Rt 2V2g== X-Gm-Message-State: ACrzQf0Y4F9nAO74ff1lzlNOr1PH963W4TQqbHwDCMpx8ovLzzL7puk2 jesREUBI6kp7j0Ovn6jQeVN4xxT93cHsrQ== X-Received: from bistanclaque.zrh.corp.google.com ([2a00:79e0:42:204:64:5e47:7c33:fbda]) (user=ndumazet job=sendgmr) by 2002:a17:907:1dec:b0:7aa:6262:f23f with SMTP id og44-20020a1709071dec00b007aa6262f23fmr23487247ejc.38.1667997000591; Wed, 09 Nov 2022 04:30:00 -0800 (PST) Date: Wed, 9 Nov 2022 13:29:46 +0100 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog Message-ID: <20221109122946.706036-1-ndumazet@google.com> Subject: [PATCH v3] usb: add NO_LPM quirk for Realforce 87U Keyboard From: Nicolas Dumazet To: Greg Kroah-Hartman , Jean-Francois Le Fillatre Cc: Petar Kostic , Oliver Neukum , Ole Ernst , Hannu Hartikainen , Jimmy Wang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Dumazet , stable@vger.kernel.org X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749022006134467945?= X-GMAIL-MSGID: =?utf-8?q?1749022006134467945?= Before adding this quirk, this (mechanical keyboard) device would not be recognized, logging: new full-speed USB device number 56 using xhci_hcd unable to read config index 0 descriptor/start: -32 chopping to 0 config(s) It would take dozens of plugging/unpuggling cycles for the keyboard to be recognized. Keyboard seems to simply work after applying this quirk. This issue had been reported by users in two places already ([1], [2]) but nobody tried upstreaming a patch yet. After testing I believe their suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a little overkill. I assume this particular combination was tested because it had been previously suggested in [3], but only NO_LPM seems sufficient for this device. [1]: https://qiita.com/float168/items/fed43d540c8e2201b543 [2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/ [3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477 Cc: stable@vger.kernel.org Signed-off-by: Nicolas Dumazet --- Changes: * v2 -> v3: fix s-o-b / patch format. * v1 -> v2 : add the entry to the right location (sorting entries by vendor/device id). --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 0722d2131305..079e183cf3bf 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -362,6 +362,9 @@ static const struct usb_device_id usb_quirk_list[] = { { USB_DEVICE(0x0781, 0x5583), .driver_info = USB_QUIRK_NO_LPM }, { USB_DEVICE(0x0781, 0x5591), .driver_info = USB_QUIRK_NO_LPM }, + /* Realforce 87U Keyboard */ + { USB_DEVICE(0x0853, 0x011b), .driver_info = USB_QUIRK_NO_LPM }, + /* M-Systems Flash Disk Pioneers */ { USB_DEVICE(0x08ec, 0x1000), .driver_info = USB_QUIRK_RESET_RESUME },