Message ID | 20221109115047.2921851-7-senozhatsky@chromium.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp289588wru; Wed, 9 Nov 2022 03:55:44 -0800 (PST) X-Google-Smtp-Source: AMsMyM4ZTIMu5ooixdbVTHsK+8HQSeipelid4g1WrCtDjlo53CCkQFkIBpvTa+3ldVObDiO7ahz9 X-Received: by 2002:a05:6402:410:b0:451:ea13:4ed7 with SMTP id q16-20020a056402041000b00451ea134ed7mr62105297edv.262.1667994944342; Wed, 09 Nov 2022 03:55:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667994944; cv=none; d=google.com; s=arc-20160816; b=IvWzvh9ZXcgc3csk9/TqEBKSiCSqsYTf/wCZB3Q9oDclZ2e8856LQlIBIVgmQiSZ2u 9OaEciyga8y5jD5FBL5oBkxk0JhCCjOqn1WEjnHX+zSj6ukm6k9TFGuWQAUuUVRa2Tiq 78vGF8FIfN8aYR8ftkTNWZfKVO8TGQ0/B1QvnYcpBmtKBuGkjD2D1lcFSAtzV+rWIA0f FHMpikyjQUc8/cUUPqnJPNtwoZlUg2KQqtV+IBW7X/0cy2rnGLu7xZvG3GvpzXBe0MLX O3am5iHyiuStYJgZQnyYQDPbWRjrbTyreSHofo5q+XskkKPmVnDkCczdCtKc/Lxal7zH wQSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Yx/j6NFsqMiBfWUe9MAE1kY4nyT9uBWrAowemE/mjWM=; b=ZBQDkh5EXm9Fk5PLwShZhD7irP9y/i7PxemUWUkdRBD4BUOJVcfajDWRkXumvoE4Mn kSVakZQGKV84w+mU2F1P4hNdQRXo89H9xZAdHq/6cQ03A1TKDi204LDAQPmutbVAtMn5 KLJR30r15m3afCnQXqr7I+kaWLLsjWqn0GlWfix5sKssr7NwJk8XmPeVFyXP6UMPR3JH eu5KmKgky7hezAkVivGF3EMKUjyPZCkBfAGaJM1TzwShOZTQ/ZAUne5eQ01BrKtXFb0i 8rx6sR+t+k+yJAOvkxlLWgux2N7gu5uNT7GMSjU/a7kwZD8FEZUB2z1PcjFxUmTm1Xhf icTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PRtW06hq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u22-20020a17090617d600b007ae83c7b8desi2820652eje.59.2022.11.09.03.55.16; Wed, 09 Nov 2022 03:55:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=PRtW06hq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231259AbiKILve (ORCPT <rfc822;dexuan.linux@gmail.com> + 99 others); Wed, 9 Nov 2022 06:51:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbiKILvR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 9 Nov 2022 06:51:17 -0500 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A9D073120B for <linux-kernel@vger.kernel.org>; Wed, 9 Nov 2022 03:51:10 -0800 (PST) Received: by mail-pf1-x42b.google.com with SMTP id g62so16446193pfb.10 for <linux-kernel@vger.kernel.org>; Wed, 09 Nov 2022 03:51:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Yx/j6NFsqMiBfWUe9MAE1kY4nyT9uBWrAowemE/mjWM=; b=PRtW06hqJjnQd/kkrH5EdBvx+MeI+nT/zaRSXLQ34yFFZSjedoVDMt0ITBHY9lEJZL zv+rYGTJbr/jbll1pBLICDHoduO6RLnRUwbZgzJ4UPSTNt9sozFtY/xW98UZAXvjbMTU R6GqKRwlu/wYEXfZCbhs9SLFZ3xhLlXZm6oO4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yx/j6NFsqMiBfWUe9MAE1kY4nyT9uBWrAowemE/mjWM=; b=UF20SpYEhxMp7TEtADMjmrMrgPjyGXR1iqxPosJzZd2hWdolmiDp59JH0BHhlf5+FL q9dlYy4fP8/yNyMVguhNvN+O7beXyJIDahA16l6cl391WlTMN8UCefS/FRc4Oc+nmjjA 8OnqR1LzpDoPmL3vk09c0p/icOUK4SW8Gc13RDT1K0IzbJNy/8g0ITOvJ/rX85AAyZ74 b1CP/5SabSjSq40u1jqYTSnG8whfG3IpKIJwjAosCYRvZh16FqmRTXNmy+ee0GNm4BFV 2J2fPDhLemiD8ed1LRpX0dBtOiXwl8nFKBhB8BRI9XSzud/EgFD3MHC5p7nahRJ0wO3M 2UxA== X-Gm-Message-State: ACrzQf0igTZYUfnhlDVsrxDvT9pkvI/HDadfAdbRKlYKGkrTBxBwg1br hl8CCvC9wpFPhQEPlMslCGi2x7FxON+OGg== X-Received: by 2002:a63:f755:0:b0:44b:e438:ef2f with SMTP id f21-20020a63f755000000b0044be438ef2fmr52609729pgk.314.1667994670169; Wed, 09 Nov 2022 03:51:10 -0800 (PST) Received: from tigerii.tok.corp.google.com ([2401:fa00:8f:203:61f1:44d3:3f47:2cdb]) by smtp.gmail.com with ESMTPSA id f5-20020a655505000000b00434760ee36asm7292311pgr.16.2022.11.09.03.51.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 03:51:09 -0800 (PST) From: Sergey Senozhatsky <senozhatsky@chromium.org> To: Minchan Kim <minchan@kernel.org>, Andrew Morton <akpm@linux-foundation.org> Cc: Nitin Gupta <ngupta@vflare.org>, Suleiman Souhlal <suleiman@google.com>, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sergey Senozhatsky <senozhatsky@chromium.org> Subject: [PATCHv5 06/13] zram: Clarify writeback_store() comment Date: Wed, 9 Nov 2022 20:50:40 +0900 Message-Id: <20221109115047.2921851-7-senozhatsky@chromium.org> X-Mailer: git-send-email 2.38.1.431.g37b22c650d-goog In-Reply-To: <20221109115047.2921851-1-senozhatsky@chromium.org> References: <20221109115047.2921851-1-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1749019466586103911?= X-GMAIL-MSGID: =?utf-8?q?1749019466586103911?= |
Series |
zram: Support multiple compression streams
|
|
Commit Message
Sergey Senozhatsky
Nov. 9, 2022, 11:50 a.m. UTC
Re-phrase writeback BIO error comment.
Reported-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sergey Senozhatsky <senozhatsky@chromium.org>
---
drivers/block/zram/zram_drv.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 560e2932021e..a5d2ce0bcd5d 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -772,8 +772,12 @@ static ssize_t writeback_store(struct device *dev, zram_clear_flag(zram, index, ZRAM_IDLE); zram_slot_unlock(zram, index); /* - * Return last IO error unless every IO were - * not suceeded. + * BIO errors are not fatal, we continue and simply + * attempt to writeback the remaining objects (pages). + * At the same time we need to signal user-space that + * some writes (at least one, but also could be all of + * them) were not successful and we do so by returning + * the most recent BIO error. */ ret = err; continue;