diff mbox series

[-next,3/3] ftrace: Delete unused variable ftrace_update_time

Message ID 20221109094434.84046-4-wangwensheng4@huawei.com
State New
Headers
Series Optimize code for ftrace |

Commit Message

Wang Wensheng Nov. 9, 2022, 9:44 a.m. UTC 
  ftrace_update_time is not used anywhere else after initialization. So
delete it together with its initial code.

Signed-off-by: Wang Wensheng <wangwensheng4@huawei.com>
---
 kernel/trace/ftrace.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Steven Rostedt Nov. 17, 2022, 8:36 p.m. UTC | #1 
On Wed, 9 Nov 2022 09:44:34 +0000
Wang Wensheng <wangwensheng4@huawei.com> wrote:

> ftrace_update_time is not used anywhere else after initialization. So
> delete it together with its initial code.

Thanks for the first two patches. They are definitely fixes and I plan on
testing and adding them to my next pull request.

As for this one, this has been more of a reminder for me to one day (I
know, it's been years!) to export this to see from user space. I sometimes
do it manually with a printk(), but it should probably be always shown.
Perhaps in dyn_ftrace_total_info ?

-- Steve
diff mbox series

Patch

diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
index 43a958b28022..3e102c44b117 100644
--- a/kernel/trace/ftrace.c
+++ b/kernel/trace/ftrace.c
@@ -3110,7 +3110,6 @@  int ftrace_shutdown(struct ftrace_ops *ops, int command)
 	return 0;
 }
 
-static u64		ftrace_update_time;
 unsigned long		ftrace_update_tot_cnt;
 unsigned long		ftrace_number_of_pages;
 unsigned long		ftrace_number_of_groups;
@@ -3130,13 +3129,10 @@  static int ftrace_update_code(struct module *mod, struct ftrace_page *new_pgs)
 	bool init_nop = ftrace_need_init_nop();
 	struct ftrace_page *pg;
 	struct dyn_ftrace *p;
-	u64 start, stop;
 	unsigned long update_cnt = 0;
 	unsigned long rec_flags = 0;
 	int i;
 
-	start = ftrace_now(raw_smp_processor_id());
-
 	/*
 	 * When a module is loaded, this function is called to convert
 	 * the calls to mcount in its text to nops, and also to create
@@ -3173,8 +3169,6 @@  static int ftrace_update_code(struct module *mod, struct ftrace_page *new_pgs)
 		}
 	}
 
-	stop = ftrace_now(raw_smp_processor_id());
-	ftrace_update_time = stop - start;
 	ftrace_update_tot_cnt += update_cnt;
 
 	return 0;