From patchwork Wed Nov 9 02:50:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Patchwork-Id: 17324 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp105701wru; Tue, 8 Nov 2022 19:02:06 -0800 (PST) X-Google-Smtp-Source: AMsMyM4S3lY3Q8/pi0nl2y4txx7H9kyEi6q34Yc7LZ0kIs8V3MDXACFrhCBePxEjwr/fTlFE+xBO X-Received: by 2002:a17:90b:3b44:b0:213:34f7:facb with SMTP id ot4-20020a17090b3b4400b0021334f7facbmr78522410pjb.150.1667962926061; Tue, 08 Nov 2022 19:02:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667962926; cv=none; d=google.com; s=arc-20160816; b=sfSqNQQvc5Sro9TvUMEPwZfvVkVoyElgJ3fv7zWqYrh+96r8zKPHF2iVr2oweAsBwk pnz7EzmtKOz+tVaB8ptQUcvFjCdueJ2JpygCtVpzTi+d3r02+sMc+l83VdGJ3l+nV1tj 3hzgCzakfIhS+1Lo6OiKWHhTWaqoPSg48DjPGDqnVopbUm5yA8mrxvPe+4laHIzXvrGO 4ks2hxxpiuV7uJL75NXobZlxotMAo0TGk7/xjwV7WRVFMRNOJZYfsLohttaffN11Vk6Y Y8t5rnSxqawq91uVzNOIxthBcjF6xOVaKQUpNyN1opbEgE3yIzPw1yGmAURWOueKHXQd ITvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:dkim-signature :from; bh=mg8/bHYa+/IfZ5sz/GzGGJbcLE18sRWdGW/pDYF26pQ=; b=BsWBydEJvh8voyoT1SbpNDHtSPye+Er5cLzJzX2zl9qe+sK2pq00nxY3Rn2keX/SmP LPK3vn8C2usdnrwK4zc8YJhjyJzaHVV33LZFP+OSyBIjb8bCotSQxgMRta+1h50f+/Lb nKJkWICpHpTIZkpqC7oY4XMb48nfsmOADV5EwFmX7HuQqwpzvWs6aS29l48ibaujJdai teFnpURZXXvr33bsW8AMO3LRjKtyP6ibE8sUVsikh6j3m63qYt+5ga1Wce8+AApagALM DJqxI7dezWyNUJ2M07JWQf1J0fHXprB+hdEjsbqCIVSA98KFLqdVcS33QJ/mki6Wntgz 1ysg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b="RFw/Vm2E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id f189-20020a636ac6000000b004701ea564desi15618151pgc.783.2022.11.08.19.01.50; Tue, 08 Nov 2022 19:02:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@weissschuh.net header.s=mail header.b="RFw/Vm2E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230075AbiKICuf (ORCPT + 99 others); Tue, 8 Nov 2022 21:50:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229667AbiKICue (ORCPT ); Tue, 8 Nov 2022 21:50:34 -0500 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFC381F61A; Tue, 8 Nov 2022 18:50:32 -0800 (PST) From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=weissschuh.net; s=mail; t=1667962230; bh=COwXzoOJifc0kBYkrsDthoC7PqTOtSdi1o8MWvrZGvg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=RFw/Vm2E83YIgHtWCxE5pbYZhS4CloQ/BWpqQZOVwojSlxti2713CWbtT7DfN5yex g+GGsYBsuKhOCeD7QxLbnztD1C/IDyi5+pGFTD9AtpIONjJbQEGJyO1z11FSBTMNjk uEi8dEEMGzSajlt2uIl9vEakOIORMif0rUAKe1AA= To: =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , David Howells , David Woodhouse , Jarkko Sakkinen , Eric Snowberg Cc: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, Mark Pearson , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org Subject: [PATCH v2 1/3] certs: log more information on blacklist error Date: Wed, 9 Nov 2022 03:50:17 +0100 Message-Id: <20221109025019.1855-2-linux@weissschuh.net> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221109025019.1855-1-linux@weissschuh.net> References: <20221109025019.1855-1-linux@weissschuh.net> MIME-Version: 1.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1667962214; l=781; s=20211113; h=from:subject; bh=COwXzoOJifc0kBYkrsDthoC7PqTOtSdi1o8MWvrZGvg=; b=9x5DbFNV4IeM4Iy0DtoCRUoozHmclKCE+cEgSF4HGqidC0TEXqxiB6lTgA07FCcRuKVcFFgwwsn5 B8EN0PttAwXE0P3l+2gc7DGNn+b1Zq+W6/XVyg0ViLI7WWqXymfn X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=9LP6KM4vD/8CwHW7nouRBhWLyQLcK1MkP6aTZbzUlj4= X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748985892743730665?= X-GMAIL-MSGID: =?utf-8?q?1748985892743730665?= Without this information these logs are not actionable. Fixes: 6364d106e041 ("certs: Allow root user to append signed hashes to the blacklist keyring") Signed-off-by: Thomas Weißschuh --- certs/blacklist.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/certs/blacklist.c b/certs/blacklist.c index 41f10601cc72..6e260c4b6a19 100644 --- a/certs/blacklist.c +++ b/certs/blacklist.c @@ -192,7 +192,7 @@ static int mark_raw_hash_blacklisted(const char *hash) KEY_ALLOC_NOT_IN_QUOTA | KEY_ALLOC_BUILT_IN); if (IS_ERR(key)) { - pr_err("Problem blacklisting hash (%ld)\n", PTR_ERR(key)); + pr_err("Problem blacklisting hash %s: %pe\n", hash, key); return PTR_ERR(key); } return 0;