From patchwork Tue Nov 8 14:22:24 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 17067 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2741166wru; Tue, 8 Nov 2022 06:28:37 -0800 (PST) X-Google-Smtp-Source: AMsMyM4AjBylEfSUaSr0uyU13tl/hk4JA5rQum6Gj3waRX3lVAK2JCotTG0slxaqDA0ns8mkTfRb X-Received: by 2002:a17:90b:4c46:b0:213:d3e3:ba44 with SMTP id np6-20020a17090b4c4600b00213d3e3ba44mr49488382pjb.18.1667917717294; Tue, 08 Nov 2022 06:28:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1667917717; cv=none; d=google.com; s=arc-20160816; b=gQAy1Qanwgc0qRPv/FgRsw1yCc1AevdvzlluMkn27EM9Ij+2oM3ZQnBrvUSqG5RNyU iHtE3EhcJbbrn4INIGgaC1uIE1/EgPcXdtdq/RoRRIuDvYZNQANfTQ8PgzuzyvHqEeJi LiW+3hRQyz08dpG0WkmvCI3CAIQsDvRHRMypEaBLW9/gN8otXFcgfaTVC12+NIltTacj ROqHArQohVWQEbSAemYgYy5ra6gmwMx90LHYV/K47X9LUmHROoE+zWO66ByjaCXhgaGp cbkdtkM5MwM65X1xWDuUuqsOMgMsdletRLvW0esHkECb5DXOOR7zHj+EGUQ18dqZADGB Ircw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+Km2wSTS+HEL+2fseQzOIacGCgEiXFCLh7kPJKkiKYY=; b=GC4V54JHrGVSMlOzT000YFYBjtIk4oHcQZ8hrg1QMJeL5D8Xvk0A8O3RM66In5aWNt ytT2psfn1kUSsLndB/NWsGZYMltuTDOV2gqC+IDjcM8lUDzgCv3wOJ00pt2sHixOTYT1 f7qyadyCIXgU/uD8fmnufKy8d6sv4u5nJ0Per/ukJWmVCD/aUwuyYFeLHwWT0TSsyVKw ipJSchSJe86AqeJKSy2qabenFSlFPMc9hBETBC5KE5fboqCWGYajh2WPXXNJ2PZSEQZV ESmmvpWOBGBpvqt8KdzPLpXcOlz8auDs+FX9UkGeAnsdf2Ey3Z3Ad8rtJf0vkHXiuULv rJKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JV+nccWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b75-20020a63344e000000b0046f5ffcfc1dsi17220909pga.324.2022.11.08.06.28.23; Tue, 08 Nov 2022 06:28:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JV+nccWw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234417AbiKHOW5 (ORCPT + 99 others); Tue, 8 Nov 2022 09:22:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234601AbiKHOWS (ORCPT ); Tue, 8 Nov 2022 09:22:18 -0500 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FEC854B2A; Tue, 8 Nov 2022 06:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667917337; x=1699453337; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9wMt9wnnchEhbLXtKxX2j9VHDQPKe8GNUSxFdZnl9NM=; b=JV+nccWw2tmUCMBzCMns2veaLpZAPZZGOmcNoiV+Op3gkbbTUHVu0Lpp DUURDi4g7UZ10OeHF6F3oHmQ7LGepLQElIXp0dD4hyNOo6AFh6fhhK7eH d1jBSlnDUnqvEhfsA4mGFD2E1LOWIq5mbk6d+kQQjEavKYLjEBewvr2Is 1+euyMRjxSHGUDfW0kKAioRUoLfEhWgwL2Bip4eis4d2Vut57+oAKcEgu wHHtLmxXNQYUR4t3Qlo3N82hdBv+iMuOlX6SOvkF63tUtoas/3aG7Qo2x 7VMSPfbizY1iD150L7jgD0pBbpVwRFjIZw7yw8mze6qvqOqKmJLimUrmh g==; X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="310700748" X-IronPort-AV: E=Sophos;i="5.96,148,1665471600"; d="scan'208";a="310700748" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 06:22:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10524"; a="587386417" X-IronPort-AV: E=Sophos;i="5.96,148,1665471600"; d="scan'208";a="587386417" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 08 Nov 2022 06:22:03 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 89C534B5; Tue, 8 Nov 2022 16:22:27 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , Mika Westerberg , Hans de Goede , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Thierry Reding , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, linux-pwm@vger.kernel.org Cc: Andy Shevchenko , Linus Walleij Subject: [PATCH v2 4/6] pwm: lpss: Allow other drivers to enable PWM LPSS Date: Tue, 8 Nov 2022 16:22:24 +0200 Message-Id: <20221108142226.63161-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com> References: <20221108142226.63161-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748938488483984516?= X-GMAIL-MSGID: =?utf-8?q?1748938488483984516?= The PWM LPSS device can be embedded in another device. In order to enable it, allow that drivers to probe a corresponding device. Signed-off-by: Andy Shevchenko Reviewed-by: Mika Westerberg Reviewed-by: Hans de Goede --- drivers/pwm/pwm-lpss.h | 22 +-------------- .../linux/platform_data/x86}/pwm-lpss.h | 28 ++++--------------- 2 files changed, 6 insertions(+), 44 deletions(-) copy {drivers/pwm => include/linux/platform_data/x86}/pwm-lpss.h (53%) diff --git a/drivers/pwm/pwm-lpss.h b/drivers/pwm/pwm-lpss.h index 4561d229b27d..b721532c6c3c 100644 --- a/drivers/pwm/pwm-lpss.h +++ b/drivers/pwm/pwm-lpss.h @@ -13,27 +13,10 @@ #include #include -struct device; +#include #define LPSS_MAX_PWMS 4 -struct pwm_lpss_boardinfo { - unsigned long clk_rate; - unsigned int npwm; - unsigned long base_unit_bits; - /* - * Some versions of the IP may stuck in the state machine if enable - * bit is not set, and hence update bit will show busy status till - * the reset. For the rest it may be otherwise. - */ - bool bypass; - /* - * On some devices the _PS0/_PS3 AML code of the GPU (GFX0) device - * messes with the PWM0 controllers state, - */ - bool other_devices_aml_touches_pwm_regs; -}; - extern const struct pwm_lpss_boardinfo pwm_lpss_byt_info; extern const struct pwm_lpss_boardinfo pwm_lpss_bsw_info; extern const struct pwm_lpss_boardinfo pwm_lpss_bxt_info; @@ -45,7 +28,4 @@ struct pwm_lpss_chip { const struct pwm_lpss_boardinfo *info; }; -struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, void __iomem *base, - const struct pwm_lpss_boardinfo *info); - #endif /* __PWM_LPSS_H */ diff --git a/drivers/pwm/pwm-lpss.h b/include/linux/platform_data/x86/pwm-lpss.h similarity index 53% copy from drivers/pwm/pwm-lpss.h copy to include/linux/platform_data/x86/pwm-lpss.h index 4561d229b27d..296bd837ddbb 100644 --- a/drivers/pwm/pwm-lpss.h +++ b/include/linux/platform_data/x86/pwm-lpss.h @@ -1,21 +1,14 @@ /* SPDX-License-Identifier: GPL-2.0-only */ -/* - * Intel Low Power Subsystem PWM controller driver - * - * Copyright (C) 2014, Intel Corporation - * - * Derived from the original pwm-lpss.c - */ +/* Intel Low Power Subsystem PWM controller driver */ -#ifndef __PWM_LPSS_H -#define __PWM_LPSS_H +#ifndef __PLATFORM_DATA_X86_PWM_LPSS_H +#define __PLATFORM_DATA_X86_PWM_LPSS_H -#include #include struct device; -#define LPSS_MAX_PWMS 4 +struct pwm_lpss_chip; struct pwm_lpss_boardinfo { unsigned long clk_rate; @@ -34,18 +27,7 @@ struct pwm_lpss_boardinfo { bool other_devices_aml_touches_pwm_regs; }; -extern const struct pwm_lpss_boardinfo pwm_lpss_byt_info; -extern const struct pwm_lpss_boardinfo pwm_lpss_bsw_info; -extern const struct pwm_lpss_boardinfo pwm_lpss_bxt_info; -extern const struct pwm_lpss_boardinfo pwm_lpss_tng_info; - -struct pwm_lpss_chip { - struct pwm_chip chip; - void __iomem *regs; - const struct pwm_lpss_boardinfo *info; -}; - struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev, void __iomem *base, const struct pwm_lpss_boardinfo *info); -#endif /* __PWM_LPSS_H */ +#endif /* __PLATFORM_DATA_X86_PWM_LPSS_H */